From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6A7C4361B for ; Mon, 14 Dec 2020 16:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3FC722583 for ; Mon, 14 Dec 2020 16:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730174AbgLNQHb (ORCPT ); Mon, 14 Dec 2020 11:07:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55783 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727063AbgLNQHN (ORCPT ); Mon, 14 Dec 2020 11:07:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607961946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CKOysfJXgz9SEv/3tw1NKD9IbJ/IVoxDoBxG2bfHpqM=; b=TFeSlaOq1N40bGEU7EURz0RV61uyXT3+rQUyFN4JuP7e4ugJZ1HhzzT3NnbbtolutoL7ke b6mwDjzGHqOLodXzXCqbZqLmn44+22js2Gc0P+40XbEADIxt/jXgNNF2+QqDyPSb73vKsa Re9aiD7VAbIgknPd3zNt1FE//za3/Ng= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-6Ei3wN74OhmejfJ_rLX-Ow-1; Mon, 14 Dec 2020 11:05:44 -0500 X-MC-Unique: 6Ei3wN74OhmejfJ_rLX-Ow-1 Received: by mail-ed1-f70.google.com with SMTP id r16so8482975eds.13 for ; Mon, 14 Dec 2020 08:05:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CKOysfJXgz9SEv/3tw1NKD9IbJ/IVoxDoBxG2bfHpqM=; b=DQVXOKgQrV7dooCMSYnpjn3NAtdYU7dFyyLG0dkTfGdvSa/ZADNzzFVGEFDWR+iBHc tTlCeKUY9KDMVnK88s8EzaT3st3Pm7JbBt4rgjjMnHxYQCpuIgbvXeL9W0IejsrG9J4O FNUSYImDrjC/PnVqF+bHKPIQFR8yO7XiWESUk9XcSbcmUinHXmIznT0Nw7QFCh1ZLFe+ 9PZ0f4rIGydWyrk6n13APm97U3Y6vdP8SBRwbDuK352QDPkN6XcJKaGXOhsaPvKZb+mD 9sSGg1IW96I6UVWvDILi6JziXO3zE2Rg32SRfh0F+/KYVOnBhNkooyZ6ClzB7AMZ3TkT dNsw== X-Gm-Message-State: AOAM531V1HnQ/W/lf0NFJTRntM9MSPtd4hB4LCHCPPST+ubTcCdaocYo HsO78c/0NDHaPv4CB64eyq7FbFkGpCSkRGJSM3k1+HlvGP/nAFmafFaDdnvbCUIJCJLqSkhsPGw YZChyZJhkwWlS X-Received: by 2002:a17:906:604e:: with SMTP id p14mr23016278ejj.543.1607961942599; Mon, 14 Dec 2020 08:05:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrcdNJs/vG856VzAHg8Cu6Ust63aIqYsGR68byTwFU2nmYO6bZ3YYIJPcGhTvlayxbn9s0Xg== X-Received: by 2002:a17:906:604e:: with SMTP id p14mr23016266ejj.543.1607961942435; Mon, 14 Dec 2020 08:05:42 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id i13sm6625914edu.22.2020.12.14.08.05.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Dec 2020 08:05:41 -0800 (PST) Subject: Re: [PATCH v5 27/34] KVM: SVM: Add support for booting APs for an SEV-ES guest To: Tom Lendacky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org Cc: Jim Mattson , Joerg Roedel , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Borislav Petkov , Ingo Molnar , Thomas Gleixner , Brijesh Singh References: <47d11ed1c1a48ab71858fc3cde766bf67a4612d1.1607620209.git.thomas.lendacky@amd.com> From: Paolo Bonzini Message-ID: Date: Mon, 14 Dec 2020 17:05:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <47d11ed1c1a48ab71858fc3cde766bf67a4612d1.1607620209.git.thomas.lendacky@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 10/12/20 18:10, Tom Lendacky wrote: > @@ -10144,6 +10144,15 @@ void kvm_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu, u8 vector) > { > struct kvm_segment cs; > > + /* > + * Guests with protected state can't have their state altered by KVM, > + * call the vcpu_deliver_sipi_vector() x86 op for processing. > + */ > + if (vcpu->arch.guest_state_protected) { > + kvm_x86_ops.vcpu_deliver_sipi_vector(vcpu, vector); > + return; > + } > + Also, I don't mind that you just call kvm_x86_ops.vcpu_deliver_sipi_vector from lapic.c, and make VMX just do .vcpu_deliver_sipi_vector = kvm_vcpu_deliver_sipi_vector, (SVM would do it if !guest_state_protected). This matches more or less how I redid the MSR part. Paolo