kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Oliver Upton" <oupton@google.com>,
	kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Jim Mattson <jmattson@google.com>, Peter Shier <pshier@google.com>
Subject: Re: [kvm-unit-tests PATCH] x86: VMX: INVEPT after modifying PA mapping in ept_untwiddle
Date: Wed, 11 Sep 2019 17:45:33 +0200	[thread overview]
Message-ID: <cbd1e9fd-6805-d739-4f71-1718bbc3d9a2@redhat.com> (raw)
In-Reply-To: <20190828082900.88609-1-oupton@google.com>

On 28/08/19 10:29, Oliver Upton wrote:
> ept_untwiddle modifies a PA mapping in the EPT paging structure.
> According to the SDM 28.3.3.4, "Software should use the INVEPT
> instruction with the "single-context" INVEPT type after making any of
> the following changes to an EPT paging-structure entry ... Changing
> the physical address in bits 51:12".
> 
> Suggested-by: Peter Shier <pshier@google.com>
> Signed-off-by: Oliver Upton <oupton@google.com>
> ---
>  x86/vmx_tests.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index 8ad26741277f..94be937da41d 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -2376,6 +2376,7 @@ static unsigned long ept_twiddle(unsigned long gpa, bool mkhuge, int level,
>  static void ept_untwiddle(unsigned long gpa, int level, unsigned long orig_pte)
>  {
>  	set_ept_pte(pml4, gpa, level, orig_pte);
> +	ept_sync(INVEPT_SINGLE, eptp);
>  }
>  
>  static void do_ept_violation(bool leaf, enum ept_access_op op,
> 

Queued, thanks.

Paolo

      reply	other threads:[~2019-09-11 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  8:29 [kvm-unit-tests PATCH] x86: VMX: INVEPT after modifying PA mapping in ept_untwiddle Oliver Upton
2019-09-11 15:45 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbd1e9fd-6805-d739-4f71-1718bbc3d9a2@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=oupton@google.com \
    --cc=pshier@google.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).