From: Jason Wang <jasowang@redhat.com> To: Jason Gunthorpe <jgg@mellanox.com> Cc: "mst@redhat.com" <mst@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "tiwei.bie@intel.com" <tiwei.bie@intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "cunming.liang@intel.com" <cunming.liang@intel.com>, "zhihong.wang@intel.com" <zhihong.wang@intel.com>, "rob.miller@broadcom.com" <rob.miller@broadcom.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "haotian.wang@sifive.com" <haotian.wang@sifive.com>, "lingshan.zhu@intel.com" <lingshan.zhu@intel.com>, "eperezma@redhat.com" <eperezma@redhat.com>, "lulu@redhat.com" <lulu@redhat.com>, Parav Pandit <parav@mellanox.com>, "kevin.tian@intel.com" <kevin.tian@intel.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "hch@infradead.org" <hch@infradead.org>, "aadam@redhat.com" <aadam@redhat.com>, "jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>, Jiri Pirko <jiri@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, "hanand@xilinx.com" <hanand@xilinx.com>, "mhabets@solarflare.com" <mhabets@solarflare.com>, "kuba@kernel.org" <kuba@kernel.org> Subject: Re: [PATCH 5/5] vdpasim: vDPA device simulator Date: Mon, 20 Jan 2020 16:01:10 +0800 Message-ID: <cd5477b1-7e41-aeeb-c592-09b2ec81566a@redhat.com> (raw) In-Reply-To: <20200117141021.GW20978@mellanox.com> On 2020/1/17 下午10:10, Jason Gunthorpe wrote: > On Fri, Jan 17, 2020 at 05:32:39PM +0800, Jason Wang wrote: >> On 2020/1/16 下午11:47, Jason Gunthorpe wrote: >>> On Thu, Jan 16, 2020 at 08:42:31PM +0800, Jason Wang wrote: >>>> This patch implements a software vDPA networking device. The datapath >>>> is implemented through vringh and workqueue. The device has an on-chip >>>> IOMMU which translates IOVA to PA. For kernel virtio drivers, vDPA >>>> simulator driver provides dma_ops. For vhost driers, set_map() methods >>>> of vdpa_config_ops is implemented to accept mappings from vhost. >>>> >>>> A sysfs based management interface is implemented, devices are >>>> created and removed through: >>>> >>>> /sys/devices/virtual/vdpa_simulator/netdev/{create|remove} >>> This is very gross, creating a class just to get a create/remove and >>> then not using the class for anything else? Yuk. >> >> It includes more information, e.g the devices and the link from vdpa_sim >> device and vdpa device. > I feel like regardless of how the device is created there should be a > consistent virtio centric management for post-creation tasks, such as > introspection and destruction Right, actually, this is something that could be done by sysfs as well. Having an intermediate steps as "activate" and introducing attributes for post-creation tasks. > > A virto struct device should already have back pointers to it's parent > device, which should be enough to discover the vdpa_sim, none of the > extra sysfs munging should be needed. > >>>> Netlink based lifecycle management could be implemented for vDPA >>>> simulator as well. >>> This is just begging for a netlink based approach. >>> >>> Certainly netlink driven removal should be an agreeable standard for >>> all devices, I think. >> >> Well, I think Parav had some proposals during the discussion of mdev >> approach. But I'm not sure if he had any RFC codes for me to integrate it >> into vdpasim. >> >> Or do you want me to propose the netlink API? If yes, would you prefer to a >> new virtio dedicated one or be a subset of devlink? > Well, lets see what feed back Parav has > > Jason Ok. Thanks
next prev parent reply index Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-16 12:42 [PATCH 0/5] vDPA support Jason Wang 2020-01-16 12:42 ` [PATCH 1/5] vhost: factor out IOTLB Jason Wang 2020-01-17 4:14 ` Randy Dunlap 2020-01-17 9:34 ` Jason Wang 2020-01-18 0:01 ` kbuild test robot 2020-01-18 0:40 ` kbuild test robot 2020-01-16 12:42 ` [PATCH 2/5] vringh: IOTLB support Jason Wang 2020-01-17 21:54 ` kbuild test robot 2020-01-17 22:33 ` kbuild test robot 2020-01-16 12:42 ` [PATCH 3/5] vDPA: introduce vDPA bus Jason Wang 2020-01-16 15:22 ` Jason Gunthorpe 2020-01-17 3:03 ` Jason Wang 2020-01-17 13:54 ` Jason Gunthorpe 2020-01-20 7:50 ` Jason Wang 2020-01-20 12:17 ` Michael S. Tsirkin 2020-01-20 17:50 ` Jason Gunthorpe 2020-01-20 21:56 ` Michael S. Tsirkin 2020-01-21 14:12 ` Jason Gunthorpe 2020-01-21 14:15 ` Michael S. Tsirkin 2020-01-21 14:16 ` Jason Gunthorpe 2020-01-21 8:40 ` Tian, Kevin 2020-01-21 9:41 ` Jason Wang 2020-01-17 4:16 ` Randy Dunlap 2020-01-17 9:34 ` Jason Wang 2020-01-17 12:13 ` Michael S. Tsirkin 2020-01-17 13:52 ` Jason Wang [not found] ` <CAJPjb1+fG9L3=iKbV4Vn13VwaeDZZdcfBPvarogF_Nzhk+FnKg@mail.gmail.com> 2020-01-19 9:07 ` Shahaf Shuler 2020-01-19 9:59 ` Michael S. Tsirkin 2020-01-20 8:44 ` Jason Wang 2020-01-20 12:09 ` Michael S. Tsirkin 2020-01-21 3:32 ` Jason Wang 2020-01-20 8:43 ` Jason Wang 2020-01-20 17:49 ` Jason Gunthorpe 2020-01-20 20:51 ` Shahaf Shuler 2020-01-20 21:25 ` Michael S. Tsirkin 2020-01-20 21:47 ` Shahaf Shuler 2020-01-20 21:59 ` Michael S. Tsirkin 2020-01-21 6:01 ` Shahaf Shuler 2020-01-21 7:57 ` Jason Wang 2020-01-21 14:07 ` Jason Gunthorpe 2020-01-21 14:16 ` Michael S. Tsirkin 2020-01-20 21:48 ` Michael S. Tsirkin 2020-01-21 4:00 ` Jason Wang 2020-01-21 5:47 ` Michael S. Tsirkin 2020-01-21 8:00 ` Jason Wang 2020-01-21 8:15 ` Michael S. Tsirkin 2020-01-21 8:35 ` Jason Wang 2020-01-21 11:09 ` Shahaf Shuler 2020-01-22 6:36 ` Jason Wang 2020-01-21 14:05 ` Jason Gunthorpe 2020-01-21 14:17 ` Michael S. Tsirkin 2020-01-22 6:18 ` Jason Wang 2020-01-20 8:19 ` Jason Wang 2020-01-16 12:42 ` [PATCH 4/5] virtio: introduce a vDPA based transport Jason Wang 2020-01-16 15:38 ` Jason Gunthorpe 2020-01-17 9:32 ` Jason Wang 2020-01-17 14:00 ` Jason Gunthorpe 2020-01-20 7:52 ` Jason Wang 2020-01-17 4:10 ` Randy Dunlap 2020-01-16 12:42 ` [PATCH 5/5] vdpasim: vDPA device simulator Jason Wang 2020-01-16 15:47 ` Jason Gunthorpe 2020-01-17 9:32 ` Jason Wang 2020-01-17 14:10 ` Jason Gunthorpe 2020-01-20 8:01 ` Jason Wang [this message] 2020-02-04 4:19 ` Jason Wang 2020-01-17 4:12 ` Randy Dunlap 2020-01-17 9:35 ` Jason Wang 2020-01-18 18:18 ` kbuild test robot 2020-01-28 3:32 ` Dan Carpenter 2020-02-04 4:07 ` Jason Wang 2020-02-04 8:21 ` Zhu Lingshan 2020-02-04 8:28 ` Jason Wang 2020-02-04 12:52 ` Jason Gunthorpe 2020-02-05 3:14 ` Jason Wang 2020-01-21 8:44 ` [PATCH 0/5] vDPA support Tian, Kevin 2020-01-21 9:39 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cd5477b1-7e41-aeeb-c592-09b2ec81566a@redhat.com \ --to=jasowang@redhat.com \ --cc=aadam@redhat.com \ --cc=cunming.liang@intel.com \ --cc=eperezma@redhat.com \ --cc=hanand@xilinx.com \ --cc=haotian.wang@sifive.com \ --cc=hch@infradead.org \ --cc=jakub.kicinski@netronome.com \ --cc=jgg@mellanox.com \ --cc=jiri@mellanox.com \ --cc=kevin.tian@intel.com \ --cc=kuba@kernel.org \ --cc=kvm@vger.kernel.org \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=mhabets@solarflare.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=parav@mellanox.com \ --cc=rdunlap@infradead.org \ --cc=rob.miller@broadcom.com \ --cc=shahafs@mellanox.com \ --cc=stefanha@redhat.com \ --cc=tiwei.bie@intel.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiao.w.wang@intel.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ kvm@vger.kernel.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git