From: Jason Wang <jasowang@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>,
mst@redhat.com, sgarzare@redhat.com, stefanha@redhat.com
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
arei.gonglei@huawei.com, yechuan@huawei.com,
huangzhichao@huawei.com
Subject: Re: [RFC 1/3] vdpa: support exposing the config size to userspace
Date: Tue, 18 Jan 2022 11:06:42 +0800 [thread overview]
Message-ID: <ce3890b8-8f48-847d-b029-e29cc9261f18@redhat.com> (raw)
In-Reply-To: <20220117092921.1573-2-longpeng2@huawei.com>
在 2022/1/17 下午5:29, Longpeng(Mike) 写道:
> From: Longpeng <longpeng2@huawei.com>
>
> - GET_CONFIG_SIZE: the size of the virtio config space
I think we need to be verbose here. And it would be better to quote what
spec said:
"
The device MUST allow reading of any device-specific configuration field
before FEATURES_OK is set by the driver. This includes fields which are
conditional on feature bits, as long as those feature bits are offered
by the device.
"
I guess the size should contain the conditional on features bits.
(Or maybe we need to tweak the comment for get_config_size as well).
Other looks good.
Thanks
>
> Signed-off-by: Longpeng <longpeng2@huawei.com>
> ---
> drivers/vhost/vdpa.c | 17 +++++++++++++++++
> include/uapi/linux/vhost.h | 4 ++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index 29cced1cd277..1eea14a4ea56 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -355,6 +355,20 @@ static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp)
> return 0;
> }
>
> +static long vhost_vdpa_get_config_size(struct vhost_vdpa *v, u32 __user *argp)
> +{
> + struct vdpa_device *vdpa = v->vdpa;
> + const struct vdpa_config_ops *ops = vdpa->config;
> + u32 size;
> +
> + size = ops->get_config_size(vdpa);
> +
> + if (copy_to_user(argp, &size, sizeof(size)))
> + return -EFAULT;
> +
> + return 0;
> +}
> +
> static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd,
> void __user *argp)
> {
> @@ -492,6 +506,9 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep,
> case VHOST_VDPA_GET_IOVA_RANGE:
> r = vhost_vdpa_get_iova_range(v, argp);
> break;
> + case VHOST_VDPA_GET_CONFIG_SIZE:
> + r = vhost_vdpa_get_config_size(v, argp);
> + break;
> default:
> r = vhost_dev_ioctl(&v->vdev, cmd, argp);
> if (r == -ENOIOCTLCMD)
> diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
> index c998860d7bbc..bc74e95a273a 100644
> --- a/include/uapi/linux/vhost.h
> +++ b/include/uapi/linux/vhost.h
> @@ -150,4 +150,8 @@
> /* Get the valid iova range */
> #define VHOST_VDPA_GET_IOVA_RANGE _IOR(VHOST_VIRTIO, 0x78, \
> struct vhost_vdpa_iova_range)
> +
> +/* Get the config size */
> +#define VHOST_VDPA_GET_CONFIG_SIZE _IOR(VHOST_VIRTIO, 0x79, __u32)
> +
> #endif
next prev parent reply other threads:[~2022-01-18 3:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 9:29 [RFC 0/3] vdpa: add two ioctl commands to support generic vDPA Longpeng(Mike)
2022-01-17 9:29 ` [RFC 1/3] vdpa: support exposing the config size to userspace Longpeng(Mike)
2022-01-18 3:06 ` Jason Wang [this message]
2022-01-17 9:29 ` [RFC 2/3] vdpa: support exposing the count of vqs " Longpeng(Mike)
2022-01-18 3:07 ` Jason Wang
2022-03-10 3:16 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-01-17 9:29 ` [RFC 3/3] vdpasim_net: control virtqueue support Longpeng(Mike)
2022-01-18 3:09 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce3890b8-8f48-847d-b029-e29cc9261f18@redhat.com \
--to=jasowang@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=huangzhichao@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yechuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).