From: Paolo Bonzini <pbonzini@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>,
joro@8bytes.org, rkrcmar@redhat.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mingfangsen@huawei.com
Subject: Re: [PATCH] KVM : remove redundant assignment of var new_entry
Date: Wed, 14 Aug 2019 14:41:50 +0200 [thread overview]
Message-ID: <ce3a477a-d323-32ce-b950-470e50e0811d@redhat.com> (raw)
In-Reply-To: <20190812023300.20153-1-linmiaohe@huawei.com>
On 12/08/19 04:33, Miaohe Lin wrote:
> new_entry is reassigned a new value next line. So
> it's redundant and remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> arch/x86/kvm/svm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index d685491fce4d..e3d3b2128f2b 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -1714,7 +1714,6 @@ static int avic_init_backing_page(struct kvm_vcpu *vcpu)
> if (!entry)
> return -EINVAL;
>
> - new_entry = READ_ONCE(*entry);
> new_entry = __sme_set((page_to_phys(svm->avic_backing_page) &
> AVIC_PHYSICAL_ID_ENTRY_BACKING_PAGE_MASK) |
> AVIC_PHYSICAL_ID_ENTRY_VALID_MASK);
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2019-08-14 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 2:33 [PATCH] KVM : remove redundant assignment of var new_entry Miaohe Lin
2019-08-14 12:41 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce3a477a-d323-32ce-b950-470e50e0811d@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).