From: David Edmondson <david.edmondson@oracle.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: KVM <kvm@vger.kernel.org>, Joao Martins <joao.m.martins@oracle.com>
Subject: Re: [kvm-unit-tests PATCH] x86: check that clflushopt of an MMIO address succeeds
Date: Thu, 05 Nov 2020 10:20:37 +0000 [thread overview]
Message-ID: <cun1rh82jgq.fsf@vroomfondel.hh.sledj.net> (raw)
In-Reply-To: <D92A2CAA-584C-48FE-A071-682DB287432A@gmail.com>
On Wednesday, 2020-11-04 at 23:53:01 -08, Nadav Amit wrote:
>> On Nov 3, 2020, at 8:08 AM, David Edmondson <david.edmondson@oracle.com> wrote:
>>
>> Verify that the clflushopt instruction succeeds when applied to an
>> MMIO address at both cpl0 and cpl3.
>>
>> Suggested-by: Joao Martins <joao.m.martins@oracle.com>
>> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
>>
>
> [snip]
>
>> + ret = pci_find_dev(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_TEST);
>> + if (ret != PCIDEVADDR_INVALID) {
>> + pci_dev_init(&pcidev, ret);
>
> Just wondering, and perhaps this question is more general: does this test
> really need the Red-Hat test device?
>
> I know it is an emulated device, but can’t we use some other MMIO address
> (e.g., PIT) that is also available on bare-metal?
If it's acceptable to assume that HPET is present and at 0xfed00000,
then it could be used.
dme.
--
Does everyone stare the way I do?
prev parent reply other threads:[~2020-11-05 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 16:08 [kvm-unit-tests PATCH] x86: check that clflushopt of an MMIO address succeeds David Edmondson
2020-11-05 7:53 ` Nadav Amit
2020-11-05 10:20 ` David Edmondson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cun1rh82jgq.fsf@vroomfondel.hh.sledj.net \
--to=david.edmondson@oracle.com \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).