Re: [kvm-unit-tests PATCH v1 2/6] s390x: lib: css: SCSW bit definitions

[Pierre Morel <pmorel@linux.ibm.com>]

On 3/19/21 11:16 AM, Cornelia Huck wrote:
> On Thu, 18 Mar 2021 14:26:24 +0100
> Pierre Morel <pmorel@linux.ibm.com> wrote:
> 
>> We need the SCSW definitions to test clear and halt subchannel.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>>   lib/s390x/css.h | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/lib/s390x/css.h b/lib/s390x/css.h
>> index b0de3a3..460b0bd 100644
>> --- a/lib/s390x/css.h
>> +++ b/lib/s390x/css.h
>> @@ -67,6 +67,29 @@ struct scsw {
>>   #define SCSW_SC_PRIMARY		0x00000004
>>   #define SCSW_SC_INTERMEDIATE	0x00000008
>>   #define SCSW_SC_ALERT		0x00000010
>> +#define SCSW_AC_SUSPEND_PEND	0x00000020
>> +#define SCSW_AC_DEVICE_PEND	0x00000040
>> +#define SCSW_AC_SUBCHANNEL_PEND	0x00000080
> 
> Naming: aren't these two rather "active", not "pending"? So maybe
> SCSW_AC_DEVICE_ACTIVE and SCSW_AC_SUBCH_ACTIVE?

right, I modify this

> 
>> +#define SCSW_AC_CLEAR_PEND	0x00000100
>> +#define SCSW_AC_HALT_PEND	0x00000200
>> +#define SCSW_AC_START_PEND	0x00000400
>> +#define SCSW_AC_RESUME_PEND	0x00000800
>> +#define SCSW_FC_CLEAR		0x00001000
>> +#define SCSW_FC_HALT		0x00002000
>> +#define SCSW_FC_START		0x00004000
>> +#define SCSW_QDIO_RESERVED	0x00008000
>> +#define SCSW_PATH_NON_OP	0x00010000
>> +#define SCSW_EXTENDED_CTRL	0x00020000
>> +#define SCSW_ZERO_COND		0x00040000
>> +#define SCSW_SUPPRESS_SUSP_INT	0x00080000
>> +#define SCSW_IRB_FMT_CTRL	0x00100000
>> +#define SCSW_INITIAL_IRQ_STATUS	0x00200000
>> +#define SCSW_PREFETCH		0x00400000
>> +#define SCSW_CCW_FORMAT		0x00800000
>> +#define SCSW_DEFERED_CC		0x03000000
>> +#define SCSW_ESW_FORMAT		0x04000000
>> +#define SCSW_SUSPEND_CTRL	0x08000000
>> +#define SCSW_KEY		0xf0000000
>>   	uint32_t ctrl;
>>   	uint32_t ccw_addr;
>>   #define SCSW_DEVS_DEV_END	0x04
> 

-- 
Pierre Morel
IBM Lab Boeblingen