From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBD7C433E0 for ; Wed, 17 Jun 2020 11:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55BF120786 for ; Wed, 17 Jun 2020 11:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgFQLF6 (ORCPT ); Wed, 17 Jun 2020 07:05:58 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:28292 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgFQLF5 (ORCPT ); Wed, 17 Jun 2020 07:05:57 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05HB2QZ1081837; Wed, 17 Jun 2020 07:05:57 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 31q6hjttes-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jun 2020 07:05:57 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 05HB2cjG083555; Wed, 17 Jun 2020 07:05:57 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 31q6hjttdc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jun 2020 07:05:56 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05HB5sD0022317; Wed, 17 Jun 2020 11:05:54 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma01fra.de.ibm.com with ESMTP id 31q6chrc3w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jun 2020 11:05:54 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05HB5qNq40698150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jun 2020 11:05:52 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 46D4411C052; Wed, 17 Jun 2020 11:05:52 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D456911C050; Wed, 17 Jun 2020 11:05:51 +0000 (GMT) Received: from oc3016276355.ibm.com (unknown [9.145.186.32]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 17 Jun 2020 11:05:51 +0000 (GMT) Subject: Re: [kvm-unit-tests PATCH v9 08/12] s390x: retrieve decimal and hexadecimal kernel parameters To: Cornelia Huck Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com References: <1592213521-19390-1-git-send-email-pmorel@linux.ibm.com> <1592213521-19390-9-git-send-email-pmorel@linux.ibm.com> <20200617103748.4840b43b.cohuck@redhat.com> From: Pierre Morel Message-ID: Date: Wed, 17 Jun 2020 13:05:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200617103748.4840b43b.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-17_03:2020-06-17,2020-06-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 cotscore=-2147483648 priorityscore=1501 clxscore=1015 malwarescore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006170083 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-06-17 10:37, Cornelia Huck wrote: > On Mon, 15 Jun 2020 11:31:57 +0200 > Pierre Morel wrote: > >> We often need to retrieve hexadecimal kernel parameters. >> Let's implement a shared utility to do it. >> >> Signed-off-by: Pierre Morel >> --- >> lib/s390x/kernel-args.c | 60 +++++++++++++++++++++++++++++++++++++++++ >> lib/s390x/kernel-args.h | 18 +++++++++++++ >> s390x/Makefile | 1 + >> 3 files changed, 79 insertions(+) >> create mode 100644 lib/s390x/kernel-args.c >> create mode 100644 lib/s390x/kernel-args.h >> > > (...) > >> diff --git a/lib/s390x/kernel-args.h b/lib/s390x/kernel-args.h >> new file mode 100644 >> index 0000000..a88e34e >> --- /dev/null >> +++ b/lib/s390x/kernel-args.h >> @@ -0,0 +1,18 @@ >> +/* >> + * Kernel argument >> + * >> + * Copyright (c) 2020 IBM Corp >> + * >> + * Authors: >> + * Pierre Morel >> + * >> + * This code is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2. >> + */ >> + >> +#ifndef KERNEL_ARGS_H >> +#define KERNEL_ARGS_H >> + >> +int kernel_arg(int argc, char *argv[], const char *str, unsigned long *val); > > get_kernel_arg()? OK, is more explicit. > >> + >> +#endif > > Acked-by: Cornelia Huck > Thanks, Pierre -- Pierre Morel IBM Lab Boeblingen