From: Auger Eric <eric.auger@redhat.com> To: Andrew Jones <drjones@redhat.com>, Ricardo Koller <ricarkol@google.com> Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, maz@kernel.org, alexandru.elisei@arm.com Subject: Re: [PATCH v2 2/5] KVM: selftests: Introduce UCALL_UNHANDLED for unhandled vector reporting Date: Thu, 6 May 2021 14:27:50 +0200 [thread overview] Message-ID: <da543870-bde1-8ac3-16b8-d253ce3423ce@redhat.com> (raw) In-Reply-To: <20210503110909.n7chjg2run6gaeq3@gator.home> Hi Ricardo, On 5/3/21 1:09 PM, Andrew Jones wrote: > On Fri, Apr 30, 2021 at 04:24:04PM -0700, Ricardo Koller wrote: >> x86, the only arch implementing exception handling, reports unhandled >> vectors using port IO at a specific port number. This replicates what >> ucall already does. >> >> Introduce a new ucall type, UCALL_UNHANDLED, for guests to report >> unhandled exceptions. Then replace the x86 unhandled vector exception >> reporting to use it instead of port IO. This new ucall type will be >> used in the next commits by arm64 to report unhandled vectors as well. >> >> Tested: Forcing a page fault in the ./x86_64/xapic_ipi_test >> halter_guest_code() shows this: >> >> $ ./x86_64/xapic_ipi_test >> ... >> Unexpected vectored event in guest (vector:0xe) >> >> Signed-off-by: Ricardo Koller <ricarkol@google.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric >> --- >> tools/testing/selftests/kvm/include/kvm_util.h | 1 + >> .../selftests/kvm/include/x86_64/processor.h | 2 -- >> .../testing/selftests/kvm/lib/x86_64/processor.c | 15 ++++++--------- >> 3 files changed, 7 insertions(+), 11 deletions(-) >> >> diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h >> index bea4644d645d..7880929ea548 100644 >> --- a/tools/testing/selftests/kvm/include/kvm_util.h >> +++ b/tools/testing/selftests/kvm/include/kvm_util.h >> @@ -347,6 +347,7 @@ enum { >> UCALL_SYNC, >> UCALL_ABORT, >> UCALL_DONE, >> + UCALL_UNHANDLED, >> }; >> >> #define UCALL_MAX_ARGS 6 >> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h >> index 12889d3e8948..ff4da2f95b13 100644 >> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h >> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h >> @@ -53,8 +53,6 @@ >> #define CPUID_PKU (1ul << 3) >> #define CPUID_LA57 (1ul << 16) >> >> -#define UNEXPECTED_VECTOR_PORT 0xfff0u >> - >> /* General Registers in 64-Bit Mode */ >> struct gpr64_regs { >> u64 rax; >> diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c >> index e156061263a6..96e2bd9d66eb 100644 >> --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c >> +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c >> @@ -1207,7 +1207,7 @@ static void set_idt_entry(struct kvm_vm *vm, int vector, unsigned long addr, >> >> void kvm_exit_unexpected_vector(uint32_t value) >> { >> - outl(UNEXPECTED_VECTOR_PORT, value); >> + ucall(UCALL_UNHANDLED, 1, value); >> } >> >> void route_exception(struct ex_regs *regs) >> @@ -1260,16 +1260,13 @@ void vm_install_vector_handler(struct kvm_vm *vm, int vector, >> >> void assert_on_unhandled_exception(struct kvm_vm *vm, uint32_t vcpuid) >> { >> - if (vcpu_state(vm, vcpuid)->exit_reason == KVM_EXIT_IO >> - && vcpu_state(vm, vcpuid)->io.port == UNEXPECTED_VECTOR_PORT >> - && vcpu_state(vm, vcpuid)->io.size == 4) { >> - /* Grab pointer to io data */ >> - uint32_t *data = (void *)vcpu_state(vm, vcpuid) >> - + vcpu_state(vm, vcpuid)->io.data_offset; >> + struct ucall uc; >> >> + if (get_ucall(vm, vcpuid, &uc) == UCALL_UNHANDLED) { >> + uint64_t vector = uc.args[0]; >> TEST_ASSERT(false, >> - "Unexpected vectored event in guest (vector:0x%x)", >> - *data); >> + "Unexpected vectored event in guest (vector:0x%lx)", >> + vector); > > nit: Could have changed this TEST_ASSERT(false, ...) to TEST_FAIL while > touching it. > >> } >> } >> >> -- >> 2.31.1.527.g47e6f16901-goog >> > > Reviewed-by: Andrew Jones <drjones@redhat.com> > > Thanks, > drew >
next prev parent reply other threads:[~2021-05-06 12:27 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-30 23:24 [PATCH v2 0/5] KVM: selftests: arm64 exception handling and debug test Ricardo Koller 2021-04-30 23:24 ` [PATCH v2 1/5] KVM: selftests: Rename vm_handle_exception Ricardo Koller 2021-05-03 11:02 ` Andrew Jones 2021-05-06 12:27 ` Auger Eric 2021-04-30 23:24 ` [PATCH v2 2/5] KVM: selftests: Introduce UCALL_UNHANDLED for unhandled vector reporting Ricardo Koller 2021-05-03 11:09 ` Andrew Jones 2021-05-06 12:27 ` Auger Eric [this message] 2021-04-30 23:24 ` [PATCH v2 3/5] KVM: selftests: Move GUEST_ASSERT_EQ to utils header Ricardo Koller 2021-05-03 11:31 ` Andrew Jones 2021-04-30 23:24 ` [PATCH v2 4/5] KVM: selftests: Add exception handling support for aarch64 Ricardo Koller 2021-05-03 10:32 ` Marc Zyngier 2021-05-03 19:12 ` Ricardo Koller 2021-05-06 12:30 ` Auger Eric 2021-05-06 19:14 ` Ricardo Koller 2021-05-07 14:08 ` Auger Eric 2021-05-07 17:54 ` Ricardo Koller 2021-05-12 7:27 ` Ricardo Koller 2021-05-12 8:19 ` Auger Eric 2021-05-12 8:33 ` Marc Zyngier 2021-05-12 8:52 ` Auger Eric 2021-05-12 16:06 ` Ricardo Koller 2021-05-12 12:59 ` Zenghui Yu 2021-05-12 13:43 ` Marc Zyngier 2021-05-12 16:03 ` Ricardo Koller 2021-05-12 16:18 ` Marc Zyngier 2021-05-12 21:39 ` Ricardo Koller 2021-05-07 14:31 ` Marc Zyngier 2021-05-07 18:02 ` Ricardo Koller 2021-05-03 12:39 ` Andrew Jones 2021-04-30 23:24 ` [PATCH v2 5/5] KVM: selftests: Add aarch64/debug-exceptions test Ricardo Koller 2021-05-03 12:49 ` Andrew Jones 2021-05-24 12:14 ` [PATCH v2 0/5] KVM: selftests: arm64 exception handling and debug test Paolo Bonzini 2021-05-24 12:59 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=da543870-bde1-8ac3-16b8-d253ce3423ce@redhat.com \ --to=eric.auger@redhat.com \ --cc=alexandru.elisei@arm.com \ --cc=drjones@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=maz@kernel.org \ --cc=pbonzini@redhat.com \ --cc=ricarkol@google.com \ --subject='Re: [PATCH v2 2/5] KVM: selftests: Introduce UCALL_UNHANDLED for unhandled vector reporting' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).