From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86778C4320E for ; Tue, 31 Aug 2021 15:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CD7E60241 for ; Tue, 31 Aug 2021 15:11:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238678AbhHaPMS (ORCPT ); Tue, 31 Aug 2021 11:12:18 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:6148 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238058AbhHaPMR (ORCPT ); Tue, 31 Aug 2021 11:12:17 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17VF3H56011034; Tue, 31 Aug 2021 11:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=lfZKUkcA9RVDn+arm7XBx7Ccggahtb0HWRGQc3Eqw80=; b=BV3cfNxryuSiN00jhDUiVMaivz0doDaSuQAB9rvFSdF/soIq6dNaJUBBUvQ1ZpDZ4iuQ OiG8T4+37kiRZhehhuh4dhu3lp0Al14s7AM8d9cFpDHg6+90H7fXuzPnupYgMmgxpWxA Rx9rsQYQVL86bxQpTqJEvMqSLDzYQgRIc5JjQSNFsAxTUS1SJUkNKITev951rUiURbxy 9k8ryI/0G2p+SpIoF+qzMwHSPA9TTm2XQMnqekCee5+K3pDA6LQ8hT2fQ+wmo8zCN7H7 JMJwcAoMrgdE4d0g50iNOsFIlLGGC4IN2+RFWVL9CQ7cj3HyW9zMqwFDnkPKgSOfKM+x Pg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3asm5v6drm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Aug 2021 11:11:21 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 17VF3vWQ014713; Tue, 31 Aug 2021 11:11:20 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 3asm5v6dqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Aug 2021 11:11:20 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17VF7ZRM028389; Tue, 31 Aug 2021 15:11:19 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma04ams.nl.ibm.com with ESMTP id 3aqcs9cwne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Aug 2021 15:11:18 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17VFB6Xr49086882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Aug 2021 15:11:06 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1259F522CD; Tue, 31 Aug 2021 15:11:06 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.145.164.122]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id A4781522CA; Tue, 31 Aug 2021 15:11:05 +0000 (GMT) Subject: Re: [PATCH v4 04/14] KVM: s390: pv: avoid stalls when making pages secure To: Claudio Imbrenda Cc: kvm@vger.kernel.org, cohuck@redhat.com, frankja@linux.ibm.com, thuth@redhat.com, pasic@linux.ibm.com, david@redhat.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Ulrich.Weigand@de.ibm.com References: <20210818132620.46770-1-imbrenda@linux.ibm.com> <20210818132620.46770-5-imbrenda@linux.ibm.com> <731aeb25-3883-5941-9400-7cd8c43fc31c@de.ibm.com> <20210831170020.7aa4a1ba@p-imbrenda> From: Christian Borntraeger Message-ID: Date: Tue, 31 Aug 2021 17:11:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210831170020.7aa4a1ba@p-imbrenda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: QEQkUSsoETBJ8kxMmBgjPJZqb_EUCA5P X-Proofpoint-GUID: Zgcq4LzJo7d-Onv4G5uNUscabZgo5Dfv X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-31_07:2021-08-31,2021-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108310080 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 31.08.21 17:00, Claudio Imbrenda wrote: > On Tue, 31 Aug 2021 16:32:24 +0200 > Christian Borntraeger wrote: > >> On 18.08.21 15:26, Claudio Imbrenda wrote: >>> Improve make_secure_pte to avoid stalls when the system is heavily >>> overcommitted. This was especially problematic in kvm_s390_pv_unpack, >>> because of the loop over all pages that needed unpacking. >>> >>> Due to the locks being held, it was not possible to simply replace >>> uv_call with uv_call_sched. A more complex approach was >>> needed, in which uv_call is replaced with __uv_call, which does not >>> loop. When the UVC needs to be executed again, -EAGAIN is returned, and >>> the caller (or its caller) will try again. >>> >>> When -EAGAIN is returned, the path is the same as when the page is in >>> writeback (and the writeback check is also performed, which is >>> harmless). >> >> To me it looks like >> handle_pv_uvc does not handle EAGAIN but also calls into this code. Is this code >> path ok or do we need to change something here? > > EAGAIN will be propagated all the way to userspace, which will retry. > > if the UVC fails, the page does not get unpinned, and the next attempt > to run the UVC in the guest will trigger this same path. > > if you don't like it, I can change handle_pv_uvc like this > > if (rc == -EINVAL || rc == -EAGAIN) > > which will save a trip to userspace I think a comment would be good. > >> >>> >>> Signed-off-by: Claudio Imbrenda >>> Fixes: 214d9bbcd3a672 ("s390/mm: provide memory management functions for protected KVM guests") >>> --- >>> arch/s390/kernel/uv.c | 29 +++++++++++++++++++++++------ >>> 1 file changed, 23 insertions(+), 6 deletions(-) >>> >>> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c >>> index aeb0a15bcbb7..68a8fbafcb9c 100644 >>> --- a/arch/s390/kernel/uv.c >>> +++ b/arch/s390/kernel/uv.c >>> @@ -180,7 +180,7 @@ static int make_secure_pte(pte_t *ptep, unsigned long addr, >>> { >>> pte_t entry = READ_ONCE(*ptep); >>> struct page *page; >>> - int expected, rc = 0; >>> + int expected, cc = 0; >>> >>> if (!pte_present(entry)) >>> return -ENXIO; >>> @@ -196,12 +196,25 @@ static int make_secure_pte(pte_t *ptep, unsigned long addr, >>> if (!page_ref_freeze(page, expected)) >>> return -EBUSY; >>> set_bit(PG_arch_1, &page->flags); >>> - rc = uv_call(0, (u64)uvcb); >>> + /* >>> + * If the UVC does not succeed or fail immediately, we don't want to >>> + * loop for long, or we might get stall notifications. >>> + * On the other hand, this is a complex scenario and we are holding a lot of >>> + * locks, so we can't easily sleep and reschedule. We try only once, >>> + * and if the UVC returned busy or partial completion, we return >>> + * -EAGAIN and we let the callers deal with it. >>> + */ >>> + cc = __uv_call(0, (u64)uvcb); >>> page_ref_unfreeze(page, expected); >>> - /* Return -ENXIO if the page was not mapped, -EINVAL otherwise */ >>> - if (rc) >>> - rc = uvcb->rc == 0x10a ? -ENXIO : -EINVAL; >>> - return rc; >>> + /* >>> + * Return -ENXIO if the page was not mapped, -EINVAL for other errors. >>> + * If busy or partially completed, return -EAGAIN. >>> + */ >>> + if (cc == UVC_CC_OK) >>> + return 0; >>> + else if (cc == UVC_CC_BUSY || cc == UVC_CC_PARTIAL) >>> + return -EAGAIN; >>> + return uvcb->rc == 0x10a ? -ENXIO : -EINVAL; >>> } >>> >>> /* >>> @@ -254,6 +267,10 @@ int gmap_make_secure(struct gmap *gmap, unsigned long gaddr, void *uvcb) >>> mmap_read_unlock(gmap->mm); >>> >>> if (rc == -EAGAIN) { >>> + /* >>> + * If we are here because the UVC returned busy or partial >>> + * completion, this is just a useless check, but it is safe. >>> + */ >>> wait_on_page_writeback(page); >>> } else if (rc == -EBUSY) { >>> /* >>> >