From: Paolo Bonzini <pbonzini@redhat.com>
To: Peng Wu <wupeng58@huawei.com>, tsbogend@alpha.franken.de
Cc: chenhc@lemote.com, aleksandar.qemu.devel@gmail.com,
colin.king@canonical.com, tianjia.zhang@linux.alibaba.com,
huanglllzu@gmail.com, linux-mips@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] emulate:Fix build error
Date: Fri, 31 Jul 2020 09:36:24 +0200 [thread overview]
Message-ID: <ddee30c4-6190-5cbc-6340-c138bd1550b5@redhat.com> (raw)
In-Reply-To: <1596179807-17713-1-git-send-email-wupeng58@huawei.com>
On 31/07/20 09:16, Peng Wu wrote:
> The declaration of function kvm_mips_complete_mmio_load
> has only one formal parameter,but two parameters are passed
> when called. So, the following error is seen while building
> emulate.c
>
> arch/mips/kvm/emulate.c: In function ‘kvm_mips_emulate_load’:
> arch/mips/kvm/emulate.c:2130:3: error: too many arguments
> to function ‘kvm_mips_complete_mmio_load’
> kvm_mips_complete_mmio_load(vcpu, run);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from linux/include/linux/kvm_host.h:36,
> from linux/arch/mips/kvm/emulate.c:15:
> arch/mips/include/asm/kvm_host.h:1072:30: note: declared here
> extern enum emulation_result
> kvm_mips_complete_mmio_load(struct kvm_vcpu *vcpu);
>
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
> ---
> arch/mips/kvm/emulate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> index 1d41965..7037823 100644
> --- a/arch/mips/kvm/emulate.c
> +++ b/arch/mips/kvm/emulate.c
> @@ -2127,7 +2127,7 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst,
> run->mmio.phys_addr, run->mmio.len, run->mmio.data);
>
> if (!r) {
> - kvm_mips_complete_mmio_load(vcpu, run);
> + kvm_mips_complete_mmio_load(vcpu);
> vcpu->mmio_needed = 0;
> return EMULATE_DONE;
> }
>
This is queued already, I' will push it shortly. Thanks!
Paolo
prev parent reply other threads:[~2020-07-31 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 7:16 [PATCH -next] emulate:Fix build error Peng Wu
2020-07-31 7:36 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddee30c4-6190-5cbc-6340-c138bd1550b5@redhat.com \
--to=pbonzini@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=chenhc@lemote.com \
--cc=colin.king@canonical.com \
--cc=huanglllzu@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=tsbogend@alpha.franken.de \
--cc=wupeng58@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).