From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ECA7C433DB for ; Tue, 16 Mar 2021 17:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E4C065130 for ; Tue, 16 Mar 2021 17:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234054AbhCPR7F (ORCPT ); Tue, 16 Mar 2021 13:59:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43713 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239451AbhCPR6s (ORCPT ); Tue, 16 Mar 2021 13:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615917526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0JF+/EvZtJVhKD33W6FqDvREuQ9YbTe24q46xCPM6xE=; b=Y7y9hSBOjTrMT7ddLN8et8Kl+DLmwK8ezmX459EudpofP+RgQky+NJ9CfrG3puo8lFD+L9 gNtN4z5zT7gCkhRzhKBUd81jyH6DLskgz4ifG81NHv5MAGnYV18t6FVAgYxvitGeHVVDEQ fI4gjHzs6B5d2o1FhSJvMRomK60gRBk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-zJZLfoOzNdSVyujNUcgVhA-1; Tue, 16 Mar 2021 13:58:45 -0400 X-MC-Unique: zJZLfoOzNdSVyujNUcgVhA-1 Received: by mail-wr1-f70.google.com with SMTP id x9so16908984wro.9 for ; Tue, 16 Mar 2021 10:58:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0JF+/EvZtJVhKD33W6FqDvREuQ9YbTe24q46xCPM6xE=; b=Yy6C3XSbJ4qF2uNt58QJze8xE3W9csOtrcU/kIj0BJINNY8npi8yDdCDjDiBmJWQi4 gFPEsy7zoyZQN/ZCSgkkIINJU1cAE+OFb+ixllp8SqrgPpjwCmWRRwhJAGATjeELOL8b qqafXnYo2V6aiVMJe9YjSftEpC9icmkYDRbwgnjzErpKH6BvBND3Oa2QeLuddZVxw0RI AhZPx+sPSxQkINgKVdVqFfqqt7fFZnOy5IRzAnRdTOnr1a8THcD2lZ78ifueq+3g/T0m 3ewJ3BiuKgr/Ip2Vy2S9u0HnExLv8R7Uu6AzzOL9xpBhVuNEtClwvPfcBxxadYc31VpD 6GGQ== X-Gm-Message-State: AOAM532NCJ6zAV01P8l8Kc4Lcd4hHch15qoQ0SLo53z7N4G9WCad7XW1 NlUxsU7wtpNLNcahFVyVEYJmOvx7VRT3HWsoqLeFJSqFUIb2S+2+i0E4G6782UW3pYLKMsmUOPA 5Jw5aA3ZoDH4H X-Received: by 2002:a05:600c:214d:: with SMTP id v13mr81715wml.162.1615917524172; Tue, 16 Mar 2021 10:58:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwz8qaQiIOeDTIxZu7wmd1Y+fc2q4azsyR8hIQCQE4eF5SdedLniWyjPV6zPBLTn4HqoZPj4w== X-Received: by 2002:a05:600c:214d:: with SMTP id v13mr81708wml.162.1615917524031; Tue, 16 Mar 2021 10:58:44 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j26sm22582822wrh.57.2021.03.16.10.58.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 10:58:43 -0700 (PDT) Subject: Re: [RFC] KVM: x86: Support KVM VMs sharing SEV context To: Sean Christopherson , Nathan Tempelman Cc: Thomas Lendacky , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Steve Rutherford , David Rientjes , Brijesh Singh , Ashish Kalra References: <20210224085915.28751-1-natet@google.com> From: Paolo Bonzini Message-ID: Date: Tue, 16 Mar 2021 18:58:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 16/03/21 18:52, Sean Christopherson wrote: >> I don't >> know that holding the fd instead of the kvm makes that much better though, >> are there advantages to that I'm not seeing? > If there's no kvm pointer, it's much more difficult for someone to do the wrong > thing, and any such shenanigans stick out like a sore thumb in patches, which > makes reviewing future changes easier. On the other hand holding the fd open complicates the code, reference counting rules are already hard enough. I think we only need a replacement for "mirror", what about "dependent"? "is_dependent_enc_context" seems clear enough. Paolo