From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A5F6C43457 for ; Fri, 9 Oct 2020 03:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5B5622251 for ; Fri, 9 Oct 2020 03:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R/JyMCpH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730932AbgJID7y (ORCPT ); Thu, 8 Oct 2020 23:59:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48354 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgJID7y (ORCPT ); Thu, 8 Oct 2020 23:59:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602215993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CeARdKdxXITMJyQg5RZv73lx5offC2uV5GIuBo7fxJ0=; b=R/JyMCpHNsJRJ3dyVsAO7ndV0bUazP5hLPlkjs71ozsilbdbaSkr1nzUHwqONFcdE6YVRq WRwud9876RGGiSxdfJLedGdHTvlaPYRQO+x12ws4D9NkA5vznRMgAvd9ca+qC4OkJY/GgS tYew4ZfS7JcLMXqE6ZttSEQDQ2Zu85k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-ovPi3MAeMFqZ6s7Ym02ajw-1; Thu, 08 Oct 2020 23:59:52 -0400 X-MC-Unique: ovPi3MAeMFqZ6s7Ym02ajw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 579CB425D7; Fri, 9 Oct 2020 03:59:50 +0000 (UTC) Received: from [10.72.13.133] (ovpn-13-133.pek2.redhat.com [10.72.13.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 013996EF58; Fri, 9 Oct 2020 03:59:17 +0000 (UTC) Subject: Re: [RFC PATCH 18/24] vhost-vdpa: support ASID based IOTLB API To: Eugenio Perez Martin Cc: Michael Tsirkin , Cindy Lu , kvm list , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Miller , lingshan.zhu@intel.com, Harpreet Singh Anand , mhabets@solarflare.com, eli@mellanox.com, Adrian Moreno Zapata , Maxime Coquelin , Stefan Hajnoczi , Stefano Garzarella References: <20200924032125.18619-1-jasowang@redhat.com> <20200924032125.18619-19-jasowang@redhat.com> From: Jason Wang Message-ID: Date: Fri, 9 Oct 2020 11:59:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020/9/28 下午11:44, Eugenio Perez Martin wrote: >> - u64 iova, u64 size) >> +static int vhost_vdpa_unmap(struct vhost_vdpa *v, >> + struct vhost_iotlb *iotlb, >> + u64 iova, u64 size) >> { >> struct vdpa_device *vdpa = v->vdpa; >> const struct vdpa_config_ops *ops = vdpa->config; >> + u32 asid = (iotlb); >> + >> + if (!iotlb) >> + return -EINVAL; > This should be reorder to check for (!iotlb) before use at `asid = > iotlb_to_asid()`, isn't it? > > Thanks! > Yes, will fix in the next version. Thanks