From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B573C4727C for ; Tue, 29 Sep 2020 18:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23F3121548 for ; Tue, 29 Sep 2020 18:24:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bXhHcbmy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727841AbgI2SYK (ORCPT ); Tue, 29 Sep 2020 14:24:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22829 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbgI2SYK (ORCPT ); Tue, 29 Sep 2020 14:24:10 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601403848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0D4KBdeUuvRAnC63+pSwTvaNI9ec0eOgL55xTD9Oy4=; b=bXhHcbmy9czn/Mx+HucdiKAMv+fJyd8Xdwi++9L51O0IJiWDaDaIQ4pQ2Et++fXl3AUKXm LinH+yl6qFESQTHKTitgRFBQActRINPKLfR+sDSfbszybVLmzkQWA5lMwS/25u5N7wwpYT GgJcUbj03Ik6uwmoVMkWwLGnri6vYoA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-njRqIPOdMbiPCMT4e1qXjg-1; Tue, 29 Sep 2020 14:24:06 -0400 X-MC-Unique: njRqIPOdMbiPCMT4e1qXjg-1 Received: by mail-wm1-f72.google.com with SMTP id y18so2028631wma.4 for ; Tue, 29 Sep 2020 11:24:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W0D4KBdeUuvRAnC63+pSwTvaNI9ec0eOgL55xTD9Oy4=; b=qjTkVFfOzqPk9UgI2yUoMtn05I1wLwvLgxT5hhZr0d18yef+pXEMP314QU/pvD5qIz 8tVGXPm+arHDa/VDb0QTPQjKJ3ZLH2MkffI1vPFQ/p2eu2hap7HlfS0XBQMMdlJc7GTv 6xoP4R4P7xQVsmfyKMSLa9Sh4Mn3Q6wnxi+MnzQq/Tfb8+PDJexbgtGWWZSQ/mlU3z6f Hv6+wR7YyHvJMM4L+bTVWIaNtW1MMGahwcz+xWVYvgyOyRkJPkSEn+Z3kuDKgKRRxIST OQli0P+WY24Wb0S+mxwxHXf6jITKvJ0GmZTUegrEYwPNEHWeccTKS/UP0Q2/9JQPy4Vz p4Zg== X-Gm-Message-State: AOAM532+F9HQCS2Y7pmu3ea3cNSj2mFktnI0unetxlsmP8GeJrD85AGK zWMXZ8pWwsL16PcwUTkghHRopRpUa30rd89WXiu9cmmN2zbOcigUhLjXYM4Xl9UU64AIP2xMVaJ pohxztddOgZbL X-Received: by 2002:a1c:1d08:: with SMTP id d8mr6182726wmd.78.1601403845777; Tue, 29 Sep 2020 11:24:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl4Gxy9MKNRWrZ/3UbL0g+k1HsAv7oAxrL7Adf5VFPEq47gFKSxjs6VU8HPiyuAYm/s6DHdQ== X-Received: by 2002:a1c:1d08:: with SMTP id d8mr6182714wmd.78.1601403845596; Tue, 29 Sep 2020 11:24:05 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9dbe:2c91:3d1b:58c6? ([2001:b07:6468:f312:9dbe:2c91:3d1b:58c6]) by smtp.gmail.com with ESMTPSA id y1sm6356454wma.36.2020.09.29.11.24.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 11:24:04 -0700 (PDT) Subject: Re: [PATCH 20/22] kvm: mmu: NX largepage recovery for TDP MMU To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Cannon Matthews , Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-21-bgardon@google.com> From: Paolo Bonzini Message-ID: Date: Tue, 29 Sep 2020 20:24:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200925212302.3979661-21-bgardon@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 25/09/20 23:23, Ben Gardon wrote: > + struct list_head tdp_mmu_lpage_disallowed_pages; This list is never INIT_LIST_HEAD-ed, but I see other issues if I do so (or maybe it's just too late). Paolo > + u64 tdp_mmu_lpage_disallowed_page_count;