KVM Archive on lore.kernel.org
 help / color / Atom feed
* [kvm-unit-tests PATCH] gitlab-ci.yml: Compile some jobs out-of-tree
@ 2020-07-31  9:41 Thomas Huth
  2020-07-31 11:24 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2020-07-31  9:41 UTC (permalink / raw)
  To: kvm; +Cc: pbonzini, drjones

So far we only compiled all jobs in-tree in the gitlab-CI. For the code
that gets compiled twice (one time for 64-bit and one time for 32-bit
for example), we can easily move one of the two jobs to out-of-tree build
mode to increase the build test coverage a little bit.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.yml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 1ec9797..6613c7b 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -19,7 +19,9 @@ build-aarch64:
 build-arm:
  script:
  - dnf install -y qemu-system-arm gcc-arm-linux-gnu
- - ./configure --arch=arm --cross-prefix=arm-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=arm --cross-prefix=arm-linux-gnu-
  - make -j2
  - ACCEL=tcg MAX_SMP=8 ./run_tests.sh
      selftest-setup selftest-vectors-kernel selftest-vectors-user selftest-smp
@@ -31,7 +33,9 @@ build-arm:
 build-ppc64be:
  script:
  - dnf install -y qemu-system-ppc gcc-powerpc64-linux-gnu
- - ./configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      selftest-setup spapr_hcall rtas-get-time-of-day rtas-get-time-of-day-base
@@ -77,7 +81,9 @@ build-x86_64:
 build-i386:
  script:
  - dnf install -y qemu-system-x86 gcc
- - ./configure --arch=i386
+ - mkdir build
+ - cd build
+ - ../configure --arch=i386
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      cmpxchg8b vmexit_cpuid vmexit_mov_from_cr8 vmexit_mov_to_cr8
-- 
2.18.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [kvm-unit-tests PATCH] gitlab-ci.yml: Compile some jobs out-of-tree
  2020-07-31  9:41 [kvm-unit-tests PATCH] gitlab-ci.yml: Compile some jobs out-of-tree Thomas Huth
@ 2020-07-31 11:24 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-07-31 11:24 UTC (permalink / raw)
  To: Thomas Huth, kvm; +Cc: drjones

On 31/07/20 11:41, Thomas Huth wrote:
> So far we only compiled all jobs in-tree in the gitlab-CI. For the code
> that gets compiled twice (one time for 64-bit and one time for 32-bit
> for example), we can easily move one of the two jobs to out-of-tree build
> mode to increase the build test coverage a little bit.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitlab-ci.yml | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 1ec9797..6613c7b 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -19,7 +19,9 @@ build-aarch64:
>  build-arm:
>   script:
>   - dnf install -y qemu-system-arm gcc-arm-linux-gnu
> - - ./configure --arch=arm --cross-prefix=arm-linux-gnu-
> + - mkdir build
> + - cd build
> + - ../configure --arch=arm --cross-prefix=arm-linux-gnu-
>   - make -j2
>   - ACCEL=tcg MAX_SMP=8 ./run_tests.sh
>       selftest-setup selftest-vectors-kernel selftest-vectors-user selftest-smp
> @@ -31,7 +33,9 @@ build-arm:
>  build-ppc64be:
>   script:
>   - dnf install -y qemu-system-ppc gcc-powerpc64-linux-gnu
> - - ./configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
> + - mkdir build
> + - cd build
> + - ../configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
>   - make -j2
>   - ACCEL=tcg ./run_tests.sh
>       selftest-setup spapr_hcall rtas-get-time-of-day rtas-get-time-of-day-base
> @@ -77,7 +81,9 @@ build-x86_64:
>  build-i386:
>   script:
>   - dnf install -y qemu-system-x86 gcc
> - - ./configure --arch=i386
> + - mkdir build
> + - cd build
> + - ../configure --arch=i386
>   - make -j2
>   - ACCEL=tcg ./run_tests.sh
>       cmpxchg8b vmexit_cpuid vmexit_mov_from_cr8 vmexit_mov_to_cr8
> 

Applied, thanks.

Paolo


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31  9:41 [kvm-unit-tests PATCH] gitlab-ci.yml: Compile some jobs out-of-tree Thomas Huth
2020-07-31 11:24 ` Paolo Bonzini

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git