From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC5AC48BE6 for ; Thu, 10 Jun 2021 16:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C53B613E1 for ; Thu, 10 Jun 2021 16:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbhFJQZW (ORCPT ); Thu, 10 Jun 2021 12:25:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42290 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbhFJQZU (ORCPT ); Thu, 10 Jun 2021 12:25:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623342204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xaDYl3mAKqwxB1xdG6u3uJxh4rz2ERkYQsFm9BataQM=; b=RcUaiJYaTmpDK2vFq31FTH8lpVUFoRXy8gGjrzhYHUkPDcOXv1l6Fuix/xerJJyovJx2IG 9NNyjZSp/iG8n/nmwrus2FM7E+HUqNIQSWILsCjk+8pO4nR6XwE0ULebAPBJJc/HIutIrn SY3rnmLjpr1flQOijzm2KYGqV2/AtHA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-0iw5k52JM0uyr9Q7S2KYTQ-1; Thu, 10 Jun 2021 12:23:22 -0400 X-MC-Unique: 0iw5k52JM0uyr9Q7S2KYTQ-1 Received: by mail-wm1-f72.google.com with SMTP id g14-20020a05600c4eceb02901b609849650so3641128wmq.6 for ; Thu, 10 Jun 2021 09:23:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xaDYl3mAKqwxB1xdG6u3uJxh4rz2ERkYQsFm9BataQM=; b=TjxTyuaxbSzYftuqoYkIyHBVklpPNA65zSiUSF4U47qZ4GNXIQG7AE+iWPQxNDtphl sSUruijPhlBH0mZSYK6xCVzLzexVZOs504cVyOVM7/b1uiMfmZX64aUajR5ZAjFORmPy NAtX+lK+cLKwb2KUh0ndsEZ1GzJl8R1EPyWYzPvH1yHQ8ZuZJf9vMBHe4ZkhpfPNd7RH eKMHm/vUHFxevChoZcyJ5HqwA5dxtYt7q5m39RxksT55fUIMl/L4U2xBsm7+e5Sp2T0l 1O1yGW4p+fmVUrLt1Up6AXZXcVvHd1BMEcpbcykqH2TSjP0EnPg+pv6PhNdi2XUcO8/p 9z1w== X-Gm-Message-State: AOAM533xb6MaJft3qAK0RPnpSRu89eYhK1WosPGngI1HL7rPf2Z4HS9F JT7Y+IibTs7q5ECurfjpJAmWyg7BL1pSB6eLc0Hiv7K3AYOcAuDDp9WMq9ECr1GJyqPcoxzam8Q qGnLayNuCdQXP X-Received: by 2002:adf:de91:: with SMTP id w17mr6484903wrl.352.1623342201699; Thu, 10 Jun 2021 09:23:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzimm0IhzRGX0own3XmAQS7AEY/ooW0Iee1AKpx0NvxC3qE+jaJNCMXAZvHTl29Jx/k7NJRTg== X-Received: by 2002:adf:de91:: with SMTP id w17mr6484880wrl.352.1623342201486; Thu, 10 Jun 2021 09:23:21 -0700 (PDT) Received: from ?IPv6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.gmail.com with ESMTPSA id o9sm3760703wri.68.2021.06.10.09.23.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 09:23:20 -0700 (PDT) Subject: Re: [PATCH v7 2/4] KVM: stats: Add fd-based API to read binary stats data To: Jing Zhang , KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan References: <20210603211426.790093-1-jingzhangos@google.com> <20210603211426.790093-3-jingzhangos@google.com> From: Paolo Bonzini Message-ID: Date: Thu, 10 Jun 2021 18:23:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210603211426.790093-3-jingzhangos@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 03/06/21 23:14, Jing Zhang wrote: > +#define DEFINE_VM_STATS_DESC(...) { \ > + STATS_DESC_COUNTER("remote_tlb_flush"), \ > + ## __VA_ARGS__ \ > +} > + > +#define DEFINE_VCPU_STATS_DESC(...) { \ > + STATS_DESC_COUNTER("halt_successful_poll"), \ > + STATS_DESC_COUNTER("halt_attempted_poll"), \ > + STATS_DESC_COUNTER("halt_poll_invalid"), \ > + STATS_DESC_COUNTER("halt_wakeup"), \ > + STATS_DESC_TIME_NSEC("halt_poll_success_ns"), \ > + STATS_DESC_TIME_NSEC("halt_poll_fail_ns"), \ > + ## __VA_ARGS__ \ Let's instead put this (note it's without braces) in macros like these #define KVM_GENERIC_VM_STATS() \ STATS_DESC_COUNTER("remote_tlb_flush"), #define KVM_GENERIC_VCPU_STATS(...) \ STATS_DESC_COUNTER("halt_successful_poll"), \ STATS_DESC_COUNTER("halt_attempted_poll"), \ STATS_DESC_COUNTER("halt_poll_invalid"), \ STATS_DESC_COUNTER("halt_wakeup"), \ STATS_DESC_TIME_NSEC("halt_poll_success_ns"), \ STATS_DESC_TIME_NSEC("halt_poll_fail_ns"), and it can be used in the arch files. In fact it can even be added in patch 1 and switched to STATS_DESC_* here. Paolo