From: Pierre Morel <pmorel@linux.ibm.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>, qemu-s390x@nongnu.org
Cc: alex.williamson@redhat.com, schnelle@linux.ibm.com,
cohuck@redhat.com, thuth@redhat.com, farman@linux.ibm.com,
richard.henderson@linaro.org, david@redhat.com,
pasic@linux.ibm.com, borntraeger@linux.ibm.com, mst@redhat.com,
pbonzini@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v7 3/8] s390x/pci: enable for load/store intepretation
Date: Wed, 22 Jun 2022 10:35:50 +0200 [thread overview]
Message-ID: <ea3daac0-875d-dd9d-7ad0-65a0aed2aaed@linux.ibm.com> (raw)
In-Reply-To: <20220606203614.110928-4-mjrosato@linux.ibm.com>
On 6/6/22 22:36, Matthew Rosato wrote:
> If the ZPCI_OP ioctl reports that is is available and usable, then the
> underlying KVM host will enable load/store intepretation for any guest
> device without a SHM bit in the guest function handle. For a device that
> will be using interpretation support, ensure the guest function handle
> matches the host function handle; this value is re-checked every time the
> guest issues a SET PCI FN to enable the guest device as it is the only
> opportunity to reflect function handle changes.
>
> By default, unless interpret=off is specified, interpretation support will
> always be assumed and exploited if the necessary ioctl and features are
> available on the host kernel. When these are unavailable, we will silently
> revert to the interception model; this allows existing guest configurations
> to work unmodified on hosts with and without zPCI interpretation support,
> allowing QEMU to choose the best support model available.
>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
> hw/s390x/meson.build | 1 +
> hw/s390x/s390-pci-bus.c | 66 ++++++++++++++++++++++++++++++++-
> hw/s390x/s390-pci-inst.c | 16 ++++++++
> hw/s390x/s390-pci-kvm.c | 22 +++++++++++
> include/hw/s390x/s390-pci-bus.h | 1 +
> include/hw/s390x/s390-pci-kvm.h | 24 ++++++++++++
> target/s390x/kvm/kvm.c | 7 ++++
> target/s390x/kvm/kvm_s390x.h | 1 +
> 8 files changed, 137 insertions(+), 1 deletion(-)
> create mode 100644 hw/s390x/s390-pci-kvm.c
> create mode 100644 include/hw/s390x/s390-pci-kvm.h
>
> diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build
> index feefe0717e..f291016fee 100644
> --- a/hw/s390x/meson.build
> +++ b/hw/s390x/meson.build
> @@ -23,6 +23,7 @@ s390x_ss.add(when: 'CONFIG_KVM', if_true: files(
> 's390-skeys-kvm.c',
> 's390-stattrib-kvm.c',
> 'pv.c',
> + 's390-pci-kvm.c',
> ))
Here...
> diff --git a/hw/s390x/s390-pci-kvm.c b/hw/s390x/s390-pci-kvm.c
> new file mode 100644
> index 0000000000..0f16104a74
> --- /dev/null
> +++ b/hw/s390x/s390-pci-kvm.c
...and here:
Shouldn't this file go in target/s390x/kvm ?
> @@ -0,0 +1,22 @@
> +/*
> + * s390 zPCI KVM interfaces
> + *
> + * Copyright 2022 IBM Corp.
> + * Author(s): Matthew Rosato <mjrosato@linux.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or (at
> + * your option) any later version. See the COPYING file in the top-level
> + * directory.
> + */
> +
> +#include "qemu/osdep.h"
> +
> +#include "kvm/kvm_s390x.h"
> +#include "hw/s390x/pv.h"
> +#include "hw/s390x/s390-pci-kvm.h"
> +#include "cpu_models.h"
> +
> +bool s390_pci_kvm_interp_allowed(void)
> +{
> + return kvm_s390_get_zpci_op() && !s390_is_pv();
> +}
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2022-06-22 8:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 20:36 [PATCH v7 0/8] s390x/pci: zPCI interpretation support Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 1/8] Update linux headers Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 2/8] s390x/pci: add routine to get host function handle from CLP info Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 3/8] s390x/pci: enable for load/store intepretation Matthew Rosato
2022-06-22 8:35 ` Pierre Morel [this message]
2022-06-22 15:20 ` Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 4/8] s390x/pci: don't fence interpreted devices without MSI-X Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 5/8] s390x/pci: enable adapter event notification for interpreted devices Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 6/8] s390x/pci: let intercept devices have separate PCI groups Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 7/8] s390x/pci: reflect proper maxstbl for groups of interpreted devices Matthew Rosato
2022-06-06 20:36 ` [PATCH v7 8/8] s390x/s390-virtio-ccw: add zpcii-disable machine property Matthew Rosato
2022-06-22 8:50 ` Pierre Morel
2022-06-22 15:20 ` Matthew Rosato
2022-06-23 13:50 ` Pierre Morel
2022-06-23 14:26 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3daac0-875d-dd9d-7ad0-65a0aed2aaed@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=schnelle@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).