From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] KVM: X86: Rename DR6_INIT to DR6_ACTIVE_LOW
Date: Tue, 2 Feb 2021 17:05:04 +0100 [thread overview]
Message-ID: <ea9eaa84-999b-82cb-ef40-66fde361704d@redhat.com> (raw)
In-Reply-To: <6678520f-e69e-6116-88c9-e9d6cd450934@intel.com>
On 02/02/21 16:02, Xiaoyao Li wrote:
> On 2/2/2021 10:49 PM, Paolo Bonzini wrote:
>> On 02/02/21 10:04, Chenyi Qiang wrote:
>>>
>>> #define DR6_FIXED_1 0xfffe0ff0
>>> -#define DR6_INIT 0xffff0ff0
>>> +/*
>>> + * DR6_ACTIVE_LOW is actual the result of DR6_FIXED_1 |
>>> ACTIVE_LOW_BITS.
>>> + * We can regard all the current FIXED_1 bits as active_low bits even
>>> + * though in no case they will be turned into 0. But if they are
>>> defined
>>> + * in the future, it will require no code change.
>>> + * At the same time, it can be served as the init/reset value for DR6.
>>> + */
>>> +#define DR6_ACTIVE_LOW 0xffff0ff0
>>> #define DR6_VOLATILE 0x0001e00f
>>>
>>
>> Committed with some changes in the wording of the comment.
>>
>> Also, DR6_FIXED_1 is (DR6_ACTIVE_LOW & ~DR6_VOLATILE).
>
> Maybe we can add BUILD_BUG_ON() to make sure the correctness?
We can even
#define DR_FIXED_1 (DR6_ACTIVE_LOW & ~DR6_VOLATILE)
directly. I have pushed this patch to kvm/queue, but the other two will
have to wait for Fenghua's bare metal support.
Paolo
next prev parent reply other threads:[~2021-02-02 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:04 [PATCH v2 0/3] Add KVM support for bus lock debug exception Chenyi Qiang
2021-02-02 9:04 ` [PATCH v2 1/3] KVM: X86: Rename DR6_INIT to DR6_ACTIVE_LOW Chenyi Qiang
2021-02-02 14:49 ` Paolo Bonzini
2021-02-02 15:02 ` Xiaoyao Li
2021-02-02 16:05 ` Paolo Bonzini [this message]
2021-04-02 8:53 ` Xiaoyao Li
2021-04-02 9:01 ` Paolo Bonzini
2021-05-06 8:21 ` Chenyi Qiang
2021-05-06 10:19 ` Paolo Bonzini
2021-02-02 9:04 ` [PATCH v2 2/3] KVM: X86: Add support for the emulation of DR6_BUS_LOCK bit Chenyi Qiang
2021-02-02 9:04 ` [PATCH v2 3/3] KVM: X86: Expose bus lock debug exception to guest Chenyi Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea9eaa84-999b-82cb-ef40-66fde361704d@redhat.com \
--to=pbonzini@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).