From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Connor Kuehl <ckuehl@redhat.com>,
isaku.yamahata@gmail.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, alistair@alistair23.me, ehabkost@redhat.com,
marcel.apfelbaum@gmail.com, mst@redhat.com, cohuck@redhat.com,
mtosatti@redhat.com, seanjc@google.com, erdemaktas@google.com
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org
Subject: Re: [RFC PATCH v2 32/44] tdx: add kvm_tdx_enabled() accessor for later use
Date: Thu, 9 Dec 2021 22:31:36 +0800 [thread overview]
Message-ID: <eac9c0b1-30c7-04e9-2c89-9047bebf2683@intel.com> (raw)
In-Reply-To: <43a81d27-56da-07e8-b3d7-9800b6ed8da1@redhat.com>
On 7/23/2021 1:53 AM, Connor Kuehl wrote:
> On 7/7/21 7:55 PM, isaku.yamahata@gmail.com wrote:
>> From: Isaku Yamahata <isaku.yamahata@intel.com>
>>
>> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>> ---
>> include/sysemu/tdx.h | 1 +
>> target/i386/kvm/kvm.c | 5 +++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/include/sysemu/tdx.h b/include/sysemu/tdx.h
>> index 70eb01348f..f3eced10f9 100644
>> --- a/include/sysemu/tdx.h
>> +++ b/include/sysemu/tdx.h
>> @@ -6,6 +6,7 @@
>> #include "hw/i386/pc.h"
>> bool kvm_has_tdx(KVMState *s);
>> +bool kvm_tdx_enabled(void);
>> int tdx_system_firmware_init(PCMachineState *pcms, MemoryRegion
>> *rom_memory);
>> #endif
>> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
>> index af6b5f350e..76c3ea9fac 100644
>> --- a/target/i386/kvm/kvm.c
>> +++ b/target/i386/kvm/kvm.c
>> @@ -152,6 +152,11 @@ int kvm_set_vm_type(MachineState *ms, int kvm_type)
>> return -ENOTSUP;
>> }
>> +bool kvm_tdx_enabled(void)
>> +{
>> + return vm_type == KVM_X86_TDX_VM;
>> +}
>> +
>
> Is this the whole story? Does this guarantee that the VM QEMU is
> responsible to bring up is a successfully initialized TD?
No, it just means a TDX guest is requested.
> From my reading of the series as it unfolded, this looks like the
> function proves that KVM can support TDs and that the user requested
> a TDX kvm-type, not that we have a fully-formed TD.
yes, you are right. We referenced what sev_eanbled() and sev_es_enabled().
If the name is misleading, does it looks better to name it is_tdx_vm()?
> Is it possible to associate this with a more verifiable metric that
> the TD has been or will be created successfully? I.e., once the VM
> has successfully called the TDX INIT ioctl or has finalized setup?
>
> My question mainly comes from a later patch in the series, where the
> "query-tdx-capabilities" and "query-tdx" QMP commands are added.
>
> Forgive me if I am misinterpreting the semantics of each of these
> commands:
what you understood is correct.
> "query-tdx-capabilities" sounds like it answers the question of
> "can it run a TD?"
>
> and "query-tdx" sounds like it answers the question of "is it a TD?"
>
> Is the assumption with "query-tdx" that anything that's gone wrong
> with developing a TD will have resulted in the QEMU process exiting
> and therefore if we get to a point where we can run "query-tdx" then
> we know the TD was successfully formed?
>
next prev parent reply other threads:[~2021-12-09 14:32 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 0:54 [RFC PATCH v2 00/44] TDX support isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 01/44] target/i386: Expose x86_cpu_get_supported_feature_word() for TDX isaku.yamahata
2021-07-22 17:52 ` Connor Kuehl
2021-07-08 0:54 ` [RFC PATCH v2 02/44] kvm: Switch KVM_CAP_READONLY_MEM to a per-VM ioctl() isaku.yamahata
2021-07-22 17:52 ` Connor Kuehl
2021-07-08 0:54 ` [RFC PATCH v2 03/44] i386/kvm: Move architectural CPUID leaf generation to separarte helper isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 04/44] vl: Introduce machine_init_done_late notifier isaku.yamahata
2021-07-22 17:52 ` Connor Kuehl
2021-08-26 10:13 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 05/44] linux-headers: Update headers to pull in TDX API changes isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest isaku.yamahata
2021-07-22 17:53 ` Connor Kuehl
2021-08-26 10:22 ` Gerd Hoffmann
2021-11-24 7:31 ` Xiaoyao Li
2022-01-10 11:18 ` Daniel P. Berrangé
2022-01-10 12:01 ` Xiaoyao Li
2022-01-10 12:05 ` Daniel P. Berrangé
2021-07-08 0:54 ` [RFC PATCH v2 07/44] i386/kvm: Squash getting/putting guest state for TDX VMs isaku.yamahata
2021-08-26 10:24 ` Gerd Hoffmann
2021-12-09 3:33 ` Xiaoyao Li
2021-07-08 0:54 ` [RFC PATCH v2 08/44] i386/kvm: Skip KVM_X86_SETUP_MCE for TDX guests isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 09/44] target/i386: kvm: don't synchronize guest tsc for TD guest isaku.yamahata
2021-07-22 17:53 ` Connor Kuehl
2021-07-08 0:54 ` [RFC PATCH v2 10/44] hw/i386: Initialize TDX via KVM ioctl() when kvm_type is TDX isaku.yamahata
2021-08-26 10:27 ` Gerd Hoffmann
2021-08-26 15:06 ` Eric Blake
2021-07-08 0:54 ` [RFC PATCH v2 11/44] i386/tdx: Implement user specified tsc frequency isaku.yamahata
2021-07-22 17:53 ` Connor Kuehl
2021-12-02 8:56 ` Xiaoyao Li
2021-07-08 0:54 ` [RFC PATCH v2 12/44] target/i386/tdx: Finalize the TD's measurement when machine is done isaku.yamahata
2021-07-22 17:53 ` Connor Kuehl
2021-07-08 0:54 ` [RFC PATCH v2 13/44] i386/tdx: Frame in tdx_get_supported_cpuid with KVM_TDX_CAPABILITIES isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 14/44] i386/tdx: Frame in the call for KVM_TDX_INIT_VCPU isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 15/44] i386/tdx: Add hook to require generic device loader isaku.yamahata
2021-08-26 10:41 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 16/44] hw/i386: Add definitions from UEFI spec for volumes, resources, etc isaku.yamahata
2021-08-26 10:46 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 17/44] i386/tdx: Add definitions for TDVF metadata isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 18/44] hw/i386: refactor e820_add_entry() isaku.yamahata
2021-08-26 10:49 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 19/44] hw/i386/e820: introduce a helper function to change type of e820 isaku.yamahata
2021-08-26 11:22 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 20/44] i386/tdx: Parse tdx metadata and store the result into TdxGuestState isaku.yamahata
2021-08-26 11:18 ` Gerd Hoffmann
2022-01-04 13:08 ` Xiaoyao Li
2022-01-06 16:06 ` Laszlo Ersek
2022-01-07 7:05 ` Xiaoyao Li
2022-01-10 11:01 ` Gerd Hoffmann
2022-01-10 12:09 ` Xiaoyao Li
2022-01-11 8:19 ` Laszlo Ersek
2022-01-24 6:22 ` Xiaoyao Li
2022-01-25 7:42 ` Gerd Hoffmann
2022-01-25 8:22 ` Xiaoyao Li
2021-07-08 0:54 ` [RFC PATCH v2 21/44] i386/tdx: Create the TD HOB list upon machine init done isaku.yamahata
2021-08-26 11:29 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 22/44] i386/tdx: Add TDVF memory via INIT_MEM_REGION isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 23/44] i386/tdx: Use KVM_TDX_INIT_VCPU to pass HOB to TDVF isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 24/44] i386/tdx: Add MMIO HOB entries isaku.yamahata
2021-08-26 12:17 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 25/44] q35: Move PCIe BAR check above PAM check in mch_write_config() isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 26/44] pci-host/q35: Move PAM initialization above SMRAM initialization isaku.yamahata
2021-07-08 0:54 ` [RFC PATCH v2 27/44] q35: Introduce smm_ranges property for q35-pci-host isaku.yamahata
2021-08-26 11:38 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 28/44] i386/tdx: Force x2apic mode and routing for TDs isaku.yamahata
2021-08-26 11:42 ` Gerd Hoffmann
2021-07-08 0:54 ` [RFC PATCH v2 29/44] target/i386: Add machine option to disable PIC/8259 isaku.yamahata
2021-08-26 11:50 ` Gerd Hoffmann
2021-07-08 0:55 ` [RFC PATCH v2 30/44] qom: implement property helper for sha384 isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 31/44] target/i386/tdx: Allows mrconfigid/mrowner/mrownerconfig for TDX_INIT_VM isaku.yamahata
2021-08-26 15:13 ` Eric Blake
2021-07-08 0:55 ` [RFC PATCH v2 32/44] tdx: add kvm_tdx_enabled() accessor for later use isaku.yamahata
2021-07-22 17:53 ` Connor Kuehl
2021-12-09 14:31 ` Xiaoyao Li [this message]
2021-07-08 0:55 ` [RFC PATCH v2 33/44] qmp: add query-tdx-capabilities query-tdx command isaku.yamahata
2021-08-26 11:59 ` Gerd Hoffmann
2021-08-26 15:21 ` Eric Blake
2021-07-08 0:55 ` [RFC PATCH v2 34/44] target/i386/tdx: set reboot action to shutdown when tdx isaku.yamahata
2021-07-22 17:54 ` Connor Kuehl
2021-12-10 9:54 ` Xiaoyao Li
2021-08-26 12:01 ` Gerd Hoffmann
2021-07-08 0:55 ` [RFC PATCH v2 35/44] ioapic: add property to disable level interrupt isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 36/44] hw/i386: add eoi_intercept_unsupported member to X86MachineState isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 37/44] hw/i386: add option to forcibly report edge trigger in acpi tables isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 38/44] hw/i386: plug eoi_intercept_unsupported to ioapic isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 39/44] ioapic: add property to disallow SMI delivery mode isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 40/44] hw/i386: add a flag to disallow SMI isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 41/44] ioapic: add property to disallow INIT/SIPI delivery mode isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 42/44] hw/i386: add a flag to disable init/sipi delivery mode of interrupt isaku.yamahata
2021-08-26 12:15 ` Gerd Hoffmann
2021-07-08 0:55 ` [RFC PATCH v2 43/44] i386/tdx: disallow level interrupt and SMI/INIT/SIPI delivery mode isaku.yamahata
2021-07-08 0:55 ` [RFC PATCH v2 44/44] i386/tdx: disable S3/S4 unconditionally isaku.yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac9c0b1-30c7-04e9-2c89-9047bebf2683@intel.com \
--to=xiaoyao.li@intel.com \
--cc=alistair@alistair23.me \
--cc=ckuehl@redhat.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=erdemaktas@google.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).