From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60951C43603 for ; Tue, 10 Dec 2019 11:23:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3814C20663 for ; Tue, 10 Dec 2019 11:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbfLJLXC (ORCPT ); Tue, 10 Dec 2019 06:23:02 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51754 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbfLJLXC (ORCPT ); Tue, 10 Dec 2019 06:23:02 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBABMsj1006676 for ; Tue, 10 Dec 2019 06:23:01 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wsm2e198j-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Dec 2019 06:23:00 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Dec 2019 11:22:23 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 10 Dec 2019 11:22:21 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xBABMKnd53084224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 11:22:20 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7094CA4051; Tue, 10 Dec 2019 11:22:20 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3930CA404D; Tue, 10 Dec 2019 11:22:20 +0000 (GMT) Received: from oc3016276355.ibm.com (unknown [9.152.222.89]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 10 Dec 2019 11:22:20 +0000 (GMT) Subject: Re: [kvm-unit-tests PATCH v3 5/9] s390x: Library resources for CSS tests To: Thomas Huth , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com References: <1575649588-6127-1-git-send-email-pmorel@linux.ibm.com> <1575649588-6127-6-git-send-email-pmorel@linux.ibm.com> <66233a15-7cc4-45b5-d930-abbedbd0729d@redhat.com> <23770c1c-8aba-85ef-09a1-346393bb90d6@redhat.com> From: Pierre Morel Date: Tue, 10 Dec 2019 12:22:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <23770c1c-8aba-85ef-09a1-346393bb90d6@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19121011-0020-0000-0000-000003962A3A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19121011-0021-0000-0000-000021ED6A8F Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-10_02:2019-12-10,2019-12-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 mlxscore=0 impostorscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912100101 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2019-12-10 11:28, Thomas Huth wrote: > On 10/12/2019 11.07, Pierre Morel wrote: >> >> >> On 2019-12-09 12:49, Thomas Huth wrote: >>> On 06/12/2019 17.26, Pierre Morel wrote: >>>> These are the include and library utilities for the css tests patch >>>> series. >>>> >>>> Signed-off-by: Pierre Morel >>>> --- >>>>   lib/s390x/css.h      | 259 +++++++++++++++++++++++++++++++++++++++++++ >>>>   lib/s390x/css_dump.c | 156 ++++++++++++++++++++++++++ >>>>   2 files changed, 415 insertions(+) >>>>   create mode 100644 lib/s390x/css.h >>>>   create mode 100644 lib/s390x/css_dump.c >>>> >>>> diff --git a/lib/s390x/css.h b/lib/s390x/css.h >>>> new file mode 100644 >>>> index 0000000..6f19bb5 >>>> --- /dev/null >>>> +++ b/lib/s390x/css.h >>> [...] >>>> +/* Debug functions */ >>>> +char *dump_pmcw_flags(uint16_t f); >>>> +char *dump_scsw_flags(uint32_t f); >>>> +#undef DEBUG >>>> +#ifdef DEBUG >>>> +void dump_scsw(struct scsw *); >>>> +void dump_irb(struct irb *irbp); >>>> +void dump_schib(struct schib *sch); >>>> +struct ccw *dump_ccw(struct ccw *cp); >>>> +#else >>>> +static inline void dump_scsw(struct scsw *scsw) {} >>>> +static inline void dump_irb(struct irb *irbp) {} >>>> +static inline void dump_pmcw(struct pmcw *p) {} >>>> +static inline void dump_schib(struct schib *sch) {} >>>> +static inline void dump_orb(struct orb *op) {} >>>> +static inline struct ccw *dump_ccw(struct ccw *cp) >>>> +{ >>>> +    return NULL; >>>> +} >>>> +#endif >>> >>> I'd prefer to not have a "#undef DEBUG" (or "#define DEBUG") statement >> >> Anyway hawfull! >> >>> in the header here - it could trigger unexpected behavior with other >>> files that also use a DEBUG macro. >>> >>> Could you please declare the prototypes here and move the "#else" part >>> to the .c file instead? Thanks! >> >> What if I use a CSS_DEBUG here instead of a simple DEBUG definition? >> >> It can be enabled or not by defining CSS_ENABLED ahead of the include...? > > Why does it have to be in the header and not in the .c file? I too mean in the C file. :) above the include. > > Thomas > -- Pierre Morel IBM Lab Boeblingen