From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6357C3404C for ; Wed, 19 Feb 2020 01:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EEDE24654 for ; Wed, 19 Feb 2020 01:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbgBSBkh convert rfc822-to-8bit (ORCPT ); Tue, 18 Feb 2020 20:40:37 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2965 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727936AbgBSBkh (ORCPT ); Tue, 18 Feb 2020 20:40:37 -0500 Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 380D1C5D9E679ABB5E3D; Wed, 19 Feb 2020 09:40:34 +0800 (CST) Received: from dggeme704-chm.china.huawei.com (10.1.199.100) by DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Feb 2020 09:40:33 +0800 Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme704-chm.china.huawei.com (10.1.199.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 19 Feb 2020 09:40:33 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1713.004; Wed, 19 Feb 2020 09:40:33 +0800 From: linmiaohe To: Joe Perches CC: "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "sean.j.christopherson@intel.com" , "vkuznets@redhat.com" , "wanpengli@tencent.com" , "jmattson@google.com" , "joro@8bytes.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH] KVM: VMX: replace "fall through" with "return true" to indicate different case Thread-Topic: [PATCH] KVM: VMX: replace "fall through" with "return true" to indicate different case Thread-Index: AdXmJiHJM/GSstynQgiSQknhAf056w== Date: Wed, 19 Feb 2020 01:40:33 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Joe Perches wrote: >On Tue, 2020-02-18 at 11:39 +0800, linmiaohe wrote: >> The second "/* fall through */" in rmode_exception() makes code harder >> to read. Replace it with "return true" to indicate they are different >> cases and also this improves the readability. > >perhaps > return !(vcpu->guest_debug & (KVM_GUESTDBG_SINGLESTEP | KVM_GUESTDBG_USE_HW_BP)); > Will do. Thanks for your advice.