From: Thomas Huth <thuth@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, david@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH 3/4] s390x: smp: Test all CRs on initial reset
Date: Wed, 15 Jan 2020 07:17:59 +0100 [thread overview]
Message-ID: <f120ad03-aab1-a863-636b-b11898d634f5@redhat.com> (raw)
In-Reply-To: <2f190b0a-e403-51e6-27da-7f8f1f6289ac@de.ibm.com>
On 14/01/2020 19.42, Christian Borntraeger wrote:
>
>
> On 14.01.20 16:30, Janosch Frank wrote:
>> All CRs are set to 0 and CRs 0 and 14 are set to pre-defined values,
>> so we also need to test 1-13 and 15 for 0.
>>
>> And while we're at it, let's also set some values to cr 1, 7 and 13, so
>> we can actually be sure that they will be zeroed.
>
> While it does not hurt to have it here, I think the register check for the reset
> would be better in a kselftest. This allows to check userspace AND guest at the
> same time.
Agreed. Especially it also allows to test the kernel ioctl on its own,
without QEMU in between (which might also clear some registers), so for
getting the new reset ioctls right, the selftests are certainly the
better place.
Thomas
next prev parent reply other threads:[~2020-01-15 6:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 15:30 [kvm-unit-tests PATCH 0/4] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-14 15:30 ` [kvm-unit-tests PATCH 1/4] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-14 15:39 ` Thomas Huth
2020-01-14 17:32 ` Cornelia Huck
2020-01-14 15:30 ` [kvm-unit-tests PATCH 2/4] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-14 16:45 ` Thomas Huth
2020-01-15 7:50 ` Janosch Frank
2020-01-14 17:44 ` Cornelia Huck
2020-01-15 9:00 ` Janosch Frank
2020-01-14 15:30 ` [kvm-unit-tests PATCH 3/4] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-14 17:01 ` Thomas Huth
2020-01-14 17:51 ` Cornelia Huck
2020-01-14 18:42 ` Christian Borntraeger
2020-01-15 6:17 ` Thomas Huth [this message]
2020-01-15 7:57 ` Janosch Frank
2020-01-15 8:11 ` Thomas Huth
2020-01-14 15:30 ` [kvm-unit-tests PATCH 4/4] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-01-14 17:22 ` Thomas Huth
2020-01-14 17:53 ` Cornelia Huck
2020-01-15 10:47 ` [kvm-unit-tests PATCH 0/4] s390x: smp: Improve smp code and reset checks David Hildenbrand
2020-01-15 13:03 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f120ad03-aab1-a863-636b-b11898d634f5@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).