From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBE1C433DB for ; Tue, 26 Jan 2021 14:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E50622D04 for ; Tue, 26 Jan 2021 14:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390574AbhAZOQD (ORCPT ); Tue, 26 Jan 2021 09:16:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31507 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405597AbhAZOP0 (ORCPT ); Tue, 26 Jan 2021 09:15:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611670438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNCgxUQir3txorT8ut5xBapMDlIH7jLnPf32y1Xl4zA=; b=TY5GFxhb0q1ITeESgyAg/g25nWRXyvIjKDAe8FUlqarI9s5oM1U7OkhXZrcXR4QPW6hva9 OLqtoIvpb151blTfoZLv1oka2/3pYZK1/WFW4lMd9LKlJzLjkfSgO7QdvF/LOl116zfO3j Xclpht6YNt2oOlcA9nbQTcKfT/R47lQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-ReGfZhE5PeqgmpHkn3tUHA-1; Tue, 26 Jan 2021 09:13:56 -0500 X-MC-Unique: ReGfZhE5PeqgmpHkn3tUHA-1 Received: by mail-ej1-f72.google.com with SMTP id n18so4979780ejc.11 for ; Tue, 26 Jan 2021 06:13:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WNCgxUQir3txorT8ut5xBapMDlIH7jLnPf32y1Xl4zA=; b=mNmfIyKtbCKWNBM+G/TNd3B6gJqF/7lVaN26ZvNk7idB4DzkWcAYhU8HgGm+OTSMm7 0Dw45C1rkc8QXl4GVepwNJ2bqa5MC3sN0i7uxpDFdy3FG6JDytmPKMwgok7q9M0ubH5a 1DjFRtQEVTRHpzsv4AzO6e4ji65KYSBNwCy4cOn1YJFwDtwtVkzCGJByWqn9tru3voFR xB8DoInAg1r7RO+AujD11ELqaS7E+BgTlvJjLSbQRDgErAfUKpm3J2faaegRjQZ0GTnH pDzI5RPzuxRgk/bG6dpyF4Y6wcd4TQlsgl+/yp4OrzVlVKL/swX0XcRsYkzOEM3jP5Re pqHw== X-Gm-Message-State: AOAM531UBv7l+6e5otuwvrsquW3iDynQeIqMlr3OIYiLAZZDUy90MMP8 k0uVTMeRO/StEYQ5k6TdXOW6tZPPPNXLIWWNfndoB4xMK11yg/VTpZ9D+5bNg9IjL7Mz2DJ/ZcI aaAzD3dPkqQaK X-Received: by 2002:aa7:d64b:: with SMTP id v11mr4529210edr.16.1611670435543; Tue, 26 Jan 2021 06:13:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJwY7vgpp3lQAQOt4e9Fjtxz70y0tbEdnRYyoa3bXlLDhpXfSeLI4NX1npATa2HkjvR//OcKvA== X-Received: by 2002:aa7:d64b:: with SMTP id v11mr4529195edr.16.1611670435366; Tue, 26 Jan 2021 06:13:55 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id lz27sm9689388ejb.50.2021.01.26.06.13.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jan 2021 06:13:54 -0800 (PST) Subject: Re: [PATCH 08/24] kvm: x86/mmu: Add lockdep when setting a TDP MMU SPTE To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20210112181041.356734-1-bgardon@google.com> <20210112181041.356734-9-bgardon@google.com> From: Paolo Bonzini Message-ID: Date: Tue, 26 Jan 2021 15:13:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210112181041.356734-9-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/01/21 19:10, Ben Gardon wrote: > Add lockdep to __tdp_mmu_set_spte to ensure that SPTEs are only modified > under the MMU lock. This lockdep will be updated in future commits to > reflect and validate changes to the TDP MMU's synchronization strategy. > > No functional change intended. > > Reviewed-by: Peter Feiner > > Signed-off-by: Ben Gardon > --- > arch/x86/kvm/mmu/tdp_mmu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > index b033da8243fc..411938e97a00 100644 > --- a/arch/x86/kvm/mmu/tdp_mmu.c > +++ b/arch/x86/kvm/mmu/tdp_mmu.c > @@ -381,6 +381,8 @@ static inline void __tdp_mmu_set_spte(struct kvm *kvm, struct tdp_iter *iter, > struct kvm_mmu_page *root = sptep_to_sp(root_pt); > int as_id = kvm_mmu_page_as_id(root); > > + lockdep_assert_held(&kvm->mmu_lock); > + > WRITE_ONCE(*iter->sptep, new_spte); > > __handle_changed_spte(kvm, as_id, iter->gfn, iter->old_spte, new_spte, > Queued, thanks. Paolo