From: Maxim Levitsky <mlevitsk@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: Remove unnecessary export of kvm_{inc,dec}_notifier_count()
Date: Sun, 05 Sep 2021 10:12:57 +0300 [thread overview]
Message-ID: <f539e833bd7da4800612f8ae4bdffcb1db2f8684.camel@redhat.com> (raw)
In-Reply-To: <20210902175951.1387989-1-seanjc@google.com>
On Thu, 2021-09-02 at 10:59 -0700, Sean Christopherson wrote:
> Don't export KVM's MMU notifier count helpers, under no circumstance
> should any downstream module, including x86's vendor code, have a
> legitimate reason to piggyback KVM's MMU notifier logic. E.g in the x86
> case, only KVM's MMU should be elevating the notifier count, and that
> code is always built into the core kvm.ko module.
>
> Fixes: edb298c663fc ("KVM: x86/mmu: bump mmu notifier count in kvm_zap_gfn_range")
> Cc: Maxim Levitsky <mlevitsk@redhat.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
> virt/kvm/kvm_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 3e67c93ca403..140c7d311021 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -638,7 +638,6 @@ void kvm_inc_notifier_count(struct kvm *kvm, unsigned long start,
> max(kvm->mmu_notifier_range_end, end);
> }
> }
> -EXPORT_SYMBOL_GPL(kvm_inc_notifier_count);
>
> static int kvm_mmu_notifier_invalidate_range_start(struct mmu_notifier *mn,
> const struct mmu_notifier_range *range)
> @@ -690,8 +689,6 @@ void kvm_dec_notifier_count(struct kvm *kvm, unsigned long start,
> */
> kvm->mmu_notifier_count--;
> }
> -EXPORT_SYMBOL_GPL(kvm_dec_notifier_count);
> -
>
> static void kvm_mmu_notifier_invalidate_range_end(struct mmu_notifier *mn,
> const struct mmu_notifier_range *range)
Ah, I somehow thought when I wrote this that those two will be used by kvm_amd.
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2021-09-05 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:59 [PATCH] KVM: Remove unnecessary export of kvm_{inc,dec}_notifier_count() Sean Christopherson
2021-09-05 7:12 ` Maxim Levitsky [this message]
2021-09-06 10:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f539e833bd7da4800612f8ae4bdffcb1db2f8684.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).