From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Xiaoyao Li <xiaoyao.li@intel.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 0/2] KVM: x86: CPUID tracepoint enhancements
Date: Wed, 18 Mar 2020 13:45:01 +0100 [thread overview]
Message-ID: <f7a1a4a0-7730-93a7-564e-fc4dcad4ee2c@redhat.com> (raw)
In-Reply-To: <20200317195354.28384-1-sean.j.christopherson@intel.com>
On 17/03/20 20:53, Sean Christopherson wrote:
> Two enhancements to the CPUID tracepoint. Patch 01 was originally in the
> CPUID ranges series, but I unintentionally dropped it in v2.
>
> The final output looks like:
>
> kvm_cpuid: func 0 idx 0 rax d rbx 68747541 rcx 444d4163 rdx 69746e65, cpuid entry found
> kvm_cpuid: func d idx 444d4163 rax 0 rbx 0 rcx 0 rdx 0, cpuid entry not found
> kvm_cpuid: func 80000023 idx 1 rax f rbx 240 rcx 0 rdx 0, cpuid entry not found, used max basic
> kvm_cpuid: func 80000023 idx 2 rax 100 rbx 240 rcx 0 rdx 0, cpuid entry not found, used max basic
>
> I also considered appending "exact" to the "found" case, which is more
> directly what Jan suggested, but IMO "found exact" implies there's also a
> "found inexact", which is not true. AIUI, calling out that KVM is using
> the max basic leaf values is what's really important to avoid confusion.
>
> Ideally, the function of the max basic leaf would also be displayed, but
> doing that without printing garbage for the other cases is a lot of ugly
> code for marginal value.
>
> Sean Christopherson (2):
> KVM: x86: Add requested index to the CPUID tracepoint
> KVM: x86: Add blurb to CPUID tracepoint when using max basic leaf
> values
>
> arch/x86/kvm/cpuid.c | 9 ++++++---
> arch/x86/kvm/trace.h | 18 ++++++++++++------
> 2 files changed, 18 insertions(+), 9 deletions(-)
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-03-18 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 19:53 [PATCH 0/2] KVM: x86: CPUID tracepoint enhancements Sean Christopherson
2020-03-17 19:53 ` [PATCH 1/2] KVM: x86: Add requested index to the CPUID tracepoint Sean Christopherson
2020-03-17 19:53 ` [PATCH 2/2] KVM: x86: Add blurb to CPUID tracepoint when using max basic leaf values Sean Christopherson
2020-03-18 12:45 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7a1a4a0-7730-93a7-564e-fc4dcad4ee2c@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).