From: Dmytro Maluka <dmy@semihalf.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Rong L Liu <rong.l.liu@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Tomasz Nowicki <tn@semihalf.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Dmitry Torokhov <dtor@google.com>
Subject: Re: [PATCH 3/3] KVM: irqfd: Postpone resamplefd notify for oneshot interrupts
Date: Fri, 29 Jul 2022 13:19:27 +0200 [thread overview]
Message-ID: <f7c9943a-6818-beed-5623-21689bf1d159@semihalf.com> (raw)
In-Reply-To: <YuLbvl7BBuLTBXO7@google.com>
On 7/28/22 20:55, Sean Christopherson wrote:
> On Fri, Jul 15, 2022, Dmytro Maluka wrote:
>> +static void
>> +irqfd_resampler_mask(struct kvm_irq_mask_notifier *kimn, bool masked)
>
> Ugh, I see you're just following the existing "style" in this file. Linus provided
> a lengthy explanation of why this style is unwanted[*]. And this file is straight up
> obnoxious, e.g. a large number of functions put the return type on a separate line
> even though it would fit without any wrap.
>
> My vote is to break from this file's style for this patch, and then do a follow-up
> patch to fix all the existing funky wraps.
Ok, I can do that.
Would you also like if I rename resampler->notifier to
resampler->ack_notifier and irqfd_resampler_mask() to
irqfd_resampler_mask_notify() for more clarity?
Thanks,
Dmytro
> [*] https://lore.kernel.org/all/CAHk-=wjoLAYG446ZNHfg=GhjSY6nFmuB_wA8fYd5iLBNXjo9Bw@mail.gmail.com
next prev parent reply other threads:[~2022-07-29 11:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 15:59 [PATCH 0/3] KVM: Fix oneshot interrupts forwarding Dmytro Maluka
2022-07-15 15:59 ` [PATCH 1/3] KVM: x86: Move kvm_(un)register_irq_mask_notifier() to generic KVM Dmytro Maluka
2022-07-28 18:46 ` Sean Christopherson
2022-07-29 11:09 ` Dmytro Maluka
2022-08-02 21:43 ` Sean Christopherson
2022-07-15 15:59 ` [PATCH 2/3] KVM: x86: Add kvm_irq_is_masked() Dmytro Maluka
2022-08-04 17:14 ` Eric Auger
2022-08-04 19:31 ` Dmytro Maluka
2022-07-15 15:59 ` [PATCH 3/3] KVM: irqfd: Postpone resamplefd notify for oneshot interrupts Dmytro Maluka
2022-07-25 23:44 ` Liu, Rong L
2022-07-26 14:07 ` Dmytro Maluka
2022-07-29 20:48 ` Liu, Rong L
2022-07-30 14:34 ` Dmytro Maluka
2022-08-09 22:02 ` Liu, Rong L
2022-08-10 0:56 ` Dmytro Maluka
2022-08-11 16:12 ` Liu, Rong L
2022-08-13 14:33 ` Dmytro Maluka
2022-08-10 17:34 ` Liu, Rong L
2022-07-28 18:55 ` Sean Christopherson
2022-07-29 11:19 ` Dmytro Maluka [this message]
2022-07-29 21:21 ` Liu, Rong L
2022-07-30 15:30 ` Dmytro Maluka
2022-08-02 18:47 ` Dmytro Maluka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c9943a-6818-beed-5623-21689bf1d159@semihalf.com \
--to=dmy@semihalf.com \
--cc=alex.williamson@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dtor@google.com \
--cc=eric.auger@redhat.com \
--cc=hpa@zytor.com \
--cc=jaz@semihalf.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rong.l.liu@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tn@semihalf.com \
--cc=x86@kernel.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).