From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E6CC4338F for ; Wed, 18 Aug 2021 13:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DDC761058 for ; Wed, 18 Aug 2021 13:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236767AbhHRNhz (ORCPT ); Wed, 18 Aug 2021 09:37:55 -0400 Received: from vps-vb.mhejs.net ([37.28.154.113]:39710 "EHLO vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233722AbhHRNhz (ORCPT ); Wed, 18 Aug 2021 09:37:55 -0400 Received: from MUA by vps-vb.mhejs.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mGLkN-0004Vy-54; Wed, 18 Aug 2021 15:36:47 +0200 Subject: Re: [PATCH] x86: kvm: Demote level of already loaded message from error to info To: Paul Menzel Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Ingo Molnar , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" References: <20210818114956.7171-1-pmenzel@molgen.mpg.de> From: "Maciej S. Szmigiero" Message-ID: Date: Wed, 18 Aug 2021 15:36:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210818114956.7171-1-pmenzel@molgen.mpg.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 18.08.2021 13:49, Paul Menzel wrote: > In scripts, running > > modprobe kvm_amd 2>/dev/null > modprobe kvm_intel 2>/dev/null > > to ensure the modules are loaded causes Linux to log errors. > > $ dmesg --level=err > [ 0.641747] [Firmware Bug]: TSC_DEADLINE disabled due to Errata; please update microcode to version: 0x3a (or later) > [ 40.196868] kvm: already loaded the other module > [ 40.219857] kvm: already loaded the other module > [ 55.501362] kvm [1177]: vcpu0, guest rIP: 0xffffffff96e5b644 disabled perfctr wrmsr: 0xc2 data 0xffff > [ 56.397974] kvm [1418]: vcpu0, guest rIP: 0xffffffff81046158 disabled perfctr wrmsr: 0xc1 data 0xabcd > [1007981.827781] kvm: already loaded the other module > [1008000.394089] kvm: already loaded the other module > [1008030.706999] kvm: already loaded the other module > [1020396.054470] kvm: already loaded the other module > [1020405.614774] kvm: already loaded the other module > [1020410.140069] kvm: already loaded the other module > [1020704.049231] kvm: already loaded the other module > > As one of the two KVM modules is already loaded, KVM is functioning, and > their is no error condition. Therefore, demote the log message level to > informational. > Shouldn't this return ENODEV when loading one of these modules instead as there is no hardware that supports both VMX and SVM? Thanks, Maciej