From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F141AC432C0 for ; Mon, 18 Nov 2019 13:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D011C2071C for ; Mon, 18 Nov 2019 13:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfKRN5Y (ORCPT ); Mon, 18 Nov 2019 08:57:24 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:33786 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726627AbfKRN5Y (ORCPT ); Mon, 18 Nov 2019 08:57:24 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id D9FA0DA6AFB7CBCC5C9F; Mon, 18 Nov 2019 21:57:20 +0800 (CST) Received: from [127.0.0.1] (10.142.68.147) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Mon, 18 Nov 2019 21:57:14 +0800 Subject: Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support To: "Michael S. Tsirkin" CC: Igor Mammedov , Xiang Zheng , , , , , , , , , , , , , , , References: <20191111014048.21296-1-zhengxiang9@huawei.com> <20191111014048.21296-4-zhengxiang9@huawei.com> <20191115103801.547fc84d@redhat.com> <87758ec2-c242-71c3-51f8-a5d348f8e7fd@huawei.com> <20191118082036-mutt-send-email-mst@kernel.org> From: gengdongjiu Message-ID: Date: Mon, 18 Nov 2019 21:57:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20191118082036-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Archived-At: List-Archive: List-Post: On 2019/11/18 21:21, Michael S. Tsirkin wrote: >> If use offset relative to GAS structure, the code does not easily extend to support more Generic Hardware Error Source. >> if use offset relative to hest_start, just use a loop, the code can support more error source, for example: >> for (source_id = 0; i> { >> ...... >> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >> source_id * sizeof(uint64_t)); >> ....... >> } >> >> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source > I'd try to merge this, worry about extending things later. > This is at v21 and the simpler you can keep things, > the faster it'll go in. Thanks a lot for the comments. Yes, I think we can merge the v21 series.