From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F69CC433B4 for ; Mon, 19 Apr 2021 11:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECC606108B for ; Mon, 19 Apr 2021 11:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234074AbhDSLdG (ORCPT ); Mon, 19 Apr 2021 07:33:06 -0400 Received: from mga12.intel.com ([192.55.52.136]:6102 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbhDSLdF (ORCPT ); Mon, 19 Apr 2021 07:33:05 -0400 IronPort-SDR: YbmF5Gd1digfDYP8vxklHNb4ndCUIPlI72zNh9nhnuSzu42Zg9iMf4w1qrWYIha16n5S4D9qFj VcJ2L5W/Qq/Q== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="174798621" X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="174798621" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 04:32:29 -0700 IronPort-SDR: SxlERyW6wwLteodLNuqR0qSiCcGDyl4OveuD9/VOlwvMWExEwcI3sV5YIZTgUhBeoz7qcmfz03 SivOd1e5ObmA== X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="426476438" Received: from xiaoyaol-mobl.ccr.corp.intel.com (HELO [10.254.213.121]) ([10.254.213.121]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 04:32:25 -0700 Subject: Re: [RFCv2 13/13] KVM: unmap guest memory using poisoned pages To: Sean Christopherson , "Kirill A. Shutemov" Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Jim Mattson , David Rientjes , "Edgecombe, Rick P" , "Kleen, Andi" , "Yamahata, Isaku" , Erdem Aktas , Steve Rutherford , Peter Gonda , David Hildenbrand , x86@kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210416154106.23721-1-kirill.shutemov@linux.intel.com> <20210416154106.23721-14-kirill.shutemov@linux.intel.com> From: Xiaoyao Li Message-ID: Date: Mon, 19 Apr 2021 19:32:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 4/17/2021 1:30 AM, Sean Christopherson wrote: > On Fri, Apr 16, 2021, Kirill A. Shutemov wrote: [...] >> index fadaccb95a4c..cd2374802702 100644 >> --- a/include/linux/kvm_host.h >> +++ b/include/linux/kvm_host.h >> @@ -436,6 +436,8 @@ static inline int kvm_arch_vcpu_memslots_id(struct kvm_vcpu *vcpu) >> } >> #endif >> >> +#define KVM_NR_SHARED_RANGES 32 >> + >> /* >> * Note: >> * memslots are not sorted by id anymore, please use id_to_memslot() >> @@ -513,6 +515,10 @@ struct kvm { >> pid_t userspace_pid; >> unsigned int max_halt_poll_ns; >> u32 dirty_ring_size; >> + bool mem_protected; >> + void *id; >> + int nr_shared_ranges; >> + struct range shared_ranges[KVM_NR_SHARED_RANGES]; > > Hard no for me. IMO, anything that requires KVM to track shared/pinned pages in > a separate tree/array is non-starter. More specific to TDX #MCs, KVM should not > be the canonical reference for the state of a page. > Do you mean something in struct page to track if the page is shared or private?