kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Stefan Fritsch" <sf@sfritsch.de>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: Add emulation for movups/movupd
Date: Wed, 4 Apr 2018 17:53:04 +0200	[thread overview]
Message-ID: <fbc6c706-e9ec-7d90-b8b4-858413cf922e@redhat.com> (raw)
In-Reply-To: <20180401155444.7006-1-sf@sfritsch.de>

On 01/04/2018 17:54, Stefan Fritsch wrote:
> This is very similar to the aligned versions movaps/movapd.
> 
> We have seen the corresponding emulation failures with openbsd as guest
> and with Windows 10 with intel HD graphics pass through.
> 
> Signed-off-by: Christian Ehrhardt <christian_ehrhardt@genua.de>
> Signed-off-by: Stefan Fritsch <sf@sfritsch.de>
> ---
>  arch/x86/kvm/emulate.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index d91eaeb01034..7dda8e38c19a 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -4498,6 +4498,10 @@ static const struct gprefix pfx_0f_2b = {
>  	ID(0, &instr_dual_0f_2b), ID(0, &instr_dual_0f_2b), N, N,
>  };
>  
> +static const struct gprefix pfx_0f_10_0f_11 = {
> +	I(Unaligned, em_mov), I(Unaligned, em_mov), N, N,
> +};
> +
>  static const struct gprefix pfx_0f_28_0f_29 = {
>  	I(Aligned, em_mov), I(Aligned, em_mov), N, N,
>  };
> @@ -4709,7 +4713,9 @@ static const struct opcode twobyte_table[256] = {
>  	DI(ImplicitOps | Priv, invd), DI(ImplicitOps | Priv, wbinvd), N, N,
>  	N, D(ImplicitOps | ModRM | SrcMem | NoAccess), N, N,
>  	/* 0x10 - 0x1F */
> -	N, N, N, N, N, N, N, N,
> +	GP(ModRM | DstReg | SrcMem | Mov | Sse, &pfx_0f_10_0f_11),
> +	GP(ModRM | DstMem | SrcReg | Mov | Sse, &pfx_0f_10_0f_11),
> +	N, N, N, N, N, N,
>  	D(ImplicitOps | ModRM | SrcMem | NoAccess),
>  	N, N, N, N, N, N, D(ImplicitOps | ModRM | SrcMem | NoAccess),
>  	/* 0x20 - 0x2F */
> 

Applied, thanks.

Paolo

  parent reply	other threads:[~2018-04-04 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01 15:54 [PATCH] kvm: Add emulation for movups/movupd Stefan Fritsch
2018-04-03 19:44 ` Radim Krčmář
2018-04-04 15:53 ` Paolo Bonzini [this message]
2018-04-04 17:10   ` Konrad Rzeszutek Wilk
2018-04-04 17:24     ` Paolo Bonzini
2018-04-04 17:35       ` Stefan Fritsch
2018-04-05  5:44         ` Paolo Bonzini
2021-01-12 23:47           ` Jim Mattson
2021-01-15  8:56             ` Stefan Fritsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbc6c706-e9ec-7d90-b8b4-858413cf922e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=sf@sfritsch.de \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).