From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F7B4C2D0DB for ; Wed, 22 Jan 2020 15:51:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55C5824125 for ; Wed, 22 Jan 2020 15:51:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QjEU/3Fx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbgAVPvq (ORCPT ); Wed, 22 Jan 2020 10:51:46 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:36560 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbgAVPvq (ORCPT ); Wed, 22 Jan 2020 10:51:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579708305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Oh+HefrYBghvTz0gRuE0ctztS1fd6vHOChnV/W4YF0=; b=QjEU/3FxQv2j3opZFD/tOmay9iCvueJOfw6E+i0QBOxvGqiI070suS++BA2hCPet3A89l2 KhPiOGTkFs5HsnXFGYWcg9MzetAy1zdQgk1w9Mwz9taeP82tTaGOPcCknieoGZ3lsQ4Yjx Prg6xQSyMZLW+e9IPxUsscQqrRJAx5E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-qKRM_goANd-0lk0xlNXRLQ-1; Wed, 22 Jan 2020 10:51:43 -0500 X-MC-Unique: qKRM_goANd-0lk0xlNXRLQ-1 Received: by mail-wr1-f70.google.com with SMTP id y7so3286821wrm.3 for ; Wed, 22 Jan 2020 07:51:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Oh+HefrYBghvTz0gRuE0ctztS1fd6vHOChnV/W4YF0=; b=lX3caU4ppikLFvEuoEXDXPkx9VJpxDVz9mk7DpTIfkfqfFJg31D/Nja4A4Yx5GDZC1 l45zVlfzGNRClGg4+HNXTZkOjbRbxc7+3zVmpOL5w+Up18pwNVAoT40N8xIuCTeLRa9b oDz3SkMuShOdDqP1ZOIJKH0udDXNpzYN6bXo04yMEbcF/XlJGsWdv30OCIPpa6X8AsiE ue4vzb4Xuyqw+RmXpAuq+FdBMYfofsLmf4enHwgOHtAgGxonh4E9bjht5ir/XAELYUaM h+DNKFJnsn1xU08WeY0Rjn9Z6dQCjpbqrMz/ogSnBWQGRd6VUENHr0RgPdz1p6JoVP0+ yJ9g== X-Gm-Message-State: APjAAAW61jmUzwRcEK+NHIcY2mnZLbZ1PQmNU8zpSf4XioiTeArhP8io z4ZI6RVR+TFw+DMxmM6+hqPvfO0vjcrNxOfmntfRdLPqOJ/qsiTQc4U6Elj3ofWLcYbJiwFvjWM tpRcPZgXQLPy2 X-Received: by 2002:a5d:45cc:: with SMTP id b12mr11438546wrs.424.1579708302151; Wed, 22 Jan 2020 07:51:42 -0800 (PST) X-Google-Smtp-Source: APXvYqzqA6lRooDUJzcEoLeIgVcxs3FkI8+hHgraQm2Lzb3LAPvygoLb1ZpEpKdyiont2219ajtlBQ== X-Received: by 2002:a5d:45cc:: with SMTP id b12mr11438522wrs.424.1579708301921; Wed, 22 Jan 2020 07:51:41 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:b8fe:679e:87eb:c059? ([2001:b07:6468:f312:b8fe:679e:87eb:c059]) by smtp.gmail.com with ESMTPSA id f207sm5374746wme.9.2020.01.22.07.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2020 07:51:41 -0800 (PST) Subject: Re: [PATCH v5 03/18] kvm: x86: Introduce APICv inhibit reason bits To: Suravee Suthikulpanit , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: rkrcmar@redhat.com, joro@8bytes.org, vkuznets@redhat.com, rkagan@virtuozzo.com, graf@amazon.com, jschoenh@amazon.de, karahmed@amazon.de, rimasluk@amazon.com, jon.grimm@amd.com References: <1573762520-80328-1-git-send-email-suravee.suthikulpanit@amd.com> <1573762520-80328-4-git-send-email-suravee.suthikulpanit@amd.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Jan 2020 16:51:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1573762520-80328-4-git-send-email-suravee.suthikulpanit@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org A couple slight improvements, after which get_enable_apicv is unused. Paolo On 14/11/19 21:15, Suravee Suthikulpanit wrote: > @@ -6848,6 +6848,7 @@ static int vmx_vm_init(struct kvm *kvm) > break; > } > } > + kvm_apicv_init(kvm, vmx_get_enable_apicv(kvm)); > return 0; > } > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 01f60d6cd881..d011ffaec7ee 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6852,7 +6852,7 @@ static int vmx_vm_init(struct kvm *kvm) break; } } - kvm_apicv_init(kvm, vmx_get_enable_apicv(kvm)); + kvm_apicv_init(kvm, enable_apicv); return 0; } > @@ -9347,10 +9364,11 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu) > goto fail_free_pio_data; > > if (irqchip_in_kernel(vcpu->kvm)) { > - vcpu->arch.apicv_active = kvm_x86_ops->get_enable_apicv(vcpu->kvm); > r = kvm_create_lapic(vcpu, lapic_timer_advance_ns); > if (r < 0) > goto fail_mmu_destroy; > + if (kvm_apicv_activated(vcpu->kvm)) > + vcpu->arch.apicv_active = kvm_x86_ops->get_enable_apicv(vcpu->kvm); > } else > static_key_slow_inc(&kvm_no_apic_vcpu); > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 6c62abb4fdd9..cc9f84527a55 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -9236,7 +9236,7 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu) if (r < 0) goto fail_mmu_destroy; if (kvm_apicv_activated(vcpu->kvm)) - vcpu->arch.apicv_active = kvm_x86_ops->get_enable_apicv(vcpu->kvm); + vcpu->arch.apicv_active = true; } else static_key_slow_inc(&kvm_no_apic_vcpu);