From: Colton Lewis <coltonlewis@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
dmatlack@google.com, seanjc@google.com, bgardon@google.com,
oupton@google.com
Subject: Re: [PATCH 3/3] KVM: selftests: Print summary stats of memory latency distribution
Date: Thu, 26 Jan 2023 17:58:18 +0000 [thread overview]
Message-ID: <gsnth6wdqith.fsf@coltonlewis-kvm.c.googlers.com> (raw)
In-Reply-To: <Y8cIzKf52fzf0/d4@google.com> (message from Ricardo Koller on Tue, 17 Jan 2023 12:45:00 -0800)
Ricardo Koller <ricarkol@google.com> writes:
> Latency distribution (ns) = min: 732, 50th: 792, 90th: 901, 99th:
> ^^^
> nit: would prefer to avoid the spaces
The spaces are there so each number has a fixed width and makes the
lines easy to visually compare because the numbers are aligned to the
same columns. No way to avoid some extra spaces and preserve this
property. What if a number is a different length than expected? I chose
a uniform width I was confident would always fit a measurement of the
max.
next prev parent reply other threads:[~2023-01-26 17:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 17:32 [PATCH 0/3] Calculate memory access latency stats Colton Lewis
2022-11-15 17:32 ` [PATCH 1/3] KVM: selftests: Allocate additional space for latency samples Colton Lewis
2023-01-17 20:32 ` Ricardo Koller
2023-01-18 16:49 ` Sean Christopherson
2023-01-26 18:00 ` Colton Lewis
2022-11-15 17:32 ` [PATCH 2/3] KVM: selftests: Collect memory access " Colton Lewis
2023-01-17 20:43 ` Ricardo Koller
2023-01-18 16:32 ` Sean Christopherson
2023-01-26 18:00 ` Colton Lewis
2023-01-26 19:07 ` Sean Christopherson
2023-01-26 17:58 ` Colton Lewis
2023-01-26 18:30 ` Ricardo Koller
2023-01-17 20:48 ` Ricardo Koller
2023-01-26 17:59 ` Colton Lewis
2022-11-15 17:32 ` [PATCH 3/3] KVM: selftests: Print summary stats of memory latency distribution Colton Lewis
2023-01-17 20:45 ` Ricardo Koller
2023-01-26 17:58 ` Colton Lewis [this message]
2023-01-18 16:43 ` Sean Christopherson
2023-01-26 17:59 ` Colton Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gsnth6wdqith.fsf@coltonlewis-kvm.c.googlers.com \
--to=coltonlewis@google.com \
--cc=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).