From: David Edmondson <dme@dme.org>
To: Sean Christopherson <seanjc@google.com>,
Aaron Lewis <aaronlewis@google.com>
Cc: jmattson@google.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm: x86: Allow userspace to handle emulation errors
Date: Wed, 21 Apr 2021 09:39:35 +0100 [thread overview]
Message-ID: <m2sg3kt4jc.fsf@dme.org> (raw)
In-Reply-To: <YH8eyGMC3A9+CKTo@google.com>
On Tuesday, 2021-04-20 at 18:34:48 UTC, Sean Christopherson wrote:
> On Fri, Apr 16, 2021, Aaron Lewis wrote:
>> + KVM_INTERNAL_ERROR_EMULATION_FLAG_INSTRUCTION_BYTES;
>> + vcpu->run->emulation_failure.insn_size = insn_size;
>> + memcpy(vcpu->run->emulation_failure.insn_bytes,
>> + ctxt->fetch.data, sizeof(ctxt->fetch.data));
>
> Doesn't truly matter, but I think it's less confusing to copy over insn_size
> bytes.
And zero out the rest?
dme.
--
Woke up in my clothes again this morning, don't know exactly where I am.
next prev parent reply other threads:[~2021-04-21 8:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 13:18 [PATCH 1/2] kvm: x86: Allow userspace to handle emulation errors Aaron Lewis
2021-04-16 13:18 ` [PATCH 2/2] selftests: kvm: Allows " Aaron Lewis
2021-04-19 12:41 ` [PATCH 1/2] kvm: x86: Allow " David Edmondson
2021-04-19 16:47 ` Aaron Lewis
2021-04-20 7:21 ` David Edmondson
2021-04-20 14:57 ` Aaron Lewis
2021-04-20 16:53 ` David Edmondson
2021-04-20 18:21 ` Sean Christopherson
2021-04-21 8:00 ` David Edmondson
2021-04-20 18:34 ` Sean Christopherson
2021-04-21 8:39 ` David Edmondson [this message]
2021-04-21 12:47 ` Aaron Lewis
2021-04-21 16:26 ` Jim Mattson
2021-04-21 17:01 ` David Edmondson
2021-04-21 17:28 ` Jim Mattson
2021-04-21 16:31 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sg3kt4jc.fsf@dme.org \
--to=dme@dme.org \
--cc=aaronlewis@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).