From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0B5C433ED for ; Wed, 21 Apr 2021 08:39:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4890E61426 for ; Wed, 21 Apr 2021 08:39:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236392AbhDUIkL (ORCPT ); Wed, 21 Apr 2021 04:40:11 -0400 Received: from forward3-smtp.messagingengine.com ([66.111.4.237]:38277 "EHLO forward3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbhDUIkK (ORCPT ); Wed, 21 Apr 2021 04:40:10 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailforward.nyi.internal (Postfix) with ESMTP id A8CBF19417DB; Wed, 21 Apr 2021 04:39:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 21 Apr 2021 04:39:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=B+vuHZ SEBeP1MIHIlj5mpmizmyN0czTVssJhvmZQTrc=; b=nn/V7C9wa/NWZbltTyAdHK 0BCgUhuUCBHuPofS/DhQR8QfrL+0VXKJagvrDA4fExN+kTabBTNXOcxf+Rs1ksO9 ubQGWkHCf9qFb9QLuO366zkLZ5ZF8XtxkG/Jg1aYesu2EAo9QmBfkHshamC2oZI4 0fI2M2C7ZZ7Lvwj5xYA3VjL/ua2cfiXIp8CRySVLe1UU/kYTv0Co9zSo52eCWmSI OkdrPfr4+YEQUWWp6atSVuAlACyxbjBAPEaJE5NozY1dG1PL/7+eWtB6YDupaQ2N s9XN6BjaKw56bkBeLNYRdj5/zkyrPdwa7DJ9yyme8xH85JPrR6fQ+mlyIRD3dycQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvffujghfhfffkfggtgesthdtredttddttdenucfhrhhomhepffgrvhhiugcu gfgumhhonhgushhonhcuoegumhgvsegumhgvrdhorhhgqeenucggtffrrghtthgvrhhnpe fhkeeguedtvdegffffteehjedvjeeitefgfefgffdugeffffegudehgeetgeelkeenucfk phepkedurddukeejrddviedrvdefkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegumhgvsegumhgvrdhorhhg X-ME-Proxy: Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net [81.187.26.238]) by mail.messagingengine.com (Postfix) with ESMTPA id C075B108005B; Wed, 21 Apr 2021 04:39:36 -0400 (EDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 297b95e4; Wed, 21 Apr 2021 08:39:35 +0000 (UTC) To: Sean Christopherson , Aaron Lewis Cc: jmattson@google.com, kvm@vger.kernel.org Subject: Re: [PATCH 1/2] kvm: x86: Allow userspace to handle emulation errors In-Reply-To: References: <20210416131820.2566571-1-aaronlewis@google.com> X-HGTTG: heart-of-gold From: David Edmondson Date: Wed, 21 Apr 2021 09:39:35 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tuesday, 2021-04-20 at 18:34:48 UTC, Sean Christopherson wrote: > On Fri, Apr 16, 2021, Aaron Lewis wrote: >> + KVM_INTERNAL_ERROR_EMULATION_FLAG_INSTRUCTION_BYTES; >> + vcpu->run->emulation_failure.insn_size = insn_size; >> + memcpy(vcpu->run->emulation_failure.insn_bytes, >> + ctxt->fetch.data, sizeof(ctxt->fetch.data)); > > Doesn't truly matter, but I think it's less confusing to copy over insn_size > bytes. And zero out the rest? dme. -- Woke up in my clothes again this morning, don't know exactly where I am.