From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06BA6C4332F for ; Thu, 20 Oct 2022 07:20:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 952B44B93D; Thu, 20 Oct 2022 03:20:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0pre0vxfV6Dy; Thu, 20 Oct 2022 03:19:59 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 082A64B8E6; Thu, 20 Oct 2022 03:19:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BB9124B8D8 for ; Thu, 20 Oct 2022 03:19:57 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k9AVRLt58wtN for ; Thu, 20 Oct 2022 03:19:56 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 380134B887 for ; Thu, 20 Oct 2022 03:19:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666250395; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9HqOzVsB8T4yggWYl1bqige06n7AwLzVreZ+LrEySM=; b=L8BJhBOWHA+v2bsnHTsbLYj3hogeVz2ah+pKNVurHMSzhzkUtMgvmu6CY+T+chtuUxMzvk Hh/k8n18Xoj+2djMHq2d3k3VPnRVeEfHuINhD+CqtOAGiGJnuNeoRuOuu52xDXFfFAds86 yVaPuq1fOLyOYTNUH3GNu8Iu9EUZS94= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-339--4tmXxcVONmOztGz3krQ0w-1; Thu, 20 Oct 2022 03:19:54 -0400 X-MC-Unique: -4tmXxcVONmOztGz3krQ0w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDD051C068C9; Thu, 20 Oct 2022 07:19:53 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5A1EC15BA5; Thu, 20 Oct 2022 07:19:45 +0000 (UTC) Subject: Re: [PATCH 4/6] KVM: selftests: memslot_perf_test: Support variable guest page size To: "Maciej S. Szmigiero" References: <20221014071914.227134-1-gshan@redhat.com> <20221014071914.227134-5-gshan@redhat.com> <3eecebca-a526-d10a-02d3-496ce919d577@maciej.szmigiero.name> <5bfbe050-a654-8400-e1f1-dcfa4dba13e6@redhat.com> From: Gavin Shan Message-ID: <001d6b60-dc05-370d-5cb3-9f8f855089c3@redhat.com> Date: Thu, 20 Oct 2022 15:19:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Cc: kvm@vger.kernel.org, maz@kernel.org, linux-kernel@vger.kernel.org, zhenyzha@redhat.com, shan.gavin@gmail.com, kvmarm@lists.linux.dev, pbonzini@redhat.com, shuah@kernel.org, kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Gavin Shan List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMTAvMjAvMjIgNDoxOCBBTSwgTWFjaWVqIFMuIFN6bWlnaWVybyB3cm90ZToKPiBPbiAxOS4x MC4yMDIyIDAyOjI2LCBHYXZpbiBTaGFuIHdyb3RlOgo+PiBPbiAxMC8xOC8yMiAxMTo1NiBQTSwg TWFjaWVqIFMuIFN6bWlnaWVybyB3cm90ZToKPj4+IE9uIDE4LjEwLjIwMjIgMDI6NTEsIEdhdmlu IFNoYW4gd3JvdGU6Cj4+Pj4gT24gMTAvMTgvMjIgODo0NiBBTSwgR2F2aW4gU2hhbiB3cm90ZToK Pj4+Pj4gT24gMTAvMTgvMjIgNTozMSBBTSwgTWFjaWVqIFMuIFN6bWlnaWVybyB3cm90ZToKPj4+ Pj4+IE9uIDE0LjEwLjIwMjIgMDk6MTksIEdhdmluIFNoYW4gd3JvdGU6Cj4+Pj4+Pj4gVGhlIHRl c3QgY2FzZSBpcyBvYnZpb3VzbHkgYnJva2VuIG9uIGFhcmNoNjQgYmVjYXVzZSBub24tNEtCIGd1 ZXN0Cj4+Pj4+Pj4gcGFnZSBzaXplIGlzIHN1cHBvcnRlZC4gVGhlIGd1ZXN0IHBhZ2Ugc2l6ZSBv biBhYXJjaDY0IGNvdWxkIGJlIDRLQiwKPj4+Pj4+PiAxNktCIG9yIDY0S0IuCj4+Pj4+Pj4KPj4+ Pj4+PiBUaGlzIHN1cHBvcnRzIHZhcmlhYmxlIGd1ZXN0IHBhZ2Ugc2l6ZSwgbW9zdGx5IGZvciBh YXJjaDY0Lgo+Pj4+Pj4+Cj4+Pj4+Pj4gwqDCoCAtIFRoZSBob3N0IGRldGVybWluZXMgdGhlIGd1 ZXN0IHBhZ2Ugc2l6ZSB3aGVuIHZpcnR1YWwgbWFjaGluZSBpcwo+Pj4+Pj4+IMKgwqDCoMKgIGNy ZWF0ZWQuIFRoZSB2YWx1ZSBpcyBhbHNvIHBhc3NlZCB0byBndWVzdCB0aHJvdWdoIHRoZSBzeW5j aHJvbml6YXRpb24KPj4+Pj4+PiDCoMKgwqDCoCBhcmVhLgo+Pj4+Pj4+Cj4+Pj4+Pj4gwqDCoCAt IFRoZSBudW1iZXIgb2YgZ3Vlc3QgcGFnZXMgYXJlIHVua25vd24gdW50aWwgdGhlIHZpcnR1YWwg bWFjaGluZQo+Pj4+Pj4+IMKgwqDCoMKgIGlzIHRvIGJlIGNyZWF0ZWQuIFNvIGFsbCB0aGUgcmVs YXRlZCBtYWNyb3MgYXJlIGRyb3BwZWQuIEluc3RlYWQsCj4+Pj4+Pj4gwqDCoMKgwqAgdGhlaXIg dmFsdWVzIGFyZSBkeW5hbWljYWxseSBjYWxjdWxhdGVkIGJhc2VkIG9uIHRoZSBndWVzdCBwYWdl Cj4+Pj4+Pj4gwqDCoMKgwqAgc2l6ZS4KPj4+Pj4+Pgo+Pj4+Pj4+IMKgwqAgLSBUaGUgc3RhdGlj IGNoZWNrcyBvbiBtZW1vcnkgc2l6ZXMgYW5kIHBhZ2VzIGJlY29tZXMgZGVwZW5kZW50Cj4+Pj4+ Pj4gwqDCoMKgwqAgb24gZ3Vlc3QgcGFnZSBzaXplLCB3aGljaCBpcyB1bmtub3duIHVudGlsIHRo ZSB2aXJ0dWFsIG1hY2hpbmUKPj4+Pj4+PiDCoMKgwqDCoCBpcyBhYm91dCB0byBiZSBjcmVhdGVk LiBTbyBhbGwgdGhlIHN0YXRpYyBjaGVja3MgYXJlIGNvbnZlcnRlZAo+Pj4+Pj4+IMKgwqDCoMKg IHRvIGR5bmFtaWMgY2hlY2tzLCBkb25lIGluIGNoZWNrX21lbW9yeV9zaXplcygpLgo+Pj4+Pj4+ Cj4+Pj4+Pj4gwqDCoCAtIEFzIHRoZSBhZGRyZXNzIHBhc3NlZCB0byBtYWR2aXNlKCkgc2hvdWxk IGJlIGFsaWduZWQgdG8gaG9zdCBwYWdlLAo+Pj4+Pj4+IMKgwqDCoMKgIHRoZSBzaXplIG9mIHBh Z2UgY2h1bmsgaXMgYXV0b21hdGljYWxseSBzZWxlY3RlZCwgb3RoZXIgdGhhbiBvbmUKPj4+Pj4+ PiDCoMKgwqDCoCBwYWdlLgo+Pj4+Pj4+Cj4+Pj4+Pj4gwqDCoCAtIEFsbCBvdGhlciBjaGFuZ2Vz IGluY2x1ZGVkIGluIHRoaXMgcGF0Y2ggYXJlIGFsbW9zdCBtZWNoYW5pY2FsCj4+Pj4+Pj4gwqDC oMKgwqAgcmVwbGFjaW5nICc0MDk2JyB3aXRoICdndWVzdF9wYWdlX3NpemUnLgo+Pj4+Pj4+Cj4+ Pj4+Pj4gU2lnbmVkLW9mZi1ieTogR2F2aW4gU2hhbiA8Z3NoYW5AcmVkaGF0LmNvbT4KPj4+Pj4+ PiAtLS0KPj4+Pj4+PiDCoCAuLi4vdGVzdGluZy9zZWxmdGVzdHMva3ZtL21lbXNsb3RfcGVyZl90 ZXN0LmMgfCAxOTEgKysrKysrKysrKystLS0tLS0tCj4+Pj4+Pj4gwqAgMSBmaWxlIGNoYW5nZWQs IDExNSBpbnNlcnRpb25zKCspLCA3NiBkZWxldGlvbnMoLSkKPj4+Pj4+Pgo+Pj4+Pj4+IGRpZmYg LS1naXQgYS90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9rdm0vbWVtc2xvdF9wZXJmX3Rlc3QuYyBi L3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2t2bS9tZW1zbG90X3BlcmZfdGVzdC5jCj4+Pj4+Pj4g aW5kZXggZDVhYTkxNDhmOTZmLi5kNTg3YmQ5NTJmZjkgMTAwNjQ0Cj4+Pj4+Pj4gLS0tIGEvdG9v bHMvdGVzdGluZy9zZWxmdGVzdHMva3ZtL21lbXNsb3RfcGVyZl90ZXN0LmMKPj4+Pj4+PiArKysg Yi90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9rdm0vbWVtc2xvdF9wZXJmX3Rlc3QuYwo+Pj4gKC4u LikKPj4+Pj4+PiBAQCAtNzcsOCArNjEsNyBAQCBzdGF0aWNfYXNzZXJ0KE1FTV9URVNUX1VOTUFQ X1NJWkVfUEFHRVMgJQo+Pj4+Pj4+IMKgwqAgKiBmb3IgdGhlIHRvdGFsIHNpemUgb2YgMjUgcGFn ZXMuCj4+Pj4+Pj4gwqDCoCAqIEhlbmNlLCB0aGUgbWF4aW11bSBzaXplIGhlcmUgaXMgNTAgcGFn ZXMuCj4+Pj4+Pj4gwqDCoCAqLwo+Pj4+Pj4+IC0jZGVmaW5lIE1FTV9URVNUX01PVkVfU0laRV9Q QUdFU8KgwqDCoCAoNTApCj4+Pj4+Pj4gLSNkZWZpbmUgTUVNX1RFU1RfTU9WRV9TSVpFwqDCoMKg wqDCoMKgwqAgKE1FTV9URVNUX01PVkVfU0laRV9QQUdFUyAqIDQwOTYpCj4+Pj4+Pj4gKyNkZWZp bmUgTUVNX1RFU1RfTU9WRV9TSVpFwqDCoMKgwqDCoMKgwqAgMHgzMjAwMAo+Pj4+Pj4KPj4+Pj4+ IFRoZSBhYm92ZSBudW1iZXIgc2VlbXMgbGVzcyByZWFkYWJsZSB0aGFuIGFuIGV4cGxpY2l0IHZh bHVlIG9mIDUwIHBhZ2VzLgo+Pj4+Pj4KPj4+Pj4+IEluIGFkZGl0aW9uIHRvIHRoYXQsIGl0J3Mg NTAgcGFnZXMgb25seSB3aXRoIDRrIHBhZ2Ugc2l6ZSwgc28gYXQgbGVhc3QKPj4+Pj4+IHRoZSBj b21tZW50IGFib3ZlIG5lZWRzIHRvIGJlIHVwZGF0ZWQgdG8gcmVmbGVjdCB0aGlzIGZhY3QuCj4+ Pj4+Pgo+Pj4+Pgo+Pj4+PiBZZWFoLCBJIHdpbGwgY2hhbmdlIHRoZSBjb21tZW50cyBsaWtlIGJl bG93IGluIG5leHQgcmV2aXNpb24uCj4+Pj4+Cj4+Pj4+IMKgwqAvKgo+Pj4+PiDCoMKgICogV2hl biBydW5uaW5nIHRoaXMgdGVzdCB3aXRoIDMyayBtZW1zbG90cywgYWN0dWFsbHkgMzI3NjMgZXhj bHVkaW5nCj4+Pj4+IMKgwqAgKiB0aGUgcmVzZXJ2ZWQgbWVtb3J5IHNsb3QgMCwgdGhlIG1lbW9y eSBmb3IgZWFjaCBzbG90IGlzIDB4NDAwMCBieXRlcy4KPj4+Pj4gwqDCoCAqIFRoZSBsYXN0IHNs b3QgY29udGFpbnMgMHgxOTAwMCBieXRlcyBtZW1vcnkuIEhlbmNlLCB0aGUgbWF4aW11bSBzaXpl Cj4+Pj4+IMKgwqAgKiBoZXJlIGlzIDB4MzIwMDAgYnl0ZXMuCj4+Pj4+IMKgwqAgKi8KPj4+Pj4K Pj4+Pgo+Pj4+IEkgd2lsbCByZXBsYWNlIHRob3NlIG51bWJlcnMgd2l0aCByZWFkYWJsZSBvbmVz IGxpa2UgYmVsb3cgOikKPj4+Pgo+Pj4+IC8qCj4+Pj4gwqDCoCogV2hlbiBydW5uaW5nIHRoaXMg dGVzdCB3aXRoIDMyayBtZW1zbG90cywgYWN0dWFsbHkgMzI3NjMgZXhjbHVkaW5nCj4+Pj4gwqDC oCogdGhlIHJlc2VydmVkIG1lbW9yeSBzbG90IDAsIHRoZSBtZW1vcnkgZm9yIGVhY2ggc2xvdCBp cyAxNktCLiBUaGUKPj4+PiDCoMKgKiBsYXN0IHNsb3QgY29udGFpbnMgMTAwS0IgbWVtb3J5IHdp dGggdGhlIHJlbWFpbmluZyA4NEtCLiBIZW5jZSwKPj4+PiDCoMKgKiB0aGUgbWF4aW11bSBzaXpl IGlzIGRvdWJsZSBvZiB0aGF0ICgyMDBLQikKPj4+PiDCoMKgKi8KPj4+Cj4+PiBTdGlsbCwgdGhl c2UgbnVtYmVycyBhcmUgZm9yIHg4Niwgd2hpY2ggaGFzIEtWTV9JTlRFUk5BTF9NRU1fU0xPVFMK Pj4+IGRlZmluZWQgYXMgMy4KPj4+Cj4+PiBBcyBmYXIgYXMgSSBjYW4gc2VlIGFhcmNoNjQgaGFz IEtWTV9JTlRFUk5BTF9NRU1fU0xPVFMgZXF1YWwgdG8gMCwgc28KPj4+IHRoaXMgYXJjaCBoYXMg MzI3NjYgc2xvdCBhdmFpbGFibGUgZm9yIHRoZSB0ZXN0IG1lbW9yeS4KPj4+Cj4+PiBRdWljayBj YWxjdWxhdGlvbnMgc2hvdyB0aGF0IHRoaXMgd2lsbCByZXN1bHQgaW4gMTEyIEtpQiBvZiBtZW1v cnkgaW4KPj4+IHRoZSBsYXN0IHNsb3QgZm9yIDQgS2lCIHBhZ2Ugc2l6ZSAod2hpbGUgZm9yIDY0 IEtpQiBwYWdlIHNpemUgdGhlCj4+PiBtYXhpbXVtIHNsb3QgY291bnQgZm9yIHRoaXMgdGVzdCBp cyA4MTkyIGFueXdheSAtIG5vdCBjb3VudGluZyBzbG90IDApLgo+Pj4KPj4KPj4gSXQgc2VlbXMg eW91ciBjYWxjdWxhdGlvbiBoYWQgKDUxMk1CKzY0S0IpLCBpbnN0ZWFkIG9mICg1MTJNQis0S0Ip Lgo+PiBJbiB0aGlzIHBhcnRpY3VsYXIgcGF0Y2gsIHdlIHN0aWxsIGhhdmUgKDUxMk1CKzRLQiku IEhvdyBhYm91dCB0byBjaGFuZ2UKPj4gbGlrZSBiZWxvdyBpbiB0aGlzIHBhdGNoLiBJbiBuZXh0 IHBhdGNoLCBpdCdzIGFkanVzdGVkIGFjY29yZGluZ2x5IGFmdGVyCj4+IHdlIGhhdmUgKDUxMk1C KzY0S0IpLgo+IAo+IE15IHJldmlldyBjb21tZW50IGFib3ZlIHJlZmVycmVkIHRvIHRoZSBmaW5h bCBNRU1fU0laRSB2YWx1ZSBhZnRlciB0aGUKPiB3aG9sZSBzZXJpZXMsIHNvIDUxMiBNaUIgKyA2 NCBLaUIuCj4gCj4gSSBwbGFjZWQgdGhhdCByZXZpZXcgY29tbWVudCBvbiBwYXRjaCA0IHNpbmNl IGl0J3MgdGhlIG9ubHkgcGF0Y2ggaW4gdGhpcwo+IHNlcmllcyB0aGF0IG1vZGlmaWVkIHRoZSBj b2RlIGNvbW1lbnQgYWJvdXQgTUVNX1RFU1RfTU9WRV9TSVpFLgo+IAo+Pgo+PiAoMSkgSW4gdGhp cyBwYXRjaCwgdGhlIGNvbW1lbnQgaXMgY2hhbmdlZCB0byBhcyBiZWxvdwo+Pgo+PiDCoMKgwqDC oCAvKgo+PiDCoMKgwqDCoMKgICogV2UgaGF2ZSBkaWZmZXJlbnQgbnVtYmVyIG9mIG1lbW9yeSBz bG90cywgZXhjbHVkaW5nIHRoZSByZXNlcnZlZAo+PiDCoMKgwqDCoMKgICogbWVtb3J5IHNsb3Qg MCwgb24gdmFyaW91cyBhcmNoaXRlY3R1cmVzIGFuZCBjb25maWd1cmF0aW9ucy4gVGhlCj4+IMKg wqDCoMKgwqAgKiBtZW1vcnkgc2l6ZSBpbiB0aGlzIHRlc3QgaXMgY2FsY3VsYXRlZCBieSBkb3Vi bGluZyB0aGUgbWF4aW1hbAo+PiDCoMKgwqDCoMKgICogbWVtb3J5IHNpemUgaW4gbGFzdCBtZW1v cnkgc2xvdCwgd2l0aCBhbGlnbm1lbnQgdG8gdGhlIGxhcmdlc3QKPj4gwqDCoMKgwqDCoCAqIHN1 cHBvcnRlZCBwYWdlIHNpemUgKDY0S0IpLgo+PiDCoMKgwqDCoMKgICoKPj4gwqDCoMKgwqDCoCAq IGFyY2hpdGVjdHVyZcKgwqAgc2xvdHPCoMKgwqAgbWVtb3J5LXBlci1zbG90wqDCoMKgIG1lbW9y eS1vbi1sYXN0LXNsb3QKPj4gwqDCoMKgwqDCoCAqIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+IMKgwqDCoMKgwqAgKiB4ODYt NEtCwqDCoMKgwqDCoMKgwqAgMzI3NjPCoMKgwqAgMTZLQsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgMTAwS0IKPj4gwqDCoMKgwqDCoCAqIGFybTY0LTRLQsKgwqDCoMKgwqAgMzI3NjbCoMKg wqAgMTZLQsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgNTJLQgo+PiDCoMKgwqDCoMKgICog YXJtNjQtNjRLQsKgwqDCoMKgIDgxOTLCoMKgwqDCoCA2NEtCwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCA2NEtCCj4+IMKgwqDCoMKgwqAgKi8KPj4gwqDCoMKgwqAgI2RlZmluZSBNRU1fVEVT VF9NT1ZFX1NJWkXCoMKgwqAgMHg0MDAwMMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8qIDI1NktCICov Cj4+Cj4+ICgyKSBJbiB0aGUgbmV4dCBwYXRjaCwgd2hlcmUgd2UgaGF2ZSAoNTEyTUIrNjRLQikg YWZ0ZXIgdGhlIHZhcmlvdXMKPj4gwqDCoMKgwqAgbWVtb3J5IHNpemVzIGFyZSBjb25zb2xpZGF0 ZWQsIEl0IGlzIGFkanVzdGVkIGFjY29yZGluZ2x5IGFzIGJlbG93Lgo+Pgo+PiDCoMKgwqDCoCAv Kgo+PiDCoMKgwqDCoMKgICogV2UgaGF2ZSBkaWZmZXJlbnQgbnVtYmVyIG9mIG1lbW9yeSBzbG90 cywgZXhjbHVkaW5nIHRoZSByZXNlcnZlZAo+PiDCoMKgwqDCoMKgICogbWVtb3J5IHNsb3QgMCwg b24gdmFyaW91cyBhcmNoaXRlY3R1cmVzIGFuZCBjb25maWd1cmF0aW9ucy4gVGhlCj4+IMKgwqDC oMKgwqAgKiBtZW1vcnkgc2l6ZSBpbiB0aGlzIHRlc3QgaXMgY2FsY3VsYXRlZCBieSBkb3VibGlu ZyB0aGUgbWF4aW1hbAo+PiDCoMKgwqDCoMKgICogbWVtb3J5IHNpemUgaW4gbGFzdCBtZW1vcnkg c2xvdCwgd2l0aCBhbGlnbm1lbnQgdG8gdGhlIGxhcmdlc3QKPj4gwqDCoMKgwqDCoCAqIHN1cHBv cnRlZCBwYWdlIHNpemUgKDY0S0IpLgo+PiDCoMKgwqDCoMKgICoKPj4gwqDCoMKgwqDCoCAqIGFy Y2hpdGVjdHVyZcKgwqAgc2xvdHPCoMKgwqAgbWVtb3J5LXBlci1zbG90wqDCoMKgIG1lbW9yeS1v bi1sYXN0LXNsb3QKPj4gwqDCoMKgwqDCoCAqIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+IMKgwqDCoMKgwqAgKiB4ODYtNEtC wqDCoMKgwqDCoMKgwqAgMzI3NjPCoMKgwqAgMTZLQsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgMTYwS0IKPj4gwqDCoMKgwqDCoCAqIGFybTY0LTRLQsKgwqDCoMKgwqAgMzI3NjbCoMKgwqAg MTZLQsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMTEyS0IKPj4gwqDCoMKgwqDCoCAqIGFy bTY0LTY0S0LCoMKgwqDCoCA4MTkywqDCoMKgwqAgNjRLQsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgMTI4S0IKPj4gwqDCoMKgwqDCoCAqLwo+PiDCoMKgwqDCoCAjZGVmaW5lIE1FTV9URVNU X01PVkVfU0laRcKgwqDCoCAweDUwMDAwwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogMzIwS0IgKi8K PiAKPiBOb3cgTUVNX1RFU1RfTU9WRV9TSVpFIGlzIHRvbyBoaWdoIGZvciBhcm02NC00S0IgYW5k IGFybTY0LTY0S0IgY2FzZXMKPiAoaXQgbmVlZHMgMTYwIEtpQiBpbiB0aGUgbGFzdCBzbG90IGJ1 dCBoYXMgbGVzcyBhdmFpbGFibGUgaW4gdGhlc2UgdHdvCj4gY2FzZXMpLgo+IAo+IFVzaW5nIGEg dGVzdCBzaXplIG9mIDE5MiBLaUIgaW5zdGVhZCBzZWVtcyBsaWtlIGEgc21hbGwgZGlmZmVyZW5j ZQo+IGZyb20gdGhlIG9yaWdpbmFsIHNpemUgb2YgMjAwIEtpQiwgd2hpbGUgc3RpbGwgYmVpbmcg YWxpZ25lZCB0bwo+IDY0IEtpQi4KPiAKPiBUaGUgbW92ZSBiZW5jaG1hcmtzIHJ1bnRpbWUgZGlm ZmVyZW5jZSBvbiB4ODYtNEtCIHdpdGggdGhpcyBzaXplCj4gKGNvbXBhcmVkIHRvIHNpemVzIG9m IDIwMCBLaUIgYW5kIDMyMCBLaUIpIHNlZW1zIHRvIGJlIG5lZ2xpZ2libGUuCj4gCj4gU2luY2Ug aXQncyBhbiBvZGQgbnVtYmVyIG9mIDY0IEtpQiBwYWdlcyAoMykgdGhlIGNvZGUgdGhhdCBoYWx2 ZXMKPiB0aGlzIG51bWJlciBvZiBwYWdlcyB3aWxsIG5lZWQgdG8gYmUgYWRqdXN0ZWQgdG8gb3Bl cmF0ZSBvbiByYXcKPiBzaXplcyBpbnN0ZWFkLgo+IAo+IEkgY2FuIHNlZSBhIHNpbmdsZSBibG9j ayBvZiBjb2RlIHRoYXQgd2lsbCBuZWVkIHN1Y2ggYWRqdXN0bWVudDoKPj4gaWYgKGxhc3RwYWdl cyA8IG1vdmVfcGFnZXMgLyAyKSB7Cj4+IMKgwqDCoMKgwqDCoMKgICptYXhzbG90cyA9IDA7Cj4+ IMKgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsKPj4gfSAKPiAKPiBTaW1pbGFyIHJlbWFyayBn b2VzIGZvciB0aGUgY2FzZSAoMSkgYWJvdmUsIHdoZXJlIHlvdSdsbCBwcm9iYWJseSBuZWVkCj4g dG8gdXNlIDY0IEtpQiB0ZXN0IGFyZWEgc2l6ZSAoaXQncyBvbmx5IGFuIGludGVybWVkaWF0ZSBm b3JtIG9mIGNvZGUKPiBiZWZvcmUgdGhlIGZpbmFsIHBhdGNoIGNoYW5nZXMgdGhpcyB2YWx1ZSBz byBpdCdzIGZpbmUgaWYgaXQgZG9lc24ndAo+IHBlcmZvcm0gYXMgd2VsbCBhcyB0aGUgZmluYWwg Zm9ybSBvZiB0aGUgY29kZSkuCj4gCgpNYWNpZWosIGFsbCB5b3VyIGNvbW1lbnRzIG1ha2Ugc2Vu c2UgdG8gbWUuIEl0IHJlYWxseSB0b29rIG1lIHNvbWUgdGltZXMKdG8gZG8gdGhlIGNhbGN1bGF0 aW9uLiBJIGp1c3QgcG9zdGVkIHYzIHRvIGFkZHJlc3MgYWxsIHlvdXIgY29tbWVudHMuCkhvcGVm dWxseSwgdGhlcmUgaXMgbm90aGluZyBtaXNzZWQuIFBsZWFzZSBnbyBhaGVhZCB0byByZXZpZXcg djMgZGlyZWN0bHkKd2hlbiB5b3UgZ2V0IGEgY2hhbmNlLgoKICAgIHYzOiBodHRwczovL2xvcmUu a2VybmVsLm9yZy9rdm1hcm0vMjAyMjEwMjAwNzEyMDkuNTU5MDYyLTEtZ3NoYW5AcmVkaGF0LmNv bS9ULyN0CgpJbiB2MywgdGhlIGNvbW1lbnRzIGFib3V0IE1FTV9URVNUX01PVkVfU0laRSBpcyBm aXhlZCBpbiBQQVRDSFt2MyA0LzZdLApidXQgaXQncyA2NEtCLiBJbiBQQVRDSFt2MyA1LzZdLCBp dCdzIGZpeGVkIHVwIHRvIDE5MktCIGFuZCBtZW1vcnkgc2l6ZQppcyB1c2VkIGZvciB0aGUgY29t cGFyaXNvbiBpbiB0ZXN0X21lbXNsb3RfbW92ZV9wcmVwYXJlKCkuCgpUaGFua3MsCkdhdmluCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1h aWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3Mu Y29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0029723BF for ; Thu, 20 Oct 2022 07:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666250397; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9HqOzVsB8T4yggWYl1bqige06n7AwLzVreZ+LrEySM=; b=KzWb2GdqCw9t6whQCncjrTJ9pC6Gb2HBe7EpSnkOjwQaSyhAcR8aPHbavrnxdaq5OtGFUq y4praoinjLI7y2Ycfhx/VU6ioWwyl5vaEQfM0IidH/5k3XpxHKHWqmHEu26JZvw54+pH2p EkodJhJOPsOGLlBN3C9AHT8U46wY1VA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-339--4tmXxcVONmOztGz3krQ0w-1; Thu, 20 Oct 2022 03:19:54 -0400 X-MC-Unique: -4tmXxcVONmOztGz3krQ0w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDD051C068C9; Thu, 20 Oct 2022 07:19:53 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5A1EC15BA5; Thu, 20 Oct 2022 07:19:45 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH 4/6] KVM: selftests: memslot_perf_test: Support variable guest page size To: "Maciej S. Szmigiero" Cc: kvm@vger.kernel.org, maz@kernel.org, linux-kernel@vger.kernel.org, zhenyzha@redhat.com, shan.gavin@gmail.com, kvmarm@lists.linux.dev, pbonzini@redhat.com, shuah@kernel.org, kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com References: <20221014071914.227134-1-gshan@redhat.com> <20221014071914.227134-5-gshan@redhat.com> <3eecebca-a526-d10a-02d3-496ce919d577@maciej.szmigiero.name> <5bfbe050-a654-8400-e1f1-dcfa4dba13e6@redhat.com> From: Gavin Shan Message-ID: <001d6b60-dc05-370d-5cb3-9f8f855089c3@redhat.com> Date: Thu, 20 Oct 2022 15:19:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Message-ID: <20221020071942.AMA1m8aPgMFdy9grPVc90pTKPswZUNt7s1IhD7I-U1o@z> On 10/20/22 4:18 AM, Maciej S. Szmigiero wrote: > On 19.10.2022 02:26, Gavin Shan wrote: >> On 10/18/22 11:56 PM, Maciej S. Szmigiero wrote: >>> On 18.10.2022 02:51, Gavin Shan wrote: >>>> On 10/18/22 8:46 AM, Gavin Shan wrote: >>>>> On 10/18/22 5:31 AM, Maciej S. Szmigiero wrote: >>>>>> On 14.10.2022 09:19, Gavin Shan wrote: >>>>>>> The test case is obviously broken on aarch64 because non-4KB guest >>>>>>> page size is supported. The guest page size on aarch64 could be 4KB, >>>>>>> 16KB or 64KB. >>>>>>> >>>>>>> This supports variable guest page size, mostly for aarch64. >>>>>>> >>>>>>>    - The host determines the guest page size when virtual machine is >>>>>>>      created. The value is also passed to guest through the synchronization >>>>>>>      area. >>>>>>> >>>>>>>    - The number of guest pages are unknown until the virtual machine >>>>>>>      is to be created. So all the related macros are dropped. Instead, >>>>>>>      their values are dynamically calculated based on the guest page >>>>>>>      size. >>>>>>> >>>>>>>    - The static checks on memory sizes and pages becomes dependent >>>>>>>      on guest page size, which is unknown until the virtual machine >>>>>>>      is about to be created. So all the static checks are converted >>>>>>>      to dynamic checks, done in check_memory_sizes(). >>>>>>> >>>>>>>    - As the address passed to madvise() should be aligned to host page, >>>>>>>      the size of page chunk is automatically selected, other than one >>>>>>>      page. >>>>>>> >>>>>>>    - All other changes included in this patch are almost mechanical >>>>>>>      replacing '4096' with 'guest_page_size'. >>>>>>> >>>>>>> Signed-off-by: Gavin Shan >>>>>>> --- >>>>>>>   .../testing/selftests/kvm/memslot_perf_test.c | 191 +++++++++++------- >>>>>>>   1 file changed, 115 insertions(+), 76 deletions(-) >>>>>>> >>>>>>> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c >>>>>>> index d5aa9148f96f..d587bd952ff9 100644 >>>>>>> --- a/tools/testing/selftests/kvm/memslot_perf_test.c >>>>>>> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c >>> (...) >>>>>>> @@ -77,8 +61,7 @@ static_assert(MEM_TEST_UNMAP_SIZE_PAGES % >>>>>>>    * for the total size of 25 pages. >>>>>>>    * Hence, the maximum size here is 50 pages. >>>>>>>    */ >>>>>>> -#define MEM_TEST_MOVE_SIZE_PAGES    (50) >>>>>>> -#define MEM_TEST_MOVE_SIZE        (MEM_TEST_MOVE_SIZE_PAGES * 4096) >>>>>>> +#define MEM_TEST_MOVE_SIZE        0x32000 >>>>>> >>>>>> The above number seems less readable than an explicit value of 50 pages. >>>>>> >>>>>> In addition to that, it's 50 pages only with 4k page size, so at least >>>>>> the comment above needs to be updated to reflect this fact. >>>>>> >>>>> >>>>> Yeah, I will change the comments like below in next revision. >>>>> >>>>>   /* >>>>>    * When running this test with 32k memslots, actually 32763 excluding >>>>>    * the reserved memory slot 0, the memory for each slot is 0x4000 bytes. >>>>>    * The last slot contains 0x19000 bytes memory. Hence, the maximum size >>>>>    * here is 0x32000 bytes. >>>>>    */ >>>>> >>>> >>>> I will replace those numbers with readable ones like below :) >>>> >>>> /* >>>>   * When running this test with 32k memslots, actually 32763 excluding >>>>   * the reserved memory slot 0, the memory for each slot is 16KB. The >>>>   * last slot contains 100KB memory with the remaining 84KB. Hence, >>>>   * the maximum size is double of that (200KB) >>>>   */ >>> >>> Still, these numbers are for x86, which has KVM_INTERNAL_MEM_SLOTS >>> defined as 3. >>> >>> As far as I can see aarch64 has KVM_INTERNAL_MEM_SLOTS equal to 0, so >>> this arch has 32766 slot available for the test memory. >>> >>> Quick calculations show that this will result in 112 KiB of memory in >>> the last slot for 4 KiB page size (while for 64 KiB page size the >>> maximum slot count for this test is 8192 anyway - not counting slot 0). >>> >> >> It seems your calculation had (512MB+64KB), instead of (512MB+4KB). >> In this particular patch, we still have (512MB+4KB). How about to change >> like below in this patch. In next patch, it's adjusted accordingly after >> we have (512MB+64KB). > > My review comment above referred to the final MEM_SIZE value after the > whole series, so 512 MiB + 64 KiB. > > I placed that review comment on patch 4 since it's the only patch in this > series that modified the code comment about MEM_TEST_MOVE_SIZE. > >> >> (1) In this patch, the comment is changed to as below >> >>      /* >>       * We have different number of memory slots, excluding the reserved >>       * memory slot 0, on various architectures and configurations. The >>       * memory size in this test is calculated by doubling the maximal >>       * memory size in last memory slot, with alignment to the largest >>       * supported page size (64KB). >>       * >>       * architecture   slots    memory-per-slot    memory-on-last-slot >>       * -------------------------------------------------------------- >>       * x86-4KB        32763    16KB               100KB >>       * arm64-4KB      32766    16KB               52KB >>       * arm64-64KB     8192     64KB               64KB >>       */ >>      #define MEM_TEST_MOVE_SIZE    0x40000           /* 256KB */ >> >> (2) In the next patch, where we have (512MB+64KB) after the various >>      memory sizes are consolidated, It is adjusted accordingly as below. >> >>      /* >>       * We have different number of memory slots, excluding the reserved >>       * memory slot 0, on various architectures and configurations. The >>       * memory size in this test is calculated by doubling the maximal >>       * memory size in last memory slot, with alignment to the largest >>       * supported page size (64KB). >>       * >>       * architecture   slots    memory-per-slot    memory-on-last-slot >>       * -------------------------------------------------------------- >>       * x86-4KB        32763    16KB               160KB >>       * arm64-4KB      32766    16KB               112KB >>       * arm64-64KB     8192     64KB               128KB >>       */ >>      #define MEM_TEST_MOVE_SIZE    0x50000           /* 320KB */ > > Now MEM_TEST_MOVE_SIZE is too high for arm64-4KB and arm64-64KB cases > (it needs 160 KiB in the last slot but has less available in these two > cases). > > Using a test size of 192 KiB instead seems like a small difference > from the original size of 200 KiB, while still being aligned to > 64 KiB. > > The move benchmarks runtime difference on x86-4KB with this size > (compared to sizes of 200 KiB and 320 KiB) seems to be negligible. > > Since it's an odd number of 64 KiB pages (3) the code that halves > this number of pages will need to be adjusted to operate on raw > sizes instead. > > I can see a single block of code that will need such adjustment: >> if (lastpages < move_pages / 2) { >>         *maxslots = 0; >>         return false; >> } > > Similar remark goes for the case (1) above, where you'll probably need > to use 64 KiB test area size (it's only an intermediate form of code > before the final patch changes this value so it's fine if it doesn't > perform as well as the final form of the code). > Maciej, all your comments make sense to me. It really took me some times to do the calculation. I just posted v3 to address all your comments. Hopefully, there is nothing missed. Please go ahead to review v3 directly when you get a chance. v3: https://lore.kernel.org/kvmarm/20221020071209.559062-1-gshan@redhat.com/T/#t In v3, the comments about MEM_TEST_MOVE_SIZE is fixed in PATCH[v3 4/6], but it's 64KB. In PATCH[v3 5/6], it's fixed up to 192KB and memory size is used for the comparison in test_memslot_move_prepare(). Thanks, Gavin