kvmarm.lists.cs.columbia.edu archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: arm64: Drop 'const' from argument of vq_present()
@ 2019-06-04  4:43 Viresh Kumar
  2019-06-04  8:30 ` Marc Zyngier
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Viresh Kumar @ 2019-06-04  4:43 UTC (permalink / raw)
  To: Dave Martin, Marc Zyngier, James Morse, Julien Thierry,
	Suzuki K Pouloze, Catalin Marinas, Will Deacon
  Cc: Viresh Kumar, Vincent Guittot, kvmarm, linux-arm-kernel, linux-kernel

We currently get following compilation warning:

arch/arm64/kvm/guest.c: In function 'set_sve_vls':
arch/arm64/kvm/guest.c:262:18: warning: passing argument 1 of 'vq_present' from incompatible pointer type
arch/arm64/kvm/guest.c:212:13: note: expected 'const u64 (* const)[8]' but argument is of type 'u64 (*)[8]'

The argument can't be const, as it is copied at runtime using
copy_from_user(). Drop const from the prototype of vq_present().

Fixes: 9033bba4b535 ("KVM: arm64/sve: Add pseudo-register for the guest's vector lengths")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 arch/arm64/kvm/guest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c
index 3ae2f82fca46..78f5a4f45e0a 100644
--- a/arch/arm64/kvm/guest.c
+++ b/arch/arm64/kvm/guest.c
@@ -209,7 +209,7 @@ static int set_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
 #define vq_mask(vq) ((u64)1 << ((vq) - SVE_VQ_MIN) % 64)
 
 static bool vq_present(
-	const u64 (*const vqs)[KVM_ARM64_SVE_VLS_WORDS],
+	u64 (*const vqs)[KVM_ARM64_SVE_VLS_WORDS],
 	unsigned int vq)
 {
 	return (*vqs)[vq_word(vq)] & vq_mask(vq);
-- 
2.21.0.rc0.269.g1a574e7a288b

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-06-07 14:42 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04  4:43 [PATCH] KVM: arm64: Drop 'const' from argument of vq_present() Viresh Kumar
2019-06-04  8:30 ` Marc Zyngier
2019-06-04  8:39   ` Viresh Kumar
2019-06-04  8:43 ` Catalin Marinas
2019-06-04  8:55   ` Viresh Kumar
2019-06-04  9:26     ` Dave Martin
2019-06-04  9:31       ` Viresh Kumar
2019-06-04  9:57         ` Dave Martin
2019-06-04  9:01   ` Marc Zyngier
2019-06-04  9:59 ` Dave Martin
2019-06-07  6:00   ` Viresh Kumar
2019-06-07 14:42     ` Dave Martin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).