From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Drop 'const' from argument of vq_present()
Date: Tue, 4 Jun 2019 15:01:53 +0530 [thread overview]
Message-ID: <20190604093153.2pzv55knl6axugrv@vireshk-i7> (raw)
In-Reply-To: <20190604092639.GS28398@e103592.cambridge.arm.com>
On 04-06-19, 10:26, Dave Martin wrote:
> I'm in two minds about whether this is worth fixing, but if you want to
> post a patch to remove the extra const (or convert vq_present() to a
> macro), I'll take a look at it.
This patch already does what you are asking for (remove the extra
const), isn't it ?
I looked at my textbook (The C programming Language, By Brian W.
Kernighan and Dennis M. Ritchie.) and it says:
"
The const declaration can also be used with array arguments, to
indicate that the function does not change that array:
int strlen(const char[]);
"
and so this patch isn't necessary for sure.
--
viresh
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-06-04 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 4:43 [PATCH] KVM: arm64: Drop 'const' from argument of vq_present() Viresh Kumar
2019-06-04 8:30 ` Marc Zyngier
2019-06-04 8:39 ` Viresh Kumar
2019-06-04 8:43 ` Catalin Marinas
2019-06-04 8:55 ` Viresh Kumar
2019-06-04 9:26 ` Dave Martin
2019-06-04 9:31 ` Viresh Kumar [this message]
2019-06-04 9:57 ` Dave Martin
2019-06-04 9:01 ` Marc Zyngier
2019-06-04 9:59 ` Dave Martin
2019-06-07 6:00 ` Viresh Kumar
2019-06-07 14:42 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604093153.2pzv55knl6axugrv@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).