KVM ARM Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
	James Hogan <jhogan@kernel.org>, Joerg Roedel <joro@8bytes.org>,
	David Hildenbrand <david@redhat.com>,
	linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	kvmarm@lists.cs.columbia.edu, Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH 10/13] KVM: Provide common implementation for generic dirty log functions
Date: Thu, 19 Sep 2019 10:22:42 +1000
Message-ID: <20190919002242.GA19503@blackberry> (raw)
In-Reply-To: <20190911185038.24341-11-sean.j.christopherson@intel.com>

On Wed, Sep 11, 2019 at 11:50:35AM -0700, Sean Christopherson wrote:
> Move the implementations of KVM_GET_DIRTY_LOG and KVM_CLEAR_DIRTY_LOG
> The arch specific implemenations are extremely similar, differing
> only in whether the dirty log needs to be sync'd from hardware (x86)
> and how the TLBs are flushed.  Add new arch hooks to handle sync
> and TLB flush; the sync will also be used for non-generic dirty log
> support in a future patch (s390).
> The ulterior motive for providing a common implementation is to
> eliminate the dependency between arch and common code with respect to
> the memslot referenced by the dirty log, i.e. to make it obvious in the
> code that the validity of the memslot is guaranteed, as a future patch
> will rework memslot handling such that id_to_memslot() can return NULL.

I notice you add empty definitions of kvm_arch_sync_dirty_log() for
PPC, both Book E and Book 3S.  Given that PPC doesn't select

kvmarm mailing list

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 18:50 [PATCH 00/13] KVM: Dynamically size memslot arrays Sean Christopherson
2019-09-11 18:50 ` [PATCH 01/13] KVM: Reinstall old memslots if arch preparation fails Sean Christopherson
2019-09-11 18:50 ` [PATCH 02/13] KVM: PPC: Move memslot memory allocation into prepare_memory_region() Sean Christopherson
2019-09-19  0:23   ` Paul Mackerras
2019-09-11 18:50 ` [PATCH 03/13] KVM: x86: Allocate memslot resources during prepare_memory_region() Sean Christopherson
2019-09-11 18:50 ` [PATCH 04/13] KVM: Drop kvm_arch_create_memslot() Sean Christopherson
2019-09-12 11:31   ` Janosch Frank
2019-09-11 18:50 ` [PATCH 05/13] KVM: Refactor error handling for setting memory region Sean Christopherson
2019-09-12 11:36   ` Janosch Frank
2019-09-11 18:50 ` [PATCH 06/13] KVM: Move setting of memslot into helper routine Sean Christopherson
2019-09-11 18:50 ` [PATCH 07/13] KVM: Move memslot deletion to helper function Sean Christopherson
2019-09-11 18:50 ` [PATCH 08/13] KVM: Simplify kvm_free_memslot() and all its descendents Sean Christopherson
2019-09-11 18:50 ` [PATCH 09/13] KVM: Clean up local variable usage in __kvm_set_memory_region() Sean Christopherson
2019-09-11 18:50 ` [PATCH 10/13] KVM: Provide common implementation for generic dirty log functions Sean Christopherson
2019-09-19  0:22   ` Paul Mackerras [this message]
2019-09-19 19:39     ` Sean Christopherson
2019-09-11 18:50 ` [PATCH 11/13] KVM: Ensure validity of memslot with respect to kvm_get_dirty_log() Sean Christopherson
2019-09-11 18:50 ` [PATCH 12/13] KVM: Terminate memslot walks via used_slots Sean Christopherson
2019-09-11 18:50 ` [PATCH 13/13] KVM: Dynamically size memslot array based on number of used slots Sean Christopherson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919002242.GA19503@blackberry \
    --to=paulus@ozlabs.org \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=jhogan@kernel.org \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

KVM ARM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvmarm/0 kvmarm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvmarm kvmarm/ https://lore.kernel.org/kvmarm \
		kvmarm@lists.cs.columbia.edu kvmarm@archiver.kernel.org
	public-inbox-index kvmarm

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/ public-inbox