From: Andre Przywara <andre.przywara@arm.com> To: Andrew Jones <drjones@redhat.com>, Paolo Bonzini <pbonzini@redhat.com> Cc: Marc Zyngier <maz@kernel.org>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 00/17] arm: gic: Test SPIs and interrupt groups Date: Fri, 8 Nov 2019 14:42:23 +0000 Message-ID: <20191108144240.204202-1-andre.przywara@arm.com> (raw) So far the GIC testing was limited: we were only testing some MMIO properties on a GICv2 and some IPI behaviour. This series extends this to cover SPIs as well, also testing the behaviour with the two interrupt groups the emulated GIC provides to us. The first patch is an easy extension to allow some distributor MMIO tests on GICv3 guests as well. Patch 2 - 5 prepare the GIC testing framework to handle SPIs, also to be able to check for interrupts *not* firing. This is used in patch 6, which adds an IRQ test by using a software triggered SPI. This also tests whether interrupt masking works, at least using one of the many masking methods. Patch 8 adds a test to cover multiple cores, to test the interrupt target settings. Patch 7 avoids unneccesary output when triggering one IRQ multiple times. The remainder of the patches add code to differentiate the two interrupt groups that the GIC provides. On bare-metal machines, typically having some secure world code running, and using the typical dual-security-state GIC configuration, we only ever have one group (group 1) available, so Linux won't use this feature. However our emulated GIC does not have a secure side (as we are running in at most EL2), so both interrupt groups are available to a guest. So the patches add support to program interrupts to belong to one or another group, also program the virtual GIC to deliver group 0 interrupts as FIQs, and group 1 interrupts as IRQs. We then do some tests to see whether this setup works as expected. At the moment only QEMU using TCG passes these tests, the KVM VGIC emulation fails to handle the group enable bits properly. Patches for the kernel will be send shortly, this series acts as a verification test for this feature (as normal world OSes won't probably use two groups). Please have a look and comment. I am not particularly happy with patch 16, thrilled to hear any suggestions on how to handle this better. Tested on arm/GICv2, arm64/GICv2 and arm64/GICv3, with and without the corresponding KVM patches to fix the dual-group behaviour. Cheers, Andre Andre Przywara (17): arm: gic: Enable GIC MMIO tests for GICv3 as well arm: gic: Generalise function names arm: gic: Provide per-IRQ helper functions arm: gic: Support no IRQs test case arm: gic: Prepare IRQ handler for handling SPIs arm: gic: Add simple shared IRQ test arm: gic: Extend check_acked() to allow silent call arm: gic: Add simple SPI MP test arm: gic: Add test for flipping GICD_CTLR.DS arm: gic: Check for writable IGROUPR registers arm: gic: Check for validity of both group enable bits arm: gic: Change gic_read_iar() to take group parameter arm: gic: Change write_eoir() to take group parameter arm: gic: Prepare for receiving GIC group 0 interrupts via FIQs arm: gic: Provide FIQ handler arm: gic: Prepare interrupt statistics for both groups arm: gic: Test Group0 SPIs arm/gic.c | 468 ++++++++++++++++++++++++++++++++----- arm/micro-bench.c | 6 +- arm/pl031.c | 4 +- arm/timer.c | 4 +- arm/unittests.cfg | 38 ++- lib/arm/asm/arch_gicv3.h | 26 ++- lib/arm/asm/gic-v2.h | 11 +- lib/arm/asm/gic-v3.h | 12 +- lib/arm/asm/gic.h | 13 +- lib/arm/asm/processor.h | 10 + lib/arm/gic-v2.c | 39 +++- lib/arm/gic-v3.c | 2 +- lib/arm/gic.c | 102 +++++++- lib/arm64/asm/arch_gicv3.h | 29 ++- lib/arm64/asm/processor.h | 10 + lib/arm64/processor.c | 2 + 16 files changed, 685 insertions(+), 91 deletions(-) -- 2.17.1 _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next reply index Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-08 14:42 Andre Przywara [this message] 2019-11-08 14:42 ` [kvm-unit-tests PATCH 01/17] arm: gic: Enable GIC MMIO tests for GICv3 as well Andre Przywara 2019-11-08 17:28 ` Alexandru Elisei 2019-11-12 12:49 ` Auger Eric 2019-11-08 14:42 ` [kvm-unit-tests PATCH 02/17] arm: gic: Generalise function names Andre Przywara 2019-11-12 11:11 ` Alexandru Elisei 2019-11-12 12:49 ` Auger Eric 2019-11-08 14:42 ` [kvm-unit-tests PATCH 03/17] arm: gic: Provide per-IRQ helper functions Andre Przywara 2019-11-12 12:51 ` Alexandru Elisei 2019-11-12 15:53 ` Auger Eric 2019-11-12 16:53 ` Alexandru Elisei 2019-11-12 13:49 ` Auger Eric 2019-11-08 14:42 ` [kvm-unit-tests PATCH 04/17] arm: gic: Support no IRQs test case Andre Przywara 2019-11-12 13:26 ` Alexandru Elisei 2019-11-12 21:14 ` Auger Eric 2019-11-08 14:42 ` [kvm-unit-tests PATCH 05/17] arm: gic: Prepare IRQ handler for handling SPIs Andre Przywara 2019-11-12 13:36 ` Alexandru Elisei 2019-11-12 20:56 ` Auger Eric 2019-11-08 14:42 ` [kvm-unit-tests PATCH 06/17] arm: gic: Add simple shared IRQ test Andre Przywara 2019-11-12 13:54 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 07/17] arm: gic: Extend check_acked() to allow silent call Andre Przywara 2019-11-12 15:23 ` Alexandru Elisei 2019-11-14 12:32 ` Andrew Jones 2019-11-15 11:32 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 08/17] arm: gic: Add simple SPI MP test Andre Przywara 2019-11-12 15:41 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 09/17] arm: gic: Add test for flipping GICD_CTLR.DS Andre Przywara 2019-11-12 16:42 ` Alexandru Elisei 2019-11-14 13:39 ` Vladimir Murzin 2019-11-14 14:17 ` Andre Przywara 2019-11-14 14:50 ` Vladimir Murzin 2019-11-14 15:21 ` Alexandru Elisei 2019-11-14 15:27 ` Peter Maydell 2019-11-14 15:47 ` Alexandru Elisei 2019-11-14 15:56 ` Peter Maydell 2019-11-08 14:42 ` [kvm-unit-tests PATCH 10/17] arm: gic: Check for writable IGROUPR registers Andre Przywara 2019-11-12 16:51 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 11/17] arm: gic: Check for validity of both group enable bits Andre Przywara 2019-11-12 16:58 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 12/17] arm: gic: Change gic_read_iar() to take group parameter Andre Przywara 2019-11-12 17:19 ` Alexandru Elisei 2019-11-14 12:50 ` Andrew Jones 2019-11-08 14:42 ` [kvm-unit-tests PATCH 13/17] arm: gic: Change write_eoir() " Andre Przywara 2019-11-08 14:42 ` [kvm-unit-tests PATCH 14/17] arm: gic: Prepare for receiving GIC group 0 interrupts via FIQs Andre Przywara 2019-11-12 17:30 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 15/17] arm: gic: Provide FIQ handler Andre Przywara 2019-11-13 10:14 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 16/17] arm: gic: Prepare interrupt statistics for both groups Andre Przywara 2019-11-13 10:44 ` Alexandru Elisei 2019-11-08 14:42 ` [kvm-unit-tests PATCH 17/17] arm: gic: Test Group0 SPIs Andre Przywara 2019-11-13 11:26 ` Alexandru Elisei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108144240.204202-1-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=drjones@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maz@kernel.org \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM ARM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvmarm/0 kvmarm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvmarm kvmarm/ https://lore.kernel.org/kvmarm \ kvmarm@lists.cs.columbia.edu public-inbox-index kvmarm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/edu.columbia.cs.lists.kvmarm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git