From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D189EC2BA1A for ; Fri, 24 Apr 2020 08:41:01 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 569A320728 for ; Fri, 24 Apr 2020 08:41:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Vqcjhokd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 569A320728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EF0A34B20C; Fri, 24 Apr 2020 04:41:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ekGwSDLj31NN; Fri, 24 Apr 2020 04:41:00 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0760A4B187; Fri, 24 Apr 2020 04:41:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BB5414B187 for ; Fri, 24 Apr 2020 04:40:58 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k0HGdNbpD+ST for ; Fri, 24 Apr 2020 04:40:57 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D1D774B185 for ; Fri, 24 Apr 2020 04:40:57 -0400 (EDT) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E6F420728; Fri, 24 Apr 2020 08:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587717656; bh=us+cckoY3UvgSdl2gPr8eg5gI2fu/T9757R6fhdxq84=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vqcjhokd+twfLjU9qHCknuOKxiUaqmabSaahgo6Atxa7Nji9kjc44PpG05phFmJpr fljMiTbcMAr42S+2AXhI+ea12pJTBtFMfCHAOm0nEIMSq2Fe48wsC4EVivcVMMfPqK ePiv9axjwN/eLot213Q3ouLMM0j3ITrlyk6mplpg= Date: Fri, 24 Apr 2020 09:40:51 +0100 From: Will Deacon To: Andre Przywara Subject: Re: [PATCH kvmtool v4 0/5] Add CFI flash emulation Message-ID: <20200424084051.GA20801@willie-the-truck> References: <20200423173844.24220-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200423173844.24220-1-andre.przywara@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kvm@vger.kernel.org, Ard Biesheuvel , Raphael Gault , Sami Mujawar , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Apr 23, 2020 at 06:38:39PM +0100, Andre Przywara wrote: > an update for the CFI flash emulation, addressing Alex' comments and > adding direct mapping support. > The actual code changes to the flash emulation are minimal, mostly this > is about renaming and cleanups. > This versions now adds some patches. 1/5 is a required fix, the last > three patches add mapping support as an extension. See below. Cheers, this mostly looks good to me. I've left a couple of minor comments, and I'll give Alexandru a chance to have another look, but hopefully we can merge it soon. Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm