From: Andrew Jones <drjones@redhat.com> To: Jingyi Wang <wangjingyi11@huawei.com> Cc: kvm@vger.kernel.org, maz@kernel.org, prime.zeng@hisilicon.com, kvmarm@lists.cs.columbia.edu Subject: Re: [kvm-unit-tests PATCH v3 07/10] arm64: microbench: Add time limit for each individual test Date: Sat, 1 Aug 2020 18:13:41 +0200 [thread overview] Message-ID: <20200801161341.cjaqe7tkw2y7uxjm@kamzik.brq.redhat.com> (raw) In-Reply-To: <20200731074244.20432-8-wangjingyi11@huawei.com> On Fri, Jul 31, 2020 at 03:42:41PM +0800, Jingyi Wang wrote: > Besides using separate running times parameter, we add time limit > for loop_test to make sure each test should be done in a certain > time(5 sec here). > > Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com> > Reviewed-by: Eric Auger <eric.auger@redhat.com> > --- > arm/micro-bench.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/arm/micro-bench.c b/arm/micro-bench.c > index 93bd855..09d9d53 100644 > --- a/arm/micro-bench.c > +++ b/arm/micro-bench.c > @@ -22,6 +22,7 @@ > #include <asm/gic.h> > #include <asm/gic-v3-its.h> > > +#define NS_5_SECONDS (5 * 1000 * 1000 * 1000UL) > static u32 cntfrq; > > static volatile bool irq_ready, irq_received; > @@ -267,23 +268,26 @@ static void loop_test(struct exit_test *test) > uint64_t start, end, total_ticks, ntimes = 0; > struct ns_time total_ns, avg_ns; > > + total_ticks = 0; > if (test->prep) { > if(!test->prep()) { > printf("%s test skipped\n", test->name); > return; > } > } > - isb(); > - start = read_sysreg(cntpct_el0); > - while (ntimes < test->times) { > + > + while (ntimes < test->times && total_ns.ns < NS_5_SECONDS) { total_ns.ns is now being used uninitialized here. It needs to be initialized to zero above with total_ns = {}. I'll do this fixup myself. Thanks, drew > + isb(); > + start = read_sysreg(cntpct_el0); > test->exec(); > + isb(); > + end = read_sysreg(cntpct_el0); > + > ntimes++; > + total_ticks += (end - start); > + ticks_to_ns_time(total_ticks, &total_ns); > } > - isb(); > - end = read_sysreg(cntpct_el0); > > - total_ticks = end - start; > - ticks_to_ns_time(total_ticks, &total_ns); > avg_ns.ns = total_ns.ns / ntimes; > avg_ns.ns_frac = total_ns.ns_frac / ntimes; > > -- > 2.19.1 > > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-08-01 16:14 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-31 7:42 [kvm-unit-tests PATCH v3 00/10] arm/arm64: Add IPI/LPI/vtimer latency test Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 01/10] arm64: microbench: get correct ipi received num Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 02/10] arm64: microbench: Generalize ipi test names Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 03/10] arm64: microbench: gic: Add ipi latency test for gicv4.1 support kvm Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 04/10] arm64: its: Handle its command queue wrapping Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 05/10] arm64: microbench: its: Add LPI latency test Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 06/10] arm64: microbench: Allow each test to specify its running times Jingyi Wang 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 07/10] arm64: microbench: Add time limit for each individual test Jingyi Wang 2020-08-01 16:13 ` Andrew Jones [this message] 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 08/10] arm64: microbench: Add vtimer latency test Jingyi Wang 2020-08-01 16:22 ` Andrew Jones 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 09/10] arm64: microbench: Add test->post() to further process test results Jingyi Wang 2020-08-01 17:03 ` Andrew Jones 2020-07-31 7:42 ` [kvm-unit-tests PATCH v3 10/10] arm64: microbench: Add timer_post() to get actual PPI latency Jingyi Wang 2020-07-31 12:01 ` [kvm-unit-tests PATCH v3 00/10] arm/arm64: Add IPI/LPI/vtimer latency test Andrew Jones 2020-08-03 2:15 ` Jingyi Wang 2020-08-01 17:40 ` Andrew Jones 2020-08-05 11:54 ` Jingyi Wang 2020-08-05 12:13 ` Marc Zyngier 2020-08-11 1:48 ` Jingyi Wang 2020-08-11 7:49 ` Marc Zyngier 2020-08-17 1:46 ` Jingyi Wang 2020-08-17 8:26 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200801161341.cjaqe7tkw2y7uxjm@kamzik.brq.redhat.com \ --to=drjones@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=maz@kernel.org \ --cc=prime.zeng@hisilicon.com \ --cc=wangjingyi11@huawei.com \ --subject='Re: [kvm-unit-tests PATCH v3 07/10] arm64: microbench: Add time limit for each individual test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).