Re: [kvm-unit-tests PATCH v3 09/10] arm64: microbench: Add test->post() to further process test results

[Andrew Jones <drjones@redhat.com>]

On Fri, Jul 31, 2020 at 03:42:43PM +0800, Jingyi Wang wrote:
> Under certain circumstances, we need to further process microbench
> test results, so we add test->post() in the microbench framework,
> later patch will use that.
> 
> Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com>
> ---
>  arm/micro-bench.c | 31 ++++++++++++++++++-------------
>  1 file changed, 18 insertions(+), 13 deletions(-)
> 
> diff --git a/arm/micro-bench.c b/arm/micro-bench.c
> index 1e1bde5..4680ba4 100644
> --- a/arm/micro-bench.c
> +++ b/arm/micro-bench.c
> @@ -33,6 +33,12 @@ static int nr_ipi_received;
>  static void *vgic_dist_base;
>  static void (*write_eoir)(u32 irqstat);
>  
> +struct ns_time {
> +	uint64_t ns;
> +	uint64_t ns_frac;
> +};

Missing blank line

> +static void ticks_to_ns_time(uint64_t ticks, struct ns_time *ns_time);

You could have moved the whole function up here.

> +
>  static void gic_irq_handler(struct pt_regs *regs)
>  {
>  	u32 irqstat = gic_read_iar();
> @@ -283,24 +289,20 @@ struct exit_test {
>  	const char *name;
>  	bool (*prep)(void);
>  	void (*exec)(void);
> +	void (*post)(uint64_t, uint64_t, struct ns_time*);
>  	u32 times;
>  	bool run;
>  };
>  
>  static struct exit_test tests[] = {
> -	{"hvc",			NULL,		hvc_exec,		65536,		true},
> -	{"mmio_read_user",	NULL,		mmio_read_user_exec,	65536,		true},
> -	{"mmio_read_vgic",	NULL,		mmio_read_vgic_exec,	65536,		true},
> -	{"eoi",			NULL,		eoi_exec,		65536,		true},
> -	{"ipi",			ipi_prep,	ipi_exec,		65536,		true},
> -	{"ipi_hw",		ipi_hw_prep,	ipi_exec,		65536,		true},
> -	{"lpi",			lpi_prep,	lpi_exec,		65536,		true},
> -	{"timer_10ms",		timer_prep,	timer_exec,		256,		true},
> -};
> -
> -struct ns_time {
> -	uint64_t ns;
> -	uint64_t ns_frac;
> +	{"hvc",			NULL,		hvc_exec,		NULL,		65536,		true},
> +	{"mmio_read_user",	NULL,		mmio_read_user_exec,	NULL,		65536,		true},
> +	{"mmio_read_vgic",	NULL,		mmio_read_vgic_exec,	NULL,		65536,		true},
> +	{"eoi",			NULL,		eoi_exec,		NULL,		65536,		true},
> +	{"ipi",			ipi_prep,	ipi_exec,		NULL,		65536,		true},
> +	{"ipi_hw",		ipi_hw_prep,	ipi_exec,		NULL,		65536,		true},
> +	{"lpi",			lpi_prep,	lpi_exec,		NULL,		65536,		true},
> +	{"timer_10ms",		timer_prep,	timer_exec,		NULL,		256,		true},
>  };
>  
>  #define PS_PER_SEC (1000 * 1000 * 1000 * 1000UL)
> @@ -339,6 +341,9 @@ static void loop_test(struct exit_test *test)
>  		ticks_to_ns_time(total_ticks, &total_ns);
>  	}
>  
> +	if (test->post)
> +		test->post(total_ticks, ntimes, &total_ns);
> +

We can drop the ns_time structure and pass total_ticks by reference.

>  	avg_ns.ns = total_ns.ns / ntimes;
>  	avg_ns.ns_frac = total_ns.ns_frac / ntimes;
>  
> -- 
> 2.19.1
> 
>

I can do these changes myself.

Thanks,
drew

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm