From: Ricardo Koller <ricarkol@google.com>
To: kvm@vger.kernel.org, maz@kernel.org,
kvmarm@lists.cs.columbia.edu, drjones@redhat.com,
eric.auger@redhat.com, alexandru.elisei@arm.com
Cc: pshier@google.com, Paolo Bonzini <pbonzini@redhat.com>, shuah@kernel.org
Subject: [PATCH v2 0/2] KVM: arm64: vgic-v3: Missing check for redist region above the VM IPA size
Date: Thu, 9 Sep 2021 17:49:17 -0700 [thread overview]
Message-ID: <20210910004919.1610709-1-ricarkol@google.com> (raw)
KVM doesn't check for redist regions that extend partially above the
VM-specified IPA (phys_size). This can happen when using the
KVM_VGIC_V3_ADDR_TYPE_REDIST or KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION attribute
to set a new region that extends partially above phys_size (with the base below
phys_size). The issue is that vcpus can potentially run into a situation where
some redistributors are addressable and others are not.
Patch 1 adds the missing checks, and patch 2 adds a test into aarch64/vgic_init.
Changes:
v2: adding a test for KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION, and returning E2BIG
instead of EINVAL (thanks Alexandru and Eric).
Ricardo Koller (2):
KVM: arm64: vgic: check redist region is not above the VM IPA size
KVM: arm64: selftests: tests for vgic redist regions above the VM IPA
size
arch/arm64/kvm/vgic/vgic-mmio-v3.c | 7 ++-
arch/arm64/kvm/vgic/vgic-v3.c | 4 ++
.../testing/selftests/kvm/aarch64/vgic_init.c | 52 +++++++++++++++++++
3 files changed, 62 insertions(+), 1 deletion(-)
--
2.33.0.309.g3052b89438-goog
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next reply other threads:[~2021-09-10 0:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 0:49 Ricardo Koller [this message]
2021-09-10 0:49 ` [PATCH v2 1/2] KVM: arm64: vgic: check redist region is not above the VM IPA size Ricardo Koller
2021-09-20 12:30 ` Marc Zyngier
2021-09-20 21:06 ` Ricardo Koller
2021-09-10 0:49 ` [PATCH v2 2/2] KVM: arm64: selftests: tests for vgic redist regions " Ricardo Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910004919.1610709-1-ricarkol@google.com \
--to=ricarkol@google.com \
--cc=alexandru.elisei@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).