From: Ricardo Koller <ricarkol@google.com>
To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
andrew.jones@linux.dev
Cc: maz@kernel.org
Subject: [kvm-unit-tests PATCH v3 1/3] arm: pmu: Add missing isb()'s after sys register writing
Date: Thu, 4 Aug 2022 17:41:37 -0700 [thread overview]
Message-ID: <20220805004139.990531-2-ricarkol@google.com> (raw)
In-Reply-To: <20220805004139.990531-1-ricarkol@google.com>
There are various pmu tests that require an isb() between enabling
counting and the actual counting. This can lead to count registers
reporting less events than expected; the actual enabling happens after
some events have happened. For example, some missing isb()'s in the
pmu-sw-incr test lead to the following errors on bare-metal:
INFO: pmu: pmu-sw-incr: SW_INCR counter #0 has value 4294967280
PASS: pmu: pmu-sw-incr: PWSYNC does not increment if PMCR.E is unset
FAIL: pmu: pmu-sw-incr: counter #1 after + 100 SW_INCR
FAIL: pmu: pmu-sw-incr: counter #0 after + 100 SW_INCR
INFO: pmu: pmu-sw-incr: counter values after 100 SW_INCR #0=82 #1=98
PASS: pmu: pmu-sw-incr: overflow on counter #0 after 100 SW_INCR
SUMMARY: 4 tests, 2 unexpected failures
Add the missing isb()'s on all failing tests, plus some others that seem
required:
- after clearing the overflow signal in the IRQ handler to make spurious
interrupts less likely.
- after direct writes to PMSWINC_EL0 for software to read the correct
value for PMEVNCTR0_EL0 (from ARM DDI 0487H.a, page D13-5237).
Signed-off-by: Ricardo Koller <ricarkol@google.com>
---
arm/pmu.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arm/pmu.c b/arm/pmu.c
index 15c542a2..4c601b05 100644
--- a/arm/pmu.c
+++ b/arm/pmu.c
@@ -307,6 +307,7 @@ static void irq_handler(struct pt_regs *regs)
}
}
write_sysreg(ALL_SET, pmovsclr_el0);
+ isb();
} else {
pmu_stats.unexpected = true;
}
@@ -534,10 +535,12 @@ static void test_sw_incr(void)
write_sysreg_s(0x3, PMCNTENSET_EL0);
write_regn_el0(pmevcntr, 0, PRE_OVERFLOW);
+ isb();
for (i = 0; i < 100; i++)
write_sysreg(0x1, pmswinc_el0);
+ isb();
report_info("SW_INCR counter #0 has value %ld", read_regn_el0(pmevcntr, 0));
report(read_regn_el0(pmevcntr, 0) == PRE_OVERFLOW,
"PWSYNC does not increment if PMCR.E is unset");
@@ -547,10 +550,12 @@ static void test_sw_incr(void)
write_regn_el0(pmevcntr, 0, PRE_OVERFLOW);
write_sysreg_s(0x3, PMCNTENSET_EL0);
set_pmcr(pmu.pmcr_ro | PMU_PMCR_E);
+ isb();
for (i = 0; i < 100; i++)
write_sysreg(0x3, pmswinc_el0);
+ isb();
report(read_regn_el0(pmevcntr, 0) == 84, "counter #1 after + 100 SW_INCR");
report(read_regn_el0(pmevcntr, 1) == 100,
"counter #0 after + 100 SW_INCR");
@@ -618,9 +623,12 @@ static void test_chained_sw_incr(void)
write_regn_el0(pmevcntr, 0, PRE_OVERFLOW);
set_pmcr(pmu.pmcr_ro | PMU_PMCR_E);
+ isb();
+
for (i = 0; i < 100; i++)
write_sysreg(0x1, pmswinc_el0);
+ isb();
report(!read_sysreg(pmovsclr_el0) && (read_regn_el0(pmevcntr, 1) == 1),
"no overflow and chain counter incremented after 100 SW_INCR/CHAIN");
report_info("overflow=0x%lx, #0=%ld #1=%ld", read_sysreg(pmovsclr_el0),
@@ -634,9 +642,12 @@ static void test_chained_sw_incr(void)
write_regn_el0(pmevcntr, 1, ALL_SET);
write_sysreg_s(0x3, PMCNTENSET_EL0);
set_pmcr(pmu.pmcr_ro | PMU_PMCR_E);
+ isb();
+
for (i = 0; i < 100; i++)
write_sysreg(0x1, pmswinc_el0);
+ isb();
report((read_sysreg(pmovsclr_el0) == 0x2) &&
(read_regn_el0(pmevcntr, 1) == 0) &&
(read_regn_el0(pmevcntr, 0) == 84),
@@ -821,10 +832,14 @@ static void test_overflow_interrupt(void)
report(expect_interrupts(0), "no overflow interrupt after preset");
set_pmcr(pmu.pmcr_ro | PMU_PMCR_E);
+ isb();
+
for (i = 0; i < 100; i++)
write_sysreg(0x2, pmswinc_el0);
+ isb();
set_pmcr(pmu.pmcr_ro);
+ isb();
report(expect_interrupts(0), "no overflow interrupt after counting");
/* enable interrupts */
@@ -879,6 +894,7 @@ static bool check_cycles_increase(void)
set_pmccfiltr(0); /* count cycles in EL0, EL1, but not EL2 */
set_pmcr(get_pmcr() | PMU_PMCR_LC | PMU_PMCR_C | PMU_PMCR_E);
+ isb();
for (int i = 0; i < NR_SAMPLES; i++) {
uint64_t a, b;
@@ -894,6 +910,7 @@ static bool check_cycles_increase(void)
}
set_pmcr(get_pmcr() & ~PMU_PMCR_E);
+ isb();
return success;
}
--
2.37.1.559.g78731f0fdb-goog
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-08-05 0:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 0:41 [kvm-unit-tests PATCH v3 0/3] arm: pmu: Fixes for bare metal Ricardo Koller
2022-08-05 0:41 ` Ricardo Koller [this message]
2022-08-09 15:21 ` [kvm-unit-tests PATCH v3 1/3] arm: pmu: Add missing isb()'s after sys register writing Alexandru Elisei
2022-08-05 0:41 ` [kvm-unit-tests PATCH v3 2/3] arm: pmu: Reset the pmu registers before starting some tests Ricardo Koller
2022-08-10 19:02 ` Andrew Jones
2022-08-10 23:33 ` Ricardo Koller
2022-08-11 7:04 ` Andrew Jones
2022-08-11 18:51 ` Ricardo Koller
2022-08-05 0:41 ` [kvm-unit-tests PATCH v3 3/3] arm: pmu: Check for overflow in the low counter in chained counters tests Ricardo Koller
2022-08-10 17:30 ` Oliver Upton
2022-08-10 18:28 ` Andrew Jones
2022-08-10 17:33 ` [kvm-unit-tests PATCH v3 0/3] arm: pmu: Fixes for bare metal Oliver Upton
2022-10-04 16:20 ` Eric Auger
2022-10-04 16:58 ` Alexandru Elisei
2022-10-04 17:31 ` Eric Auger
2022-10-05 9:21 ` Alexandru Elisei
2022-10-05 9:41 ` Alexandru Elisei
2022-10-05 9:51 ` Eric Auger
2022-10-05 9:50 ` Eric Auger
2022-10-06 9:25 ` Alexandru Elisei
2022-10-11 3:50 ` Ricardo Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220805004139.990531-2-ricarkol@google.com \
--to=ricarkol@google.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).