From: Shaoqin Huang <shahuang@redhat.com>
To: kvmarm@lists.linux.dev
Cc: Shaoqin Huang <shahuang@redhat.com>,
Andrew Jones <andrew.jones@linux.dev>,
kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH v2 1/2] arm: Replace the obsolete qemu script
Date: Thu, 2 Mar 2023 23:10:51 -0500 [thread overview]
Message-ID: <20230303041052.176745-2-shahuang@redhat.com> (raw)
In-Reply-To: <20230303041052.176745-1-shahuang@redhat.com>
The qemu script used to detect the testdev is obsoleted, replace it
with the modern way to detect if testdev exists which was first
introduced at QEMU v2.7.50 by:
517b3d4016 (chardev: Add 'help' option to print all available chardev backend types).
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
---
arm/run | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arm/run b/arm/run
index 1284891..b918029 100755
--- a/arm/run
+++ b/arm/run
@@ -59,8 +59,7 @@ if ! $qemu $M -device '?' 2>&1 | grep virtconsole > /dev/null; then
exit 2
fi
-if $qemu $M -chardev testdev,id=id -initrd . 2>&1 \
- | grep backend > /dev/null; then
+if ! $qemu $M -chardev '?' | grep -q testdev; then
echo "$qemu doesn't support chr-testdev. Exiting."
exit 2
fi
--
2.39.1
next prev parent reply other threads:[~2023-03-03 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 4:10 [kvm-unit-tests PATCH v2 0/2] Clean up the arm/run script Shaoqin Huang
2023-03-03 4:10 ` Shaoqin Huang [this message]
2023-03-03 4:10 ` [kvm-unit-tests PATCH v2 2/2] arm: Clean up the run script Shaoqin Huang
2023-03-21 15:41 ` [kvm-unit-tests PATCH v2 0/2] Clean up the arm/run script Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303041052.176745-2-shahuang@redhat.com \
--to=shahuang@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).