From: Marc Zyngier <maz@kernel.org>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: jason@lakedaemon.net, linux-kernel@vger.kernel.org,
tglx@linutronix.de, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] irqchip/gic-v4.1: Fix programming of GICR_VPROPBASER_4_1_SIZE
Date: Wed, 05 Feb 2020 12:43:51 +0000 [thread overview]
Message-ID: <29e6c483b71dcf28e9b140f4edfe566d@kernel.org> (raw)
In-Reply-To: <20200204090940.1225-2-yuzenghui@huawei.com>
On 2020-02-04 09:09, Zenghui Yu wrote:
> The Size field of GICv4.1 VPROPBASER register indicates number of
> pages minus one and together Page_Size and Size control the vPEID
> width. Let's respect this requirement of the architecture.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c
> b/drivers/irqchip/irq-gic-v3-its.c
> index e5a25d97f8db..992bc72cab6f 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -2531,7 +2531,7 @@ static int allocate_vpe_l1_table(void)
> npg = 1;
> }
>
> - val |= FIELD_PREP(GICR_VPROPBASER_4_1_SIZE, npg);
> + val |= FIELD_PREP(GICR_VPROPBASER_4_1_SIZE, npg - 1);
>
> /* Right, that's the number of CPU pages we need for L1 */
> np = DIV_ROUND_UP(npg * psz, PAGE_SIZE);
Indeed, nice catch.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-02-05 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 9:09 [PATCH 0/5] irqchip/gic-v4.1: Cleanup and fixes for GICv4.1 Zenghui Yu
2020-02-04 9:09 ` [PATCH 1/5] irqchip/gic-v4.1: Fix programming of GICR_VPROPBASER_4_1_SIZE Zenghui Yu
2020-02-05 12:43 ` Marc Zyngier [this message]
2020-02-04 9:09 ` [PATCH 2/5] irqchip/gic-v4.1: Set vpe_l1_base for all redistributors Zenghui Yu
2020-02-04 9:09 ` [PATCH RFC 3/5] irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level Zenghui Yu
2020-02-05 12:27 ` Marc Zyngier
2020-02-04 9:09 ` [PATCH 4/5] irqchip/gic-v4.1: Drop 'tmp' in inherit_vpe_l1_table_from_rd() Zenghui Yu
2020-02-04 9:09 ` [PATCH 5/5] irqchip/gic-v3-its: Remove superfluous WARN_ON Zenghui Yu
2020-02-05 12:46 ` [PATCH 0/5] irqchip/gic-v4.1: Cleanup and fixes for GICv4.1 Marc Zyngier
2020-02-06 6:22 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e6c483b71dcf28e9b140f4edfe566d@kernel.org \
--to=maz@kernel.org \
--cc=jason@lakedaemon.net \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).