From: Zenghui Yu <yuzenghui@huawei.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Peter Shier <pshier@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 04/10] KVM: arm64: selftests: Add basic support for arch_timers
Date: Sat, 14 Aug 2021 17:10:02 +0800 [thread overview]
Message-ID: <35c06dff-36cf-3836-e469-bedcf3c04a4d@huawei.com> (raw)
In-Reply-To: <20210813211211.2983293-5-rananta@google.com>
On 2021/8/14 5:12, Raghavendra Rao Ananta wrote:
> Add a minimalistic library support to access the virtual timers,
> that can be used for simple timing functionalities, such as
> introducing delays in the guest.
>
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> ---
> .../kvm/include/aarch64/arch_timer.h | 138 ++++++++++++++++++
> 1 file changed, 138 insertions(+)
> create mode 100644 tools/testing/selftests/kvm/include/aarch64/arch_timer.h
>
> diff --git a/tools/testing/selftests/kvm/include/aarch64/arch_timer.h b/tools/testing/selftests/kvm/include/aarch64/arch_timer.h
> new file mode 100644
> index 000000000000..e6144ab95348
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/include/aarch64/arch_timer.h
> @@ -0,0 +1,138 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * ARM Generic Interrupt Controller (GIC) specific defines
This isn't GIC specific, but arch timer.
> + */
> +
> +#ifndef SELFTEST_KVM_ARCH_TIMER_H
> +#define SELFTEST_KVM_ARCH_TIMER_H
> +
> +#include <linux/sizes.h>
Do we really need it?
> +
> +#include "processor.h"
> +
> +enum arch_timer {
> + VIRTUAL,
> + PHYSICAL,
> +};
> +
> +#define CTL_ENABLE (1 << 0)
> +#define CTL_ISTATUS (1 << 2)
> +#define CTL_IMASK (1 << 1)
nitpick: Move CTL_IMASK before CTL_ISTATUS ?
> +
> +#define msec_to_cycles(msec) \
> + (timer_get_cntfrq() * (uint64_t)(msec) / 1000)
> +
> +#define usec_to_cycles(usec) \
> + (timer_get_cntfrq() * (uint64_t)(usec) / 1000000)
> +
> +#define cycles_to_usec(cycles) \
> + ((uint64_t)(cycles) * 1000000 / timer_get_cntfrq())
> +
> +static inline uint32_t timer_get_cntfrq(void)
> +{
> + return read_sysreg(cntfrq_el0);
> +}
> +
> +static inline uint64_t timer_get_cntct(enum arch_timer timer)
> +{
> + isb();
> +
> + switch (timer) {
> + case VIRTUAL:
> + return read_sysreg(cntvct_el0);
> + case PHYSICAL:
> + return read_sysreg(cntpct_el0);
> + default:
> + GUEST_ASSERT_1(0, timer);
> + }
> +
> + /* We should not reach here */
> + return 0;
> +}
> +
> +static inline void timer_set_cval(enum arch_timer timer, uint64_t cval)
> +{
> + switch (timer) {
> + case VIRTUAL:
> + return write_sysreg(cntv_cval_el0, cval);
> + case PHYSICAL:
> + return write_sysreg(cntp_cval_el0, cval);
> + default:
> + GUEST_ASSERT_1(0, timer);
> + }
> +
> + isb();
ISB should be performed before 'return'. And the same for
timer_set_{tval,ctl}.
Thanks,
Zenghui
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-08-14 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 21:12 [PATCH 00/10] KVM: arm64: selftests: Introduce arch_timer selftest Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 01/10] KVM: arm64: selftests: Add MMIO readl/writel support Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 02/10] KVM: arm64: selftests: Add write_sysreg_s and read_sysreg_s Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 03/10] KVM: arm64: selftests: Add support for cpu_relax Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 04/10] KVM: arm64: selftests: Add basic support for arch_timers Raghavendra Rao Ananta
2021-08-14 9:10 ` Zenghui Yu [this message]
2021-08-16 20:01 ` Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 05/10] KVM: arm64: selftests: Add basic support to generate delays Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 06/10] KVM: arm64: selftests: Add support to disable and enable local IRQs Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 07/10] KVM: arm64: selftests: Add support to get the vcpuid from MPIDR_EL1 Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 08/10] KVM: arm64: selftests: Add light-weight spinlock support Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 09/10] KVM: arm64: selftests: Add basic GICv3 support Raghavendra Rao Ananta
2021-08-13 21:12 ` [PATCH 10/10] KVM: arm64: selftests: Add arch_timer test Raghavendra Rao Ananta
2021-08-16 12:15 ` [PATCH 00/10] KVM: arm64: selftests: Introduce arch_timer selftest Andrew Jones
2021-08-16 20:56 ` Raghavendra Rao Ananta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c06dff-36cf-3836-e469-bedcf3c04a4d@huawei.com \
--to=yuzenghui@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=rananta@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).