kvmarm.lists.cs.columbia.edu archive mirror
 help / color / mirror / Atom feed
From: Auger Eric <eric.auger@redhat.com>
To: Jingyi Wang <wangjingyi11@huawei.com>,
	drjones@redhat.com, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Cc: maz@kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 1/8] arm64: microbench: get correct ipi received num
Date: Thu, 2 Jul 2020 14:36:33 +0200	[thread overview]
Message-ID: <39936695-eba6-d92b-db3b-fd8439503e50@redhat.com> (raw)
In-Reply-To: <20200702030132.20252-2-wangjingyi11@huawei.com>

Hi Jingyi,

On 7/2/20 5:01 AM, Jingyi Wang wrote:
> If ipi_exec() fails because of timeout, we shouldn't increase
> the number of ipi received.
> 
> Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric
> ---
>  arm/micro-bench.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arm/micro-bench.c b/arm/micro-bench.c
> index 4612f41..794dfac 100644
> --- a/arm/micro-bench.c
> +++ b/arm/micro-bench.c
> @@ -103,7 +103,9 @@ static void ipi_exec(void)
>  	while (!ipi_received && tries--)
>  		cpu_relax();
>  
> -	++received;
> +	if (ipi_received)
> +		++received;
> +
>  	assert_msg(ipi_received, "failed to receive IPI in time, but received %d successfully\n", received);
>  }
>  
> 

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

  reply	other threads:[~2020-07-02 12:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  3:01 [kvm-unit-tests PATCH v2 0/8] arm/arm64: Add IPI/LPI/vtimer latency test Jingyi Wang
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 1/8] arm64: microbench: get correct ipi received num Jingyi Wang
2020-07-02 12:36   ` Auger Eric [this message]
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 2/8] arm64: microbench: Use the funcions for ipi test as the general functions for gic(ipi/lpi/timer) test Jingyi Wang
2020-07-02  5:25   ` Andrew Jones
2020-07-02  8:21     ` Jingyi Wang
2020-07-02 12:36   ` Auger Eric
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 3/8] arm64: microbench: gic: Add gicv4.1 support for ipi latency test Jingyi Wang
2020-07-02  8:22   ` Marc Zyngier
2020-07-02  9:02     ` Jingyi Wang
2020-07-02  9:17       ` Marc Zyngier
2020-07-02  9:29         ` Jingyi Wang
2020-07-02 12:36     ` Auger Eric
2020-07-02 13:03       ` Marc Zyngier
2020-07-02 12:57   ` Auger Eric
2020-07-02 13:08     ` Marc Zyngier
2020-07-02 13:42       ` Auger Eric
2020-07-03  3:39         ` Jingyi Wang
2020-07-02 21:33     ` Andrew Jones
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 4/8] arm64: its: Handle its command queue wrapping Jingyi Wang
2020-07-02 13:01   ` Auger Eric
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 5/8] arm64: microbench: its: Add LPI latency test Jingyi Wang
2020-07-02 13:13   ` Auger Eric
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 6/8] arm64: microbench: Allow each test to specify its running times Jingyi Wang
2020-07-02  5:29   ` Andrew Jones
2020-07-02  8:46     ` Jingyi Wang
2020-07-02 13:17     ` Auger Eric
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 7/8] arm64: microbench: Add time limit for each individual test Jingyi Wang
2020-07-02  5:48   ` Andrew Jones
2020-07-02  8:47     ` Jingyi Wang
2020-07-02 13:23   ` Auger Eric
2020-07-03  3:42     ` Jingyi Wang
2020-07-02  3:01 ` [kvm-unit-tests PATCH v2 8/8] arm64: microbench: Add vtimer latency test Jingyi Wang
2020-07-02  5:44   ` Andrew Jones
2020-07-02  8:56     ` Jingyi Wang
2020-07-02 13:36   ` Auger Eric
2020-07-03  7:41     ` Jingyi Wang
2020-07-03  7:45       ` Auger Eric
2020-07-06 12:23         ` Jingyi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39936695-eba6-d92b-db3b-fd8439503e50@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=maz@kernel.org \
    --cc=wangjingyi11@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).