From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Rich Felker" <dalias@libc.org>,
linux-ia64@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
linux-mm@kvack.org, "Paul Mackerras" <paulus@samba.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Will Deacon" <will@kernel.org>,
kvmarm@lists.cs.columbia.edu, "Jonas Bonn" <jonas@southpole.se>,
"Brian Cain" <bcain@codeaurora.org>,
linux-hexagon@vger.kernel.org, linux-sh@vger.kernel.org,
"Russell King" <linux@armlinux.org.uk>,
"Ley Foon Tan" <ley.foon.tan@intel.com>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
uclinux-h8-devel@lists.sourceforge.jp,
linux-arch@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Łukasz Stelmach" <l.stelmach@samsung.com>,
kvm-ppc@vger.kernel.org,
"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
openrisc@lists.librecores.org,
"Stafford Horne" <shorne@gmail.com>,
"Guan Xuetao" <gxt@pku.edu.cn>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@c-s.fr>,
"Tony Luck" <tony.luck@intel.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org, "Marc Zyngier" <maz@kernel.org>,
nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 02/14] arm: add support for folded p4d page tables
Date: Thu, 7 May 2020 14:16:56 +0200 [thread overview]
Message-ID: <39ba8a04-d6b5-649d-c289-0c8b27cb66c5@samsung.com> (raw)
In-Reply-To: <20200414153455.21744-3-rppt@kernel.org>
Hi
On 14.04.2020 17:34, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Implement primitives necessary for the 4th level folding, add walks of p4d
> level where appropriate, and remove __ARCH_USE_5LEVEL_HACK.
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Today I've noticed that kexec is broken on ARM 32bit. Bisecting between
current linux-next and v5.7-rc1 pointed to this commit. I've tested this
on Odroid XU4 and Raspberry Pi4 boards. Here is the relevant log:
# kexec --kexec-syscall -l zImage --append "$(cat /proc/cmdline)"
memory_range[0]:0x40000000..0xbe9fffff
memory_range[0]:0x40000000..0xbe9fffff
# kexec -e
kexec_core: Starting new kernel
8<--- cut here ---
Unable to handle kernel paging request at virtual address c010f1f4
pgd = c6817793
[c010f1f4] *pgd=4000041e(bad)
Internal error: Oops: 80d [#1] PREEMPT ARM
Modules linked in:
CPU: 0 PID: 1329 Comm: kexec Tainted: G W
5.7.0-rc3-00127-g6cba81ed0f62 #611
Hardware name: Samsung Exynos (Flattened Device Tree)
PC is at machine_kexec+0x40/0xfc
LR is at 0xffffffff
pc : [<c010f0b4>] lr : [<ffffffff>] psr: 60000013
sp : ebc13e60 ip : 40008000 fp : 00000001
r10: 00000058 r9 : fee1dead r8 : 00000001
r7 : c121387c r6 : 6c224000 r5 : ece40c00 r4 : ec222000
r3 : c010f1f4 r2 : c1100000 r1 : c1100000 r0 : 418d0000
Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
Control: 10c5387d Table: 6bc14059 DAC: 00000051
Process kexec (pid: 1329, stack limit = 0x366bb4dc)
Stack: (0xebc13e60 to 0xebc14000)
...
[<c010f0b4>] (machine_kexec) from [<c01c0d84>] (kernel_kexec+0x74/0x7c)
[<c01c0d84>] (kernel_kexec) from [<c014b1bc>] (__do_sys_reboot+0x1f8/0x210)
[<c014b1bc>] (__do_sys_reboot) from [<c0100060>] (ret_fast_syscall+0x0/0x28)
Exception stack(0xebc13fa8 to 0xebc13ff0)
...
---[ end trace 3e8d6c81723c778d ]---
1329 Segmentation fault ./kexec -e
> ---
> arch/arm/include/asm/pgtable.h | 1 -
> arch/arm/lib/uaccess_with_memcpy.c | 7 +++++-
> arch/arm/mach-sa1100/assabet.c | 2 +-
> arch/arm/mm/dump.c | 29 +++++++++++++++++-----
> arch/arm/mm/fault-armv.c | 7 +++++-
> arch/arm/mm/fault.c | 22 ++++++++++------
> arch/arm/mm/idmap.c | 3 ++-
> arch/arm/mm/init.c | 2 +-
> arch/arm/mm/ioremap.c | 12 ++++++---
> arch/arm/mm/mm.h | 2 +-
> arch/arm/mm/mmu.c | 35 +++++++++++++++++++++-----
> arch/arm/mm/pgd.c | 40 ++++++++++++++++++++++++------
> 12 files changed, 125 insertions(+), 37 deletions(-)
>
> ...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-05-07 12:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:34 [PATCH v4 00/14] mm: remove __ARCH_HAS_5LEVEL_HACK Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 01/14] h8300: remove usage of __ARCH_USE_5LEVEL_HACK Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 02/14] arm: add support for folded p4d page tables Mike Rapoport
[not found] ` <CGME20200507121658eucas1p240cf4a3e0fe5c22dda5ec4f72734149f@eucas1p2.samsung.com>
2020-05-07 12:16 ` Marek Szyprowski [this message]
2020-05-07 16:11 ` Mike Rapoport
2020-05-08 6:53 ` Marek Szyprowski
2020-05-08 17:42 ` Mike Rapoport
2020-05-11 6:36 ` Marek Szyprowski
2020-05-11 14:15 ` Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 03/14] arm64: " Mike Rapoport
2020-05-15 18:40 ` Andrew Morton
2020-05-16 17:20 ` Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 04/14] hexagon: remove __ARCH_USE_5LEVEL_HACK Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 05/14] ia64: add support for folded p4d page tables Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 06/14] nios2: " Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 07/14] openrisc: " Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 08/14] powerpc: " Mike Rapoport
2020-06-03 19:05 ` Andrew Morton
2020-06-04 9:50 ` Qian Cai
2020-04-14 15:34 ` [PATCH v4 09/14] sh: fault: Modernize printing of kernel messages Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 10/14] sh: drop __pXd_offset() macros that duplicate pXd_index() ones Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 11/14] sh: add support for folded p4d page tables Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 12/14] unicore32: remove __ARCH_USE_5LEVEL_HACK Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 13/14] asm-generic: remove pgtable-nop4d-hack.h Mike Rapoport
2020-04-14 15:34 ` [PATCH v4 14/14] mm: remove __ARCH_HAS_5LEVEL_HACK and include/asm-generic/5level-fixup.h Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ba8a04-d6b5-649d-c289-0c8b27cb66c5@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=bcain@codeaurora.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@c-s.fr \
--cc=dalias@libc.org \
--cc=fenghua.yu@intel.com \
--cc=geert+renesas@glider.be \
--cc=gxt@pku.edu.cn \
--cc=jonas@southpole.se \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=l.stelmach@samsung.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maz@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nios2-dev@lists.rocketboards.org \
--cc=openrisc@lists.librecores.org \
--cc=paulus@samba.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tony.luck@intel.com \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).