From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC30BC433DF for ; Mon, 20 Jul 2020 14:56:57 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 74AE522B4E for ; Mon, 20 Jul 2020 14:56:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="E4OcyNII" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74AE522B4E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 126AB4B19F; Mon, 20 Jul 2020 10:56:57 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I7MTDyn+SrIp; Mon, 20 Jul 2020 10:56:56 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F1FBA4B194; Mon, 20 Jul 2020 10:56:55 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E932C4B108 for ; Mon, 20 Jul 2020 10:56:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V6HD0jtIw7iK for ; Mon, 20 Jul 2020 10:56:53 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C66D54B0C9 for ; Mon, 20 Jul 2020 10:56:53 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A87EC22B4E; Mon, 20 Jul 2020 14:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595257012; bh=lMz4qhBNDbC5WHY1eOEyUsKYsYkeqLEPAcKmFb0MdS4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E4OcyNII4eRNd+xlEjq1vDV3g2ejs60+hD9nbJnOz/DNZ9+D2NoGuTfa+Njn231qa nojxsx7MmaG+wkMvWKtHwY7yjO9Q1FJOoP3JLNZoIgu8I7Jj+0VMj/9MYBvOlxOdqc bH1QX29GEmB5Iv+KwgzHgyvUv6g5aa9A9ZYb/J1w= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jxXDn-00DLCV-91; Mon, 20 Jul 2020 15:56:51 +0100 MIME-Version: 1.0 Date: Mon, 20 Jul 2020 15:56:51 +0100 From: Marc Zyngier To: Andrew Scull Subject: Re: [PATCH 07/37] KVM: arm64: Separate SError detection from VAXorcism In-Reply-To: <20200720141349.GA2179496@google.com> References: <20200715184438.1390996-1-ascull@google.com> <20200715184438.1390996-8-ascull@google.com> <87a6zxxknl.wl-maz@kernel.org> <20200720141349.GA2179496@google.com> User-Agent: Roundcube Webmail/1.4.5 Message-ID: <500058465906ab72122127cf745568c6@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: ascull@google.com, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2020-07-20 15:13, Andrew Scull wrote: > On Sat, Jul 18, 2020 at 10:00:30AM +0100, Marc Zyngier wrote: >> Hi Andrew, >> >> On Wed, 15 Jul 2020 19:44:08 +0100, >> Andrew Scull wrote: >> > >> > When exiting a guest, just check whether there is an SError pending and >> > set the bit in the exit code. The fixup then initiates the ceremony >> > should it be required. >> > >> > The separation allows for easier choices to be made as to whether the >> > demonic consultation should proceed. >> >> Such as? > > It's used in the next patch to keep host SErrors pending and left for > the host to handle when reentering the host vcpu. IIUC, this matches > the > previous behaviour since hyp would mask SErrors. > > We wanted to avoid the need to convert host SErrors into virtual ones > and I opted for this approach to keep as much of the logic/policy as > possible in C. Right. That's the kind of information you should put in your commit message, as it makes your intent much clearer. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm